Skip to content

Conversation

@pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Sep 19, 2025

This should fix the IO errors
that were happening with 8.2
and 8.3.


📚 Documentation preview 📚: https://datacube-explorer--876.org.readthedocs.build/en/876/

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.23%. Comparing base (27e8564) to head (b3784c9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #876   +/-   ##
========================================
  Coverage    84.23%   84.23%           
========================================
  Files           35       35           
  Lines         4199     4199           
  Branches       526      526           
========================================
  Hits          3537     3537           
  Misses         471      471           
  Partials       191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjonsson pjonsson marked this pull request as draft September 19, 2025 14:22
This should fix the IO errors
that were happening with 8.2
and 8.3.
@pjonsson pjonsson changed the title Update to Click 8.3.0 Update to Click 8.3.1+patch Nov 17, 2025
@pjonsson pjonsson marked this pull request as ready for review November 17, 2025 16:21
@pjonsson
Copy link
Contributor Author

@omad this is click 8.3.1 + a patch to prevent the StreamMixer's streams from getting closed by other objects.

This repository is the one that reliably triggers the "ValueError: I/O operation on closed file", so could we merge this so the patch gets some stress testing? The patch only touches the testing parts of click, so unless one is using the CliRunner for testing, this is pretty much a stock Click 8.3.1 as far as I know.

I don't mind if this PR is reverted when it's time to do a release of Explorer, with a bit of luck there will be a Click 8.3.2 out by then that we should be using.

@pjonsson pjonsson requested a review from omad November 17, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant