compose: merge db into main file #1415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All invocations of docker compose in the repository pass the database file as parameter, so put that into the regular file instead and stop passing the extra parameter.
The file argument to docker compose is no longer required after the database is merged into the main compose file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1415 +/- ##
========================================
Coverage 92.81% 92.81%
========================================
Files 53 53
Lines 7233 7233
========================================
Hits 6713 6713
Misses 520 520 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All invocations of docker compose
in the repository pass the database
file as parameter, so put that into
the regular file instead and stop
passing the extra parameter.
This allows removing the file argument
to docker compose completely in many cases.
📚 Documentation preview 📚: https://datacube-ows--1415.org.readthedocs.build/en/1415/