fix: don't paste if axis is flipped #244 #246
Conversation
Don't consider pasting from source to destination when computing reproject roi if axis is flipped.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #246 +/- ##
========================================
Coverage 94.21% 94.21%
========================================
Files 34 34
Lines 5855 5857 +2
========================================
+ Hits 5516 5518 +2
Misses 339 339 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pjonsson
left a comment
pjonsson
left a comment
There was a problem hiding this comment.
I don't know the surrounding code, but taking the slow path is better than being wrong.
| return False, "flipped axis" | ||
|
|
||
| # Expect identity for scale change | ||
| if any(abs(abs(s) - 1) > stol for s in (sx, sy)): # not equal scaling across axis? |
There was a problem hiding this comment.
One question on this line - not particularly important as this fixes my original issue but.
Is there a need for the two calls to abs?
I found that changing this line to if any(abs(s - 1) > stol for s in (sx, sy)): made more sense in my head and also meant that can_paste is set to false if any axes are flipped.
There was a problem hiding this comment.
yes, especially since "reason" messages aren't used, most likely, probably an early debugging tool
Don't consider pasting from source to destination
when computing reproject roi if axis is flipped.
Closes #244