Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.

WIP: Create Dockerfile for ubi base images for use in OpenShift#14

Open
LaVLaS wants to merge 2 commits intoopendatahub-io-contrib:openshiftfrom
LaVLaS:feature/dockerfile.ubi
Open

WIP: Create Dockerfile for ubi base images for use in OpenShift#14
LaVLaS wants to merge 2 commits intoopendatahub-io-contrib:openshiftfrom
LaVLaS:feature/dockerfile.ubi

Conversation

@LaVLaS
Copy link
Copy Markdown

@LaVLaS LaVLaS commented Feb 17, 2021

Related Issues and Dependencies

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Creates a Dockerfile that use Red Hat ubi8 images for building the operator. This allows for building with images that have better support when running in OpenShift and alleviates any issues when builds fail due to docker rate limit issues.

Description

The new Dockerfile.ubi uses ubi8/go-toolset:1.13.15 as the builder image and ubi8/ubi-minimal as the operator base image

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
@LaVLaS LaVLaS added the enhancement New feature or request label Feb 17, 2021
@sesheta
Copy link
Copy Markdown

sesheta commented Feb 17, 2021

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/dnephin/pre-commit-golang.
[INFO] Initializing environment for local:yamllint.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Run Gofmt................................................................Passed
Check yaml files with yamllint...........................................Failed
- hook id: yamllint
- exit code: 1

config/webhook/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)
  6:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/auth_proxy_role.yaml
  1:1       warning  missing document start "---"  (document-start)
  6:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)

config/certmanager/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)
  5:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/manager/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)
  6:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/webhook/service.yaml
  1:1       error    too many blank lines (1 > 0)  (empty-lines)
  2:1       warning  missing document start "---"  (document-start)

config/manager/manager.yaml
  1:1       warning  missing document start "---"  (document-start)
  26:7      error    wrong indentation: expected 8 but found 6  (indentation)
  27:9      error    wrong indentation: expected 10 but found 8  (indentation)
  29:9      error    wrong indentation: expected 10 but found 8  (indentation)

config/crd/kustomization.yaml
  4:1       warning  missing document start "---"  (document-start)
  5:1       error    wrong indentation: expected 2 but found 0  (indentation)
  12:2      warning  missing starting space in comment  (comments)
  13:2      warning  missing starting space in comment  (comments)
  18:2      warning  missing starting space in comment  (comments)
  19:2      warning  missing starting space in comment  (comments)
  24:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/default/manager_auth_proxy_patch.yaml
  3:1       warning  missing document start "---"  (document-start)
  12:7      error    wrong indentation: expected 8 but found 6  (indentation)
  15:9      error    wrong indentation: expected 10 but found 8  (indentation)
  20:9      error    wrong indentation: expected 10 but found 8  (indentation)
  24:9      error    wrong indentation: expected 10 but found 8  (indentation)

hack/sample/postgres-k8s/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

config/rbac/leader_election_role_binding.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:1      error    wrong indentation: expected 2 but found 0  (indentation)

hack/sample/postgres-celery-redis/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)
  27:20     warning  truthy value should be one of [false, true]  (truthy)

hack/sample/postgres-celery-redis/redis-secret.yaml
  18:1      warning  missing document start "---"  (document-start)

config/webhook/kustomizeconfig.yaml
  3:1       warning  missing document start "---"  (document-start)
  4:1       error    wrong indentation: expected 2 but found 0  (indentation)
  15:1      error    wrong indentation: expected 2 but found 0  (indentation)
  25:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/airflowbase_viewer_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  16:3      error    wrong indentation: expected 4 but found 2  (indentation)
  18:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/cloudsql-celery/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

.aicoe-ci.yaml
  1:1       warning  missing document start "---"  (document-start)

config/rbac/airflowcluster_editor_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  22:3      error    wrong indentation: expected 4 but found 2  (indentation)
  24:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/postgres-celery-redis/redis.yaml
  18:1      warning  missing document start "---"  (document-start)
  49:11     error    wrong indentation: expected 12 but found 10  (indentation)
  52:11     error    wrong indentation: expected 12 but found 10  (indentation)

hack/sample/cloudsql-local/cluster.yaml
  17:1      warning  missing document start "---"  (document-start)

config/rbac/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/role_binding.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:1      error    wrong indentation: expected 2 but found 0  (indentation)

hack/sample/cloudsql-k8s/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

cloudbuild.yaml
  21:1      warning  missing document start "---"  (document-start)
  22:1      error    wrong indentation: expected 2 but found 0  (indentation)
  23:164    error    too many spaces inside brackets  (brackets)

config/default/kustomization.yaml
  2:1       warning  missing document start "---"  (document-start)
  12:2      warning  missing starting space in comment  (comments)
  16:1      error    wrong indentation: expected 2 but found 0  (indentation)
  20:2      warning  missing starting space in comment  (comments)
  22:2      warning  missing starting space in comment  (comments)
  24:2      warning  missing starting space in comment  (comments)
  27:3      warning  comment not indented like content  (comments-indentation)
  30:1      error    wrong indentation: expected 2 but found 0  (indentation)
  31:3      warning  comment not indented like content  (comments-indentation)
  36:2      warning  missing starting space in comment  (comments)
  39:2      warning  missing starting space in comment  (comments)
  44:2      warning  missing starting space in comment  (comments)
  49:2      warning  missing starting space in comment  (comments)
  57:2      warning  missing starting space in comment  (comments)
  63:2      warning  missing starting space in comment  (comments)
  70:2      warning  missing starting space in comment  (comments)

config/default/webhookcainjection_patch.yaml
  3:1       warning  missing document start "---"  (document-start)

hack/sample/postgres-celery/base.yaml
  18:1      warning  missing document start "---"  (document-start)
  24:15     warning  truthy value should be one of [false, true]  (truthy)

config/prometheus/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/samples/airflow_v1alpha1_airflowbase.yaml
  1:1       warning  missing document start "---"  (document-start)

hack/sample/cloudsql-celery/sqlproxy-secret.yaml
  18:1      warning  missing document start "---"  (document-start)
  24:29     error    trailing spaces  (trailing-spaces)

config/rbac/auth_proxy_role_binding.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/crd/patches/webhook_in_airflowclusters.yaml
  3:1       warning  missing document start "---"  (document-start)

hack/sample/mysql-local/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  32:6      warning  missing starting space in comment  (comments)

config/rbac/airflowbase_editor_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  22:3      error    wrong indentation: expected 4 but found 2  (indentation)
  24:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/cloudsql-celery/base.yaml
  17:1      warning  missing document start "---"  (document-start)
  23:11     error    wrong indentation: expected 4 but found 10  (indentation)

config/samples/airflow_v1alpha1_airflowcluster.yaml
  1:1       warning  missing document start "---"  (document-start)

hack/sample/postgres-local/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

config/crd/patches/cainjection_in_airflowclusters.yaml
  3:1       warning  missing document start "---"  (document-start)

config/certmanager/kustomizeconfig.yaml
  1:91      error    trailing spaces  (trailing-spaces)
  2:1       warning  missing document start "---"  (document-start)
  3:1       error    wrong indentation: expected 2 but found 0  (indentation)
  11:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/prometheus/monitor.yaml
  1:1       error    too many blank lines (1 > 0)  (empty-lines)
  3:1       warning  missing document start "---"  (document-start)

config/rbac/airflowcluster_viewer_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  16:3      error    wrong indentation: expected 4 but found 2  (indentation)
  18:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/mysql-celery-gcs/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

hack/sample/mysql-celery/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

config/default/manager_webhook_patch.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:7      error    wrong indentation: expected 8 but found 6  (indentation)
  12:9      error    wrong indentation: expected 10 but found 8  (indentation)
  16:9      error    wrong indentation: expected 10 but found 8  (indentation)
  20:7      error    wrong indentation: expected 8 but found 6  (indentation)

hack/appcrd.yaml
  17:1      warning  missing document start "---"  (document-start)

config/certmanager/certificate.yaml
  4:1       warning  missing document start "---"  (document-start)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  25:35     warning  too few spaces before comment  (comments)

config/crd/kustomizeconfig.yaml
  2:1       warning  missing document start "---"  (document-start)
  3:1       error    wrong indentation: expected 2 but found 0  (indentation)
  11:1      error    wrong indentation: expected 2 but found 0  (indentation)
  17:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/leader_election_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  22:3      error    wrong indentation: expected 4 but found 2  (indentation)
  24:3      error    wrong indentation: expected 4 but found 2  (indentation)
  28:3      error    wrong indentation: expected 4 but found 2  (indentation)
  30:3      error    wrong indentation: expected 4 but found 2  (indentation)
  32:3      error    wrong indentation: expected 4 but found 2  (indentation)

config/crd/patches/cainjection_in_airflowbases.yaml
  3:1       warning  missing document start "---"  (document-start)

config/rbac/auth_proxy_service.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/postgres-celery-memorystore/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

hack/sample/mysql-k8s/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  30:6      warning  missing starting space in comment  (comments)
  31:6      warning  missing starting space in comment  (comments)

hack/sample/mysql-celery/base.yaml
  18:1      warning  missing document start "---"  (document-start)
  24:15     warning  truthy value should be one of [false, true]  (truthy)

config/crd/patches/webhook_in_airflowbases.yaml
  3:1       warning  missing document start "---"  (document-start)

.github/workflows/ci.yml
  18:1      warning  truthy value should be one of [false, true]  (truthy)

hack/sample/postgres-celery/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

Check for merge conflicts................................................Passed
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing docs/userguide.md
Fixing hack/boilerplate.go.txt

Mixed line ending........................................................Passed
Check that executables have shebangs.................(no files to check)Skipped
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing docs/development.md
Fixing hack/sample/cloudsql-celery/sqlproxy-secret.yaml
Fixing docs/quickstart.md
Fixing templates/base-application.yaml
Fixing docs/design.md
Fixing docs/api.md
Fixing config/certmanager/kustomizeconfig.yaml
Fixing templates/cluster-application.yaml

Add license for all yaml files...........................................Failed
- hook id: insert-license
- exit code: 1
- files were modified by this hook

Some sources ['templates/headlesssvc.yaml', 'hack/sample/postgres-celery-redis/redis.yaml', 'templates/postgres-sts.yaml', 'templates/cluster-application.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['templates/role.yaml', 'config/rbac/leader_election_role.yaml', 'config/webhook/kustomization.yaml', 'config/rbac/auth_proxy_service.yaml'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/certmanager/certificate.yaml', 'config/default/manager_auth_proxy_patch.yaml'] 
Some sources ['templates/base-application.yaml', 'hack/sample/mysql-k8s/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/role_binding.yaml'] 
Some sources ['hack/sample/mysql-celery/base.yaml', 'hack/sample/postgres-k8s/cluster.yaml', 'hack/sample/mysql-celery/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/crd/kustomizeconfig.yaml'] 
Some sources ['templates/svc.yaml', 'templates/serviceaccount.yaml', 'hack/sample/postgres-celery-redis/redis-secret.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/airflowcluster_viewer_role.yaml', 'config/samples/airflow_v1alpha1_airflowbase.yaml'] 
Some sources ['hack/sample/postgres-celery-redis/cluster.yaml', 'hack/sample/mysql-local/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources ['templates/route.yaml', 'hack/sample/postgres-celery/cluster.yaml', 'templates/mysql-sts.yaml', 'hack/sample/cloudsql-celery/base.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/airflowbase_editor_role.yaml', 'config/rbac/airflowbase_viewer_role.yaml'] 
Some sources ['templates/worker-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/kustomization.yaml', 'config/default/webhookcainjection_patch.yaml'] 
Some sources ['hack/sample/cloudsql-k8s/cluster.yaml', 'hack/sample/cloudsql-celery/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/crd/patches/cainjection_in_airflowbases.yaml'] 
Some sources ['templates/storage.yaml', 'hack/sample/postgres-celery-memorystore/cluster.yaml', 'templates/pdb.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/leader_election_role_binding.yaml', 'config/crd/patches/webhook_in_airflowbases.yaml', 'config/webhook/service.yaml'] 
Some sources ['templates/flower-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/airflowcluster_editor_role.yaml'] 
Some sources ['templates/secret.yaml', 'hack/sample/mysql-celery-gcs/cluster.yaml', 'templates/scheduler-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/webhook/kustomizeconfig.yaml', 'config/default/kustomization.yaml', 'config/certmanager/kustomizeconfig.yaml'] 
Some sources ['hack/sample/postgres-celery/base.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/crd/kustomization.yaml', 'config/prometheus/monitor.yaml', 'config/default/manager_webhook_patch.yaml', 'config/crd/patches/webhook_in_airflowclusters.yaml'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/samples/airflow_v1alpha1_airflowcluster.yaml', 'config/rbac/auth_proxy_role.yaml'] 
Some sources ['hack/appcrd.yaml', 'templates/airflow-configmap.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/auth_proxy_role_binding.yaml', 'config/crd/patches/cainjection_in_airflowclusters.yaml'] 
Some sources ['templates/ui-sts.yaml', 'hack/sample/postgres-local/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/manager/kustomization.yaml', 'config/manager/manager.yaml'] 
Some sources ['hack/sample/cloudsql-local/cluster.yaml', 'hack/sample/cloudsql-celery/sqlproxy-secret.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/prometheus/kustomization.yaml'] 
Some sources ['templates/rolebinding.yaml', 'templates/redis-sts.yaml', 'templates/nfs-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/certmanager/kustomization.yaml'] 
Some sources ['templates/sqlproxy-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit

Add license for all md files.............................................Failed
- hook id: insert-license
- exit code: 1
- files were modified by this hook

Some sources were modified by the hook ['docs/development.md', '.github/ISSUE_TEMPLATE/redeliver_container_image.md', '.github/ISSUE_TEMPLATE/patch-release.md', 'docs/quickstart.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['.github/PULL_REQUEST_TEMPLATE.md', '.github/ISSUE_TEMPLATE/feature_request.md', '.github/ISSUE_TEMPLATE/minor-release.md', 'README.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['docs/design.md', 'docs/api.md', '.github/ISSUE_TEMPLATE/major-release.md', '.github/ISSUE_TEMPLATE/bug_report.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['docs/userguide.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit

Add license for all go files.............................................Passed

@LaVLaS LaVLaS force-pushed the feature/dockerfile.ubi branch from 4c48758 to 9453069 Compare February 17, 2021 16:06
@sesheta
Copy link
Copy Markdown

sesheta commented Feb 17, 2021

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/dnephin/pre-commit-golang.
[INFO] Initializing environment for local:yamllint.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Run Gofmt................................................................Passed
Check yaml files with yamllint...........................................Failed
- hook id: yamllint
- exit code: 1

config/webhook/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)
  6:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/auth_proxy_role.yaml
  1:1       warning  missing document start "---"  (document-start)
  6:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)

config/certmanager/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)
  5:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/manager/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)
  6:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/webhook/service.yaml
  1:1       error    too many blank lines (1 > 0)  (empty-lines)
  2:1       warning  missing document start "---"  (document-start)

config/manager/manager.yaml
  1:1       warning  missing document start "---"  (document-start)
  26:7      error    wrong indentation: expected 8 but found 6  (indentation)
  27:9      error    wrong indentation: expected 10 but found 8  (indentation)
  29:9      error    wrong indentation: expected 10 but found 8  (indentation)

config/crd/kustomization.yaml
  4:1       warning  missing document start "---"  (document-start)
  5:1       error    wrong indentation: expected 2 but found 0  (indentation)
  12:2      warning  missing starting space in comment  (comments)
  13:2      warning  missing starting space in comment  (comments)
  18:2      warning  missing starting space in comment  (comments)
  19:2      warning  missing starting space in comment  (comments)
  24:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/default/manager_auth_proxy_patch.yaml
  3:1       warning  missing document start "---"  (document-start)
  12:7      error    wrong indentation: expected 8 but found 6  (indentation)
  15:9      error    wrong indentation: expected 10 but found 8  (indentation)
  20:9      error    wrong indentation: expected 10 but found 8  (indentation)
  24:9      error    wrong indentation: expected 10 but found 8  (indentation)

hack/sample/postgres-k8s/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

config/rbac/leader_election_role_binding.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:1      error    wrong indentation: expected 2 but found 0  (indentation)

hack/sample/postgres-celery-redis/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)
  27:20     warning  truthy value should be one of [false, true]  (truthy)

hack/sample/postgres-celery-redis/redis-secret.yaml
  18:1      warning  missing document start "---"  (document-start)

config/webhook/kustomizeconfig.yaml
  3:1       warning  missing document start "---"  (document-start)
  4:1       error    wrong indentation: expected 2 but found 0  (indentation)
  15:1      error    wrong indentation: expected 2 but found 0  (indentation)
  25:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/airflowbase_viewer_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  16:3      error    wrong indentation: expected 4 but found 2  (indentation)
  18:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/cloudsql-celery/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

.aicoe-ci.yaml
  1:1       warning  missing document start "---"  (document-start)

config/rbac/airflowcluster_editor_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  22:3      error    wrong indentation: expected 4 but found 2  (indentation)
  24:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/postgres-celery-redis/redis.yaml
  18:1      warning  missing document start "---"  (document-start)
  49:11     error    wrong indentation: expected 12 but found 10  (indentation)
  52:11     error    wrong indentation: expected 12 but found 10  (indentation)

hack/sample/cloudsql-local/cluster.yaml
  17:1      warning  missing document start "---"  (document-start)

config/rbac/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/role_binding.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:1      error    wrong indentation: expected 2 but found 0  (indentation)

hack/sample/cloudsql-k8s/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

cloudbuild.yaml
  21:1      warning  missing document start "---"  (document-start)
  22:1      error    wrong indentation: expected 2 but found 0  (indentation)
  23:164    error    too many spaces inside brackets  (brackets)

config/default/kustomization.yaml
  2:1       warning  missing document start "---"  (document-start)
  12:2      warning  missing starting space in comment  (comments)
  16:1      error    wrong indentation: expected 2 but found 0  (indentation)
  20:2      warning  missing starting space in comment  (comments)
  22:2      warning  missing starting space in comment  (comments)
  24:2      warning  missing starting space in comment  (comments)
  27:3      warning  comment not indented like content  (comments-indentation)
  30:1      error    wrong indentation: expected 2 but found 0  (indentation)
  31:3      warning  comment not indented like content  (comments-indentation)
  36:2      warning  missing starting space in comment  (comments)
  39:2      warning  missing starting space in comment  (comments)
  44:2      warning  missing starting space in comment  (comments)
  49:2      warning  missing starting space in comment  (comments)
  57:2      warning  missing starting space in comment  (comments)
  63:2      warning  missing starting space in comment  (comments)
  70:2      warning  missing starting space in comment  (comments)

config/default/webhookcainjection_patch.yaml
  3:1       warning  missing document start "---"  (document-start)

hack/sample/postgres-celery/base.yaml
  18:1      warning  missing document start "---"  (document-start)
  24:15     warning  truthy value should be one of [false, true]  (truthy)

config/prometheus/kustomization.yaml
  1:1       warning  missing document start "---"  (document-start)
  2:1       error    wrong indentation: expected 2 but found 0  (indentation)

config/samples/airflow_v1alpha1_airflowbase.yaml
  1:1       warning  missing document start "---"  (document-start)

hack/sample/cloudsql-celery/sqlproxy-secret.yaml
  18:1      warning  missing document start "---"  (document-start)
  24:29     error    trailing spaces  (trailing-spaces)

config/rbac/auth_proxy_role_binding.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/crd/patches/webhook_in_airflowclusters.yaml
  3:1       warning  missing document start "---"  (document-start)

hack/sample/mysql-local/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  32:6      warning  missing starting space in comment  (comments)

config/rbac/airflowbase_editor_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  22:3      error    wrong indentation: expected 4 but found 2  (indentation)
  24:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/cloudsql-celery/base.yaml
  17:1      warning  missing document start "---"  (document-start)
  23:11     error    wrong indentation: expected 4 but found 10  (indentation)

config/samples/airflow_v1alpha1_airflowcluster.yaml
  1:1       warning  missing document start "---"  (document-start)

hack/sample/postgres-local/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

config/crd/patches/cainjection_in_airflowclusters.yaml
  3:1       warning  missing document start "---"  (document-start)

config/certmanager/kustomizeconfig.yaml
  1:91      error    trailing spaces  (trailing-spaces)
  2:1       warning  missing document start "---"  (document-start)
  3:1       error    wrong indentation: expected 2 but found 0  (indentation)
  11:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/prometheus/monitor.yaml
  1:1       error    too many blank lines (1 > 0)  (empty-lines)
  3:1       warning  missing document start "---"  (document-start)

config/rbac/airflowcluster_viewer_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  16:3      error    wrong indentation: expected 4 but found 2  (indentation)
  18:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/mysql-celery-gcs/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

hack/sample/mysql-celery/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

config/default/manager_webhook_patch.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:7      error    wrong indentation: expected 8 but found 6  (indentation)
  12:9      error    wrong indentation: expected 10 but found 8  (indentation)
  16:9      error    wrong indentation: expected 10 but found 8  (indentation)
  20:7      error    wrong indentation: expected 8 but found 6  (indentation)

hack/appcrd.yaml
  17:1      warning  missing document start "---"  (document-start)

config/certmanager/certificate.yaml
  4:1       warning  missing document start "---"  (document-start)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  25:35     warning  too few spaces before comment  (comments)

config/crd/kustomizeconfig.yaml
  2:1       warning  missing document start "---"  (document-start)
  3:1       error    wrong indentation: expected 2 but found 0  (indentation)
  11:1      error    wrong indentation: expected 2 but found 0  (indentation)
  17:1      error    wrong indentation: expected 2 but found 0  (indentation)

config/rbac/leader_election_role.yaml
  2:1       warning  missing document start "---"  (document-start)
  7:1       error    wrong indentation: expected 2 but found 0  (indentation)
  8:3       error    wrong indentation: expected 4 but found 2  (indentation)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)
  12:3      error    wrong indentation: expected 4 but found 2  (indentation)
  20:3      error    wrong indentation: expected 4 but found 2  (indentation)
  22:3      error    wrong indentation: expected 4 but found 2  (indentation)
  24:3      error    wrong indentation: expected 4 but found 2  (indentation)
  28:3      error    wrong indentation: expected 4 but found 2  (indentation)
  30:3      error    wrong indentation: expected 4 but found 2  (indentation)
  32:3      error    wrong indentation: expected 4 but found 2  (indentation)

config/crd/patches/cainjection_in_airflowbases.yaml
  3:1       warning  missing document start "---"  (document-start)

config/rbac/auth_proxy_service.yaml
  1:1       warning  missing document start "---"  (document-start)
  10:3      error    wrong indentation: expected 4 but found 2  (indentation)

hack/sample/postgres-celery-memorystore/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)

hack/sample/mysql-k8s/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  30:6      warning  missing starting space in comment  (comments)
  31:6      warning  missing starting space in comment  (comments)

hack/sample/mysql-celery/base.yaml
  18:1      warning  missing document start "---"  (document-start)
  24:15     warning  truthy value should be one of [false, true]  (truthy)

config/crd/patches/webhook_in_airflowbases.yaml
  3:1       warning  missing document start "---"  (document-start)

.github/workflows/ci.yml
  18:1      warning  truthy value should be one of [false, true]  (truthy)

hack/sample/postgres-celery/cluster.yaml
  18:1      warning  missing document start "---"  (document-start)
  25:15     warning  truthy value should be one of [false, true]  (truthy)

Check for merge conflicts................................................Passed
Detect Private Key.......................................................Passed
Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing docs/userguide.md
Fixing hack/boilerplate.go.txt

Mixed line ending........................................................Passed
Check that executables have shebangs.................(no files to check)Skipped
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing docs/development.md
Fixing hack/sample/cloudsql-celery/sqlproxy-secret.yaml
Fixing docs/quickstart.md
Fixing templates/base-application.yaml
Fixing docs/design.md
Fixing docs/api.md
Fixing config/certmanager/kustomizeconfig.yaml
Fixing templates/cluster-application.yaml

Add license for all yaml files...........................................Failed
- hook id: insert-license
- exit code: 1
- files were modified by this hook

Some sources ['templates/headlesssvc.yaml', 'hack/sample/postgres-celery-redis/redis.yaml', 'templates/postgres-sts.yaml', 'templates/cluster-application.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['templates/role.yaml', 'config/rbac/leader_election_role.yaml', 'config/webhook/kustomization.yaml', 'config/rbac/auth_proxy_service.yaml'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/certmanager/certificate.yaml', 'config/default/manager_auth_proxy_patch.yaml'] 
Some sources ['templates/base-application.yaml', 'hack/sample/mysql-k8s/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/role_binding.yaml'] 
Some sources ['hack/sample/mysql-celery/base.yaml', 'hack/sample/postgres-k8s/cluster.yaml', 'hack/sample/mysql-celery/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/crd/kustomizeconfig.yaml'] 
Some sources ['templates/svc.yaml', 'templates/serviceaccount.yaml', 'hack/sample/postgres-celery-redis/redis-secret.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/airflowcluster_viewer_role.yaml', 'config/samples/airflow_v1alpha1_airflowbase.yaml'] 
Some sources ['hack/sample/postgres-celery-redis/cluster.yaml', 'hack/sample/mysql-local/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources ['templates/route.yaml', 'hack/sample/postgres-celery/cluster.yaml', 'templates/mysql-sts.yaml', 'hack/sample/cloudsql-celery/base.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/airflowbase_editor_role.yaml', 'config/rbac/airflowbase_viewer_role.yaml'] 
Some sources ['templates/worker-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/kustomization.yaml', 'config/default/webhookcainjection_patch.yaml'] 
Some sources ['hack/sample/cloudsql-k8s/cluster.yaml', 'hack/sample/cloudsql-celery/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/crd/patches/cainjection_in_airflowbases.yaml'] 
Some sources ['templates/storage.yaml', 'hack/sample/postgres-celery-memorystore/cluster.yaml', 'templates/pdb.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/leader_election_role_binding.yaml', 'config/crd/patches/webhook_in_airflowbases.yaml', 'config/webhook/service.yaml'] 
Some sources ['templates/flower-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/airflowcluster_editor_role.yaml'] 
Some sources ['templates/secret.yaml', 'hack/sample/mysql-celery-gcs/cluster.yaml', 'templates/scheduler-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/webhook/kustomizeconfig.yaml', 'config/default/kustomization.yaml', 'config/certmanager/kustomizeconfig.yaml'] 
Some sources ['hack/sample/postgres-celery/base.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/crd/kustomization.yaml', 'config/prometheus/monitor.yaml', 'config/default/manager_webhook_patch.yaml', 'config/crd/patches/webhook_in_airflowclusters.yaml'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/samples/airflow_v1alpha1_airflowcluster.yaml', 'config/rbac/auth_proxy_role.yaml'] 
Some sources ['hack/appcrd.yaml', 'templates/airflow-configmap.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/rbac/auth_proxy_role_binding.yaml', 'config/crd/patches/cainjection_in_airflowclusters.yaml'] 
Some sources ['templates/ui-sts.yaml', 'hack/sample/postgres-local/cluster.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/manager/kustomization.yaml', 'config/manager/manager.yaml'] 
Some sources ['hack/sample/cloudsql-local/cluster.yaml', 'hack/sample/cloudsql-celery/sqlproxy-secret.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/prometheus/kustomization.yaml'] 
Some sources ['templates/rolebinding.yaml', 'templates/redis-sts.yaml', 'templates/nfs-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['config/certmanager/kustomization.yaml'] 
Some sources ['templates/sqlproxy-sts.yaml'] contain TODO about inconsistent licenses
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit

Add license for all md files.............................................Failed
- hook id: insert-license
- exit code: 1
- files were modified by this hook

Some sources were modified by the hook ['docs/development.md', '.github/ISSUE_TEMPLATE/redeliver_container_image.md', '.github/ISSUE_TEMPLATE/patch-release.md', 'docs/quickstart.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['.github/PULL_REQUEST_TEMPLATE.md', '.github/ISSUE_TEMPLATE/feature_request.md', '.github/ISSUE_TEMPLATE/minor-release.md', 'README.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['docs/design.md', 'docs/api.md', '.github/ISSUE_TEMPLATE/major-release.md', '.github/ISSUE_TEMPLATE/bug_report.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit


Some sources were modified by the hook ['docs/userguide.md'] 
Now aborting the commit.
You should check the changes made. Then simply "git add --update ." and re-commit

Add license for all go files.............................................Passed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants