This repository was archived by the owner on Sep 10, 2022. It is now read-only.
OAuth Multiuserfix#13
Open
wseaton wants to merge 5 commits intoopendatahub-io-contrib:openshiftfrom
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to fix multiple user sign up using OAuth when using the LDAP backend.
One of the issues with multi-user support is that the
emailfield is not returned by the OCP users endpoint so it was previously unset by default, this makes it so more than 1 user cannot enroll. My solution for the LDAP backend is to parse theidentityfield and use the user's LDAP dn which is base64 decoded to reconstruct the user's email (or at least what LOOKS like it could be their email, it's not guaranteed to be accurate and is subject to LDAP implementation).