UPSTREAM: <carry>: fix(frontend): prevent long parameter labels from wrapping to multiple lines - #403
UPSTREAM: <carry>: fix(frontend): prevent long parameter labels from wrapping to multiple lines#403jira-autofix[bot] wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughUpdated Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
Comment |
Commit Checker results: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
frontend/src/components/NewRunParametersV2.tsx (1)
68-74: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winVerify this override is necessary; MUI already provides these styles.
@mui/material@5.18.0already applieswhite-space: nowrap,overflow: hidden,text-overflow: ellipsis, andmax-widthtoInputLabelRoot. If a local override causes the wrapping, target that override or document the required specificity; otherwise this duplicates framework CSS. (raw.githubusercontent.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/src/components/NewRunParametersV2.tsx` around lines 68 - 74, Verify the nested .MuiInputLabel-root override in the component’s styling configuration is necessary; remove it if MUI’s InputLabelRoot styles already provide the required nowrap, overflow, and ellipsis behavior, or adjust/document the override only if a local rule is causing wrapping and requires additional specificity.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/NewRunParametersV2.test.tsx`:
- Around line 1321-1337: Update the “Long parameter label wrapping
(`#RHOAIENG-56381`)” test to query the rendered label element directly rather than
relying on getByLabelText, then assert its whiteSpace, overflow, and
textOverflow styles to verify truncation; use a browser test only if pixel-level
clipping must be validated.
---
Nitpick comments:
In `@frontend/src/components/NewRunParametersV2.tsx`:
- Around line 68-74: Verify the nested .MuiInputLabel-root override in the
component’s styling configuration is necessary; remove it if MUI’s
InputLabelRoot styles already provide the required nowrap, overflow, and
ellipsis behavior, or adjust/document the override only if a local rule is
causing wrapping and requires additional specificity.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2a85429c-adc1-4759-b767-12913e02696a
📒 Files selected for processing (2)
frontend/src/components/NewRunParametersV2.test.tsxfrontend/src/components/NewRunParametersV2.tsx
|
A set of new images have been built to help with testing out this PR: |
|
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1
kind: DataSciencePipelinesApplication
metadata:
name: pr-403
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-403"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-403"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-403"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-403"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-403"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/mlmd-grpc-server:latest"
envoy:
image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-403"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'Then run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/403/head
git checkout -b pullrequest 3bd9e0ee7bd8ae0bd620c1d1e32599c754a17b6a
oc apply -f dspa.pr-403.yamlMore instructions here on how to deploy and test a Data Science Pipelines Application. |
Commit Checker results: |
|
Change to PR detected. A new PR build was completed. |
…wrapping to multiple lines Long parameter labels in NewRunParametersV2 input fields were wrapping to multiple lines, making the form difficult to read. Added CSS rules (whiteSpace: nowrap, overflow: hidden, textOverflow: ellipsis) to the MuiInputLabel-root class within the textfield style to ensure labels are truncated with an ellipsis instead of wrapping. Includes a regression test that verifies the label element has the MuiInputLabel-root class for truncation styling. Jira: RHOAIENG-56381 Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: aipcc-bot <aipcc-bot@redhat.com>
624f72c to
6a4f787
Compare
jira-autofix
Bot
changed the title
Commit Checker results: |
|
Change to PR detected. A new PR build was completed. |
1 participant
Prevents long parameter labels in the NewRunParametersV2 component from wrapping to multiple lines. CSS rules (whiteSpace: nowrap, overflow: hidden, textOverflow: ellipsis) are applied to MuiInputLabel-root within the textfield style, so labels are truncated with an ellipsis instead of wrapping.
Includes a regression test verifying the label element has the MuiInputLabel-root class for truncation styling.
Jira: RHOAIENG-56381
This iteration fixed the commit message format from conventional commit style to the UPSTREAM: carry: convention required by the repo's commit checker.
Summary by CodeRabbit
Bug Fixes
Tests