UPSTREAM: <carry>: fix(frontend): add Retry button to AllRunsList toolbar by jira-autofix[bot] · Pull Request #405 · opendatahub-io/data-science-pipelines

jira-autofix · 2026-07-11T03:42:38Z

Summary

Added the missing Retry button to the AllRunsList toolbar, matching the action already available in RunDetails
Wired the retry button's disabled state to the current run selection (enabled when at least one run is selected)
Added tests verifying the retry button enables/disables correctly based on selection state

Checklist:

You have signed off your commits
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
Make sure the changes work with DSPO. Run the tests in DSPO with DSPA images pointing to this PR's images

Summary by CodeRabbit

New Features
- Added a Retry action to the runs toolbar.
- The Retry button is enabled when one or more runs are selected and disabled when no runs are selected.
Tests
- Added coverage verifying Retry button behavior for single and multiple selections, including clearing selections.

openshift-ci · 2026-07-11T03:42:44Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmfrasca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-07-11T03:42:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1f66a5d1-30d5-40f8-b025-4dfa73d6dea4

📥 Commits

Reviewing files that changed from the base of the PR and between 3a918e8 and c483528.

📒 Files selected for processing (2)

frontend/src/pages/AllRunsList.test.tsx
frontend/src/pages/AllRunsList.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

frontend/src/pages/AllRunsList.test.tsx
frontend/src/pages/AllRunsList.tsx

📝 Walkthrough

Walkthrough

AllRunsList now wires the retry toolbar action to the current run selection and updates its disabled state when selection changes. Tests cover enabling retry when a run is selected and disabling it when the selection is cleared.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is specific and matches the Retry button toolbar change, despite extra upstream prefix noise.
Description check	✅ Passed	The description covers the change summary and checklist items, with only a heading mismatch from the template.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Contribution Quality And Spam Detection	✅ Passed	Small, context-specific UI change with tests; no security-theater or code-quality red flags, and no second independent spam signal.
No Hardcoded Secrets	✅ Passed	No hardcoded secrets, embedded credentials, or long base64 literals were added in the changed files; only selection logic/tests changed (CWE-798/CWE-259).
No Weak Cryptography	✅ Passed	No CWE-327/CWE-208 issues: changed files only add toolbar selection logic/tests, with no banned primitives or secret comparisons.
No Injection Vectors	✅ Passed	No CWE-89/78/94/502/79 sink added; touched code only wires selectedIds to Buttons.retryRun and API calls, with no eval, shell, YAML, or HTML injection.
No Privileged Containers	✅ Passed	Diff only changes frontend TSX files; no manifests/Helm/Dockerfiles or privilege flags (privileged, hostPID, runAsUser:0) were introduced. CWE-250 not present.
No Sensitive Data In Logs	✅ Passed	No new logging in touched files; no CWE-532/200 log exposure found in AllRunsList.tsx or its tests.

_{Comment @coderabbitai help to get the list of available commands.}

dsp-developers · 2026-07-11T03:43:22Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 3a1866e3c7ce2d853e93d082255c511433773105...3a918e88aff848e9d8260c3bf80082ce636b5d73

UPSTREAM commit 3a918e8 has invalid summary fix(frontend): add Retry button to AllRunsList toolbar.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2026-07-11T03:47:49Z

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-405
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-405
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-405
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-405
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-405
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-405
TESTS: quay.io/opendatahub/ds-pipelines-tests:pr-405

dsp-developers · 2026-07-11T03:47:50Z

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-405.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-405
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-405"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-405"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-405"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-405"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-405"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-405"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/405/head
git checkout -b pullrequest 3a918e88aff848e9d8260c3bf80082ce636b5d73
oc apply -f dspa.pr-405.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

…lbar RHOAIENG-56384: The AllRunsList toolbar was missing the Retry action that RunDetails includes. Added retryRun to the toolbar builder and wired the disabled state to the current selection, matching the existing pattern for the archive button. Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com>

dsp-developers · 2026-07-11T06:26:13Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 3a1866e3c7ce2d853e93d082255c511433773105...c483528c59daca3609087cfabae39fe22f95bc14

dsp-developers · 2026-07-11T06:30:38Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-405
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-405
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-405
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-405
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-405
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-405
TESTS: quay.io/opendatahub/ds-pipelines-tests:pr-405

openshift-ci Bot requested review from VaniHaripriya and hbelmiro July 11, 2026 03:42

jira-autofix Bot changed the title ~~fix(frontend): add Retry button to AllRunsList toolbar~~ UPSTREAM: <carry>: fix(frontend): add Retry button to AllRunsList toolbar Jul 11, 2026

jira-autofix Bot force-pushed the autofix/rhoaieng-56384 branch from 3a918e8 to c483528 Compare July 11, 2026 06:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UPSTREAM: <carry>: fix(frontend): add Retry button to AllRunsList toolbar - #405

UPSTREAM: <carry>: fix(frontend): add Retry button to AllRunsList toolbar#405
jira-autofix[bot] wants to merge 1 commit into
masterfrom
autofix/rhoaieng-56384

jira-autofix Bot commented Jul 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci Bot commented Jul 11, 2026

Uh oh!

coderabbitai Bot commented Jul 11, 2026 •

edited

Loading

Walkthrough

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jira-autofix Bot commented Jul 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Jul 11, 2026

Uh oh!

coderabbitai Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

dsp-developers commented Jul 11, 2026

Commit Checker results:

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

dsp-developers commented Jul 11, 2026

Commit Checker results:

Uh oh!

dsp-developers commented Jul 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jira-autofix Bot commented Jul 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 11, 2026 •

edited

Loading