Skip to content

Rebase remaining plugin arch refactor work into midstream - #421

Draft
alyssacgoins wants to merge 15 commits into
opendatahub-io:masterfrom
alyssacgoins:rebase-final-plugin-arch-refactor
Draft

Rebase remaining plugin arch refactor work into midstream#421
alyssacgoins wants to merge 15 commits into
opendatahub-io:masterfrom
alyssacgoins:rebase-final-plugin-arch-refactor

Conversation

@alyssacgoins

Copy link
Copy Markdown

Description of your changes:
An earlier version of kubeflow#13471 was merged into this repo last month. This PR brings in the remaining work.

Checklist:

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9f2d4ba5-c604-4039-92b2-f5abc6b87b42

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@alyssacgoins
alyssacgoins force-pushed the rebase-final-plugin-arch-refactor branch 2 times, most recently from aa900cc to dbcfe56 Compare July 27, 2026 14:06
@alyssacgoins
alyssacgoins force-pushed the rebase-final-plugin-arch-refactor branch from dbcfe56 to 974b915 Compare July 27, 2026 14:06
@dsp-developers

Copy link
Copy Markdown

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
ERROR: couldn't find commits from 974b91593c70157762d5e4e69fbf39a16d1e1360..dbcfe5607a03c70f2ddc1c68c7b41cedcb33d29e: error executing git log: fatal: Invalid revision range 974b91593c70157762d5e4e69fbf39a16d1e1360..dbcfe5607a03c70f2ddc1c68c7b41cedcb33d29e
: exit status 128

@alyssacgoins alyssacgoins reopened this Jul 27, 2026
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers

Copy link
Copy Markdown

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 1 commits between 974b91593c70157762d5e4e69fbf39a16d1e1360...a3e3586d8260d6899642bead06058c8a85d069d4

UPSTREAM commit a3e3586 has invalid summary Rebase final plugin arch.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert


@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alyssacgoins
alyssacgoins force-pushed the rebase-final-plugin-arch-refactor branch from a3e3586 to ce02db7 Compare July 27, 2026 16:04
@dsp-developers

Copy link
Copy Markdown

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 1 commits between 974b91593c70157762d5e4e69fbf39a16d1e1360...ce02db7de1ad1da14f66b9373375d02de18409bf

UPSTREAM commit ce02db7 has invalid summary (backend): Refactor MLflow plugin API server impl to support general plugin architecture (#13471).

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert


@dsp-developers

Copy link
Copy Markdown

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 2 commits between 974b91593c70157762d5e4e69fbf39a16d1e1360...ba42078a12a139e91e383221ea43e5c4125bc08c

UPSTREAM commit ba42078 has invalid summary Fix rebase errors..

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit ce02db7 has invalid summary (backend): Refactor MLflow plugin API server impl to support general plugin architecture (#13471).

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert


VaniHaripriya and others added 14 commits July 27, 2026 13:37
… API server

Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
When managed pipelines are imported via --managedPipelinesDir, their
version names defaulted to the pipeline name (e.g.
"autogluon-tabular-training-pipeline") instead of the platform version.

The MANAGED_PIPELINES_UPLOAD_TAGS env var already carries
rhoai-version=<version>. Extract that value after tag parsing and set it
as VersionName on managed pipeline entries only, leaving explicit
sample_config.json entries untouched.

Closes: RHOAIENG-69371

Signed-off-by: Helber Belmiro <hbelmiro@redhat.com>
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Now that managed pipelines share the same version name, the old
pvName key caused a 1-second sleep between each managed pipeline
during startup. Key by pipeline UUID so the sleep only triggers
for multiple versions under the same pipeline.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Return an error if the rhoai-version tag value exceeds the 127-character
PipelineVersion.Name column limit, rather than letting sample loading
fail downstream or create versions inconsistent with API validation.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…lds.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>

� Conflicts:
�	backend/Dockerfile
�	backend/Dockerfile.driver
�	backend/Dockerfile.launcher
�	backend/Dockerfile.persistenceagent
�	backend/Dockerfile.scheduledworkflow
…CLI installation

Standardized the architecture argument to use `BUILDARCH` across the Dockerfile for consistency and improved multi-platform build compatibility.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…g `BUILDARCH`

Added the `BUILDARCH` argument to Dockerfiles and the Makefile to define the build host architecture. Enforced checks ensuring `BUILDARCH` matches `TARGETARCH` for FIPS-enabled builds, improving build reliability and consistency.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Added an automated workflow to build arm64 images for various components, including concurrency control and architecture validation.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…build dependencies for multi-architecture support

Removed unnecessary `chmod` commands from multiple Dockerfiles and introduced runtime dependency layering with multi-architecture support. Improved consistency by leveraging shared runtime layers for CA certificates and wget.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…rm64 build timeout

- Improved Dockerfile to use Zig for verified cross-compilation, adding architecture-specific SHA256 validation.
- Adjusted GitHub Actions arm64 workflow timeout to ensure reliable build completion.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
- HumairAK and mprahl: approver-only (no longer reviewers)
- gmfrasca: moved to emeritus_approvers
- alyssacgoins: added as approver + reviewer
- sduvvuri1603: added as reviewer
- Removed subdirectory OWNERS files (backend, test, tools, test_data,
  .github) as they only restricted permissions already granted by root

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…for multi-arch builds

- Replaced references to `BUILDER_ARCH` with `TARGETARCH` for improved clarity and compatibility.
- Adjusted base images to target architecture-specific layers (`amd64` and `arm64`) to enhance multi-architecture build consistency.

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…flow

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…plugin architecture (kubeflow#13471)

* feat(backend): Add pipeline run lifecycle hooks

Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>

* feat(backend) integrate MLflow lifecycle hooks across the driver and launcher (kubeflow#13052)

Signed-off-by: Alyssa Goins <80764587+alyssacgoins@users.noreply.github.com>

* chore(backend): Fix MLflow tags,nested run status update (kubeflow#13307)

Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>

* fix(backend): Address CI failures after rebase

Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>

* feat(backend): Add pipeline run lifecycle hooks

Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>

* feat(backend): Add pipeline run lifecycle hooks

Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>

* Refactor MLflow plugin API server impl for general plugin arch.

Signed-off-by: Alyssa Goins <agoins@redhat.com>

---------

Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
Signed-off-by: Alyssa Goins <80764587+alyssacgoins@users.noreply.github.com>
Signed-off-by: Alyssa Goins <agoins@redhat.com>
Co-authored-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
@alyssacgoins
alyssacgoins force-pushed the rebase-final-plugin-arch-refactor branch from ba42078 to 48cb068 Compare July 27, 2026 17:37
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants