Rebase remaining plugin arch refactor work into midstream - #421
Rebase remaining plugin arch refactor work into midstream#421alyssacgoins wants to merge 15 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
aa900cc to
dbcfe56
Compare
dbcfe56 to
974b915
Compare
Commit Checker results: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Commit Checker results: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
a3e3586 to
ce02db7
Compare
Commit Checker results: |
Commit Checker results: |
… API server Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
When managed pipelines are imported via --managedPipelinesDir, their version names defaulted to the pipeline name (e.g. "autogluon-tabular-training-pipeline") instead of the platform version. The MANAGED_PIPELINES_UPLOAD_TAGS env var already carries rhoai-version=<version>. Extract that value after tag parsing and set it as VersionName on managed pipeline entries only, leaving explicit sample_config.json entries untouched. Closes: RHOAIENG-69371 Signed-off-by: Helber Belmiro <hbelmiro@redhat.com> Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Now that managed pipelines share the same version name, the old pvName key caused a 1-second sleep between each managed pipeline during startup. Key by pipeline UUID so the sleep only triggers for multiple versions under the same pipeline. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Return an error if the rhoai-version tag value exceeds the 127-character PipelineVersion.Name column limit, rather than letting sample loading fail downstream or create versions inconsistent with API validation. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…lds. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com> � Conflicts: � backend/Dockerfile � backend/Dockerfile.driver � backend/Dockerfile.launcher � backend/Dockerfile.persistenceagent � backend/Dockerfile.scheduledworkflow
…CLI installation Standardized the architecture argument to use `BUILDARCH` across the Dockerfile for consistency and improved multi-platform build compatibility. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…g `BUILDARCH` Added the `BUILDARCH` argument to Dockerfiles and the Makefile to define the build host architecture. Enforced checks ensuring `BUILDARCH` matches `TARGETARCH` for FIPS-enabled builds, improving build reliability and consistency. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Added an automated workflow to build arm64 images for various components, including concurrency control and architecture validation. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…build dependencies for multi-architecture support Removed unnecessary `chmod` commands from multiple Dockerfiles and introduced runtime dependency layering with multi-architecture support. Improved consistency by leveraging shared runtime layers for CA certificates and wget. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…rm64 build timeout - Improved Dockerfile to use Zig for verified cross-compilation, adding architecture-specific SHA256 validation. - Adjusted GitHub Actions arm64 workflow timeout to ensure reliable build completion. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
- HumairAK and mprahl: approver-only (no longer reviewers) - gmfrasca: moved to emeritus_approvers - alyssacgoins: added as approver + reviewer - sduvvuri1603: added as reviewer - Removed subdirectory OWNERS files (backend, test, tools, test_data, .github) as they only restricted permissions already granted by root Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…for multi-arch builds - Replaced references to `BUILDER_ARCH` with `TARGETARCH` for improved clarity and compatibility. - Adjusted base images to target architecture-specific layers (`amd64` and `arm64`) to enhance multi-architecture build consistency. Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…flow Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
…plugin architecture (kubeflow#13471) * feat(backend): Add pipeline run lifecycle hooks Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * feat(backend) integrate MLflow lifecycle hooks across the driver and launcher (kubeflow#13052) Signed-off-by: Alyssa Goins <80764587+alyssacgoins@users.noreply.github.com> * chore(backend): Fix MLflow tags,nested run status update (kubeflow#13307) Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * fix(backend): Address CI failures after rebase Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * feat(backend): Add pipeline run lifecycle hooks Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * feat(backend): Add pipeline run lifecycle hooks Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> * Refactor MLflow plugin API server impl for general plugin arch. Signed-off-by: Alyssa Goins <agoins@redhat.com> --------- Signed-off-by: Vani Haripriya Mudadla <vmudadla@redhat.com> Signed-off-by: Alyssa Goins <80764587+alyssacgoins@users.noreply.github.com> Signed-off-by: Alyssa Goins <agoins@redhat.com> Co-authored-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
ba42078 to
48cb068
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description of your changes:
An earlier version of kubeflow#13471 was merged into this repo last month. This PR brings in the remaining work.
Checklist: