Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAP tests for PyTorchJobs #319

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Feb 19, 2025

Jira: https://issues.redhat.com/browse/RHOAIENG-19694
ValidatingAdmissionPolicy PR: opendatahub-io/kueue#76

Note: this PR is on hold until the RFE is approved.

Description

  • Added VAP tests for PyTorchJobs.
  • Added new AppWrapper test cases.
  • Refactored the tests for readability and scalability.

How Can This Been Tested?

This should be tested alongside this PR: opendatahub-io/kueue#76

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szaher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant