Skip to content

[WIP] add sdk specific structure and custom sdk install#686

Open
briangallagher wants to merge 1 commit intoopendatahub-io:mainfrom
briangallagher:sdk-test-updates
Open

[WIP] add sdk specific structure and custom sdk install#686
briangallagher wants to merge 1 commit intoopendatahub-io:mainfrom
briangallagher:sdk-test-updates

Conversation

@briangallagher
Copy link
Copy Markdown
Contributor

Changes made to the trainer folder

  • Unified SDK install wiring for trainer SDK tests so notebook runs consistently honor KUBEFLOW_GIT_URL, KUBEFLOW_REQUIRED_VERSION, and KUBEFLOW_SDK_INDEX_URL via shared export logic.
  • Updated trainer SDK test setup to support token-first auth (NOTEBOOK_USER_TOKEN) with username/password fallback, including username derivation from token for RBAC binding.
  • Standardized notebook execution flow to run install_kubeflow.py from ConfigMap before papermill, removing per-notebook hardcoded Kubeflow SDK git install commands.
  • Kept trainer behavior backward-compatible by retaining legacy KUBEFLOW_GIT_URL usage in trainer-side installer paths while enabling centralized control from the wrapper.

Addition of kubeflow_sdk folder

  • Introduced a new top-level SDK test entrypoint (tests/kubeflow_sdk) to separate SDK-focused orchestration from component-level trainer test implementations.
  • Added a thin, scalable Makefile structure: top-level cross-component targets in tests/kubeflow_sdk/Makefile and trainer-specific orchestration in tests/kubeflow_sdk/trainer/Makefile.
  • Added shared wrapper script (tests/kubeflow_sdk/scripts/install_kubeflow.sh) to centralize auth resolution, SDK source selection, and notebook image defaults across SDK runs.
  • Added documentation (tests/kubeflow_sdk/README.md, tests/kubeflow_sdk/trainer/README.md) with standardized run targets and env contract, enabling future components (e.g. core/spark) to onboard with the same pattern.
  • Designed for growth: new component folders can plug into the same top-level SDK orchestration model without changing existing trainer entrypoints.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szaher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from kapil27 and pawelpaszki March 13, 2026 16:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 13, 2026

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • WIP
  • DO NOT MERGE

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f43dbb11-670b-4bba-87a3-c3b89b6e9fd4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@briangallagher
Copy link
Copy Markdown
Contributor Author

@sutaakar WIP, but if you want to give quick initial scan to see if any obvious issues/concerns

@briangallagher briangallagher force-pushed the sdk-test-updates branch 3 times, most recently from c545f90 to dd9cdc1 Compare March 13, 2026 22:13
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 18, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…all sdk relates tests

Signed-off-by: Brian Gallagher <briangal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant