Skip to content

Enhance failure scenario notebooks and tests by adding environment va…#693

Draft
kapil27 wants to merge 1 commit intoopendatahub-io:mainfrom
kapil27:trainer-test-fixes
Draft

Enhance failure scenario notebooks and tests by adding environment va…#693
kapil27 wants to merge 1 commit intoopendatahub-io:mainfrom
kapil27:trainer-test-fixes

Conversation

@kapil27
Copy link
Copy Markdown
Contributor

@kapil27 kapil27 commented Mar 19, 2026

…riable checks, improving logging, and integrating a Kubeflow installation script. Update training runtime resolution and ensure proper handling of disconnected environments.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…riable checks, improving logging, and integrating a Kubeflow installation script. Update training runtime resolution and ensure proper handling of disconnected environments.
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign laurafitzgerald for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d74cc517-6b4c-491d-8d47-2e25e1e6554a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use your project's `golangci-lint` configuration to improve the quality of Go code reviews.

Add a configuration file to your project to customize how CodeRabbit runs golangci-lint.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 4, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant