Skip to content

feat: add Ray GRPO runtime image (CUDA 12.8, Python 3.12)#795

Draft
Fiona-Waters wants to merge 3 commits intoopendatahub-io:mainfrom
Fiona-Waters:feat/ray-grpo-cu128-runtime
Draft

feat: add Ray GRPO runtime image (CUDA 12.8, Python 3.12)#795
Fiona-Waters wants to merge 3 commits intoopendatahub-io:mainfrom
Fiona-Waters:feat/ray-grpo-cu128-runtime

Conversation

@Fiona-Waters
Copy link
Copy Markdown
Contributor

@Fiona-Waters Fiona-Waters commented Apr 23, 2026

Summary

Adds a new Ray runtime image for LoRA-GRPO training on KubeRay, extending quay.io/modh/ray:2.53.0-py312-cu128 with the ML stack required by training-hub's GRPO backend.

The image layers vLLM 0.12.0, verl 0.7.1, flash-attn 2.8.3, PyTorch 2.9.0, and training-hub on top of the existing base Ray CUDA 12.8 image, following the same directory layout as the existing runtime images.

Key packages

Package Version Role
vLLM 0.12.0 LLM rollout engine
PyTorch 2.9.0 Deep learning framework
verl 0.7.1 GRPO training orchestrator (FSDP + vLLM)
flash-attn 2.8.3 Memory-efficient attention (pre-built wheel, cxx11abiTRUE)
training-hub latest High-level GRPO training API
peft ≥0.15 LoRA adapters
transformers ≥4.57.6 HuggingFace model loading

Notes

  • Git branch installs (temporary): instructlab-training and rhai-innovation-mini-trainer are installed from their main branches to pick up the relaxed numba>=0.61.2 constraint (merged but not yet released to PyPI). training-hub[grpo] is installed from the lora-grpo branch (GRPO code not yet merged to main). Once all packages are released, Step 4 simplifies to pip install "training-hub[grpo]".

Changes

  • New directory images/runtime/ray/cuda/2.53.0-py312-cu128-grpo/ with Dockerfile and README

Test Plan

  • Image built and pushed as quay.io/rh_ee_fwaters/ray-grpo:2.53.0-py312-cu128-v6
  • Smoke test passes (ray, vllm, torch, verl, training_hub, lora_grpo, VeRLLoRAGRPOBackend imports verified)
  • Successful end-to-end GRPO training run on KubeRay cluster

Adds a derivative runtime image extending quay.io/modh/ray:2.53.0-py312-cu128
with vLLM 0.12.0, verl 0.7.1, flash-attn 2.8.3, and training-hub for
LoRA-GRPO training on KubeRay clusters.

Signed-off-by: Fiona-Waters <fiwaters6@gmail.com>
Made-with: Cursor
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fiona-waters for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 45ae157c-fc44-451d-b352-5d957b35422a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Remove --no-deps workaround, manual dependency list, and patch_init.py
now that instructlab-training, mini_trainer, and training_hub have all
relaxed their numba constraint to >=0.61.2, resolving the conflict with
vllm's numba==0.61.2. Install training-hub[grpo] from the lora-grpo
branch with proper dependency resolution.

Made-with: Cursor
Align with existing Ray runtime image conventions in the repo.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant