feat: add DspClient scaffold and pipeline e2e test structure#930
feat: add DspClient scaffold and pipeline e2e test structure#930Slowlybomb wants to merge 4 commits into
Conversation
Signed-off-by: Fiona-Waters <fiwaters6@gmail.com>
- Introduced TestGrpoTrainingHubMultiNodeMultiGPU to validate GRPO training with multiple nodes and GPUs. - Updated grpo.ipynb to clarify SDK installation and added checkpoint verification and metrics logging checks for improved robustness. Tested Signed-off-by: Slowlybomb <hslyusar@redhat.com>
RHOAIENG-43403: Spike to investigate e2e testing for reusable KFP pipelines. - Fix DSP env var typo (dspRoutURL -> dspRouteURL) in environment.go - Implement DspClient HTTP wrapper for KFP v2beta1 REST API (upload pipeline, create run, poll status, get details, delete) - Add unit tests for DspClient using httptest mock servers - Scaffold tests/pipelines/ package with SFT test skeleton Signed-off-by: Slowlybomb <hslyusar@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
dspRoutURL->dspRouteURL) intests/common/environment.goDspClientHTTP wrapper for KFP v2beta1 REST API intests/common/support/dsp_client.goDspClientusinghttptestmock serverstests/pipelines/package with SFT test skeletonRef: RHOAIENG-43403
Note
The SFT test skeleton references
resources/sft_pipeline.yamlwhich does not exist yet — compiled pipeline YAMLs from the pipelines repo are needed before the e2e tests can run.Test plan
go test ./tests/common/support/... -run TestDsp— 11 unit tests passgo build ./tests/pipelines/...— builds cleango vet— no issuesgolangci-lint— 0 issuesverify-imports— passMade with Cursor