Bump peft 0.17.0 to 0.18.1 in torch280 training images#931
Conversation
peft 0.17.0 is incompatible with transformers 5.x — it tries to import HybridCache which was removed. This breaks all KFTO LLM training tests using the torch280 CUDA and ROCm images. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kapil27, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sutaakar: The following test has Failed: OCI Artifact Browser URLInspecting Test Artifacts ManuallyTo inspect your test artifacts manually, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:odh-pr-test-distributed-workloads-4xs49 |
Summary
peftfrom0.17.0to0.18.1inpy312-cuda128-torch280andpy312-rocm64-torch280training imagesImportError: cannot import name 'HybridCache' from 'transformers'— peft 0.17.0 is incompatible with transformers 5.x shipped in these imagesRoot cause
peft==0.17.0importsHybridCachefromtransformers, which was removed in transformers 5.x. The torch280 images shiptransformers ~=5.5.0, causing an immediate crash onfrom peft import LoraConfig.peft==0.18.1adds transformers 5.x compatibility — its runtime dependencies are otherwise identical to 0.17.0.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
peftdependency to a newer version in the training runtime environments for both CUDA and ROCm images.