Skip to content

Raise timeout for enabling/disabling component to 10 minutes#938

Merged
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:mainfrom
sutaakar:timeout
Jun 30, 2026
Merged

Raise timeout for enabling/disabling component to 10 minutes#938
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:mainfrom
sutaakar:timeout

Conversation

@sutaakar

@sutaakar sutaakar commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Tests
    • Increased the timeout used in cluster setup and teardown checks, allowing more time for state transitions to complete before failing.
    • This should reduce flaky timeouts during environment preparation and cleanup.

@openshift-ci openshift-ci Bot requested review from pawelpaszki and szaher June 30, 2026 18:29
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e184ee47-53cc-44d0-abb0-82da122da5ac

📥 Commits

Reviewing files that changed from the base of the PR and between 2626e9b and 501e18f.

📒 Files selected for processing (1)
  • tests/common/support/dataScienceCluster.go

📝 Walkthrough

Walkthrough

In tests/common/support/dataScienceCluster.go, the timeout argument passed to SetComponentStateAndWait is changed from 2*time.Minute to 10*time.Minute in both SetupComponent and TearDownComponent. No other logic, signatures, or exported entities are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: increasing the component enable/disable wait timeout to 10 minutes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Contribution Quality And Spam Detection ✅ Passed Single-file test-support timeout increase only; no security-theater or code-quality red flags beyond a blank template body.
No Hardcoded Secrets ✅ Passed No hardcoded credentials or secret literals in the added file; only 10*time.Minute timeout changes were introduced (CWE-798/CWE-259 not present).
No Weak Cryptography ✅ Passed No CWE-327/CWE-328/CWE-916 issues: the only edits are 2 timeout values in SetupComponent/TearDownComponent; no crypto primitives, roll-your-own crypto, or secret compares.
No Injection Vectors ✅ Passed Diff only raises hardcoded test-helper timeouts (2m→10m); no CWE-78/89/94/79/502 patterns found.
No Privileged Containers ✅ Passed Only a Go test helper timeout changed; no Kubernetes/OpenShift manifests, Helm, or Dockerfiles touched, so no privileged-container issue (CWE-732/CWE-269).
No Sensitive Data In Logs ✅ Passed No CWE-532 issue: the PR only raises timeouts in SetupComponent/TearDownComponent; no new logs or sensitive fields were added.

Comment @coderabbitai help to get the list of available commands.

@abhijeet-dhumal abhijeet-dhumal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Karel 🙌

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit f5c3de9 into opendatahub-io:main Jun 30, 2026
10 checks passed
@sutaakar sutaakar deleted the timeout branch June 30, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants