[RHOAIENG-47402] fix: remove insecure TLS default in IAP sample#1131
[RHOAIENG-47402] fix: remove insecure TLS default in IAP sample#1131jlost wants to merge 1 commit intoopendatahub-io:release-v0.15from
Conversation
Signed-off-by: James Ostrander <jostrand@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlost The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/group-test |
|
/group-test |
What this PR does / why we need it:
Cherry-pick of kserve#5131
The GCP IAP sample hardcoded
verify=Falseon all requests, disabling TLS certificate verification (CWE-295). This is the only sample in the repository that did so, and since it's the only sample making requests over the public internet (via IAP), it's also the one where TLS verification matters most.This PR defaults to secure TLS verification (
verify=True) and adds two opt-in flags:--ca-certfor self-signed or internal CA certificates--insecureto explicitly disable verification (with a warning)Feature/Issue validation/testing:
verify=Falsekserve_storage.py,inference_client.py) already follows this patternChecklist:
Release note: