update: llm-d version for ODH 3.5ea1#1451
update: llm-d version for ODH 3.5ea1#1451zdtsw wants to merge 2 commits intoopendatahub-io:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated three release version entries in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
|
@zdtsw: The following test has Failed: OCI Artifact Browser URLInspecting Test Artifacts ManuallyTo inspect your test artifacts manually, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:kserve-group-test-txl7f |
|
WVA I started a discussion with their team so waiting to hear on that. We could chose to merge this now and bump again later if we want. As for Kserve, I see an RC out for v0.18.0-rc1, are we not going to take v0.18.0 (see: https://github.com/kserve/kserve/releases/tag/v0.18.0-rc1)? |
|
Confirmed WVA will be releasing v0.7.0 and they will start to cut after their guide is kustomized |
| @@ -3,10 +3,10 @@ releases: | |||
| version: v0.17.0 | |||
There was a problem hiding this comment.
Will this be v0.18.0? They have an RC pre-release out now
There was a problem hiding this comment.
Kserve normally dont switch version that often. That request their master branch to rebase upstream release-*** first which is a big effort. E.g we switched ut from 0.15 to 0.17 last month.
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
@zdtsw: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
task for odh/rhoai release
ref https://redhat.atlassian.net/browse/INFERENG-6472
Feature/Issue validation/testing:
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Summary by CodeRabbit