Sync release from master#1453
Open
pierDipi wants to merge 43 commits intorelease-v0.17from
Open
Conversation
…mplate (kserve#5302) Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
…be (kserve#5345) Signed-off-by: Rey Shazni <reyshazni@gmail.com>
…kserve#5381) Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
…serve#5398) Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…ve#5393) Signed-off-by: Horvath Agoston <agoston@cloudera.com>
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
…5403) Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Jooho Lee <jlee@redhat.com> This PR is not about code changes, but rather a new release. It has been tested locally, and further validations will be carried out as part of the 0.18.0 release process. As such, it will be merged manually.
Signed-off-by: Jooho Lee <jlee@redhat.com>
… fixes (kserve#5423) Signed-off-by: Jooho Lee <jlee@redhat.com> This is only for release process and it is still under validation. So no need to review.
…ve#5365) Signed-off-by: Neelabh Sinha <neelabhsinha010@gmail.com>
Signed-off-by: James Ostrander <jostrand@redhat.com>
Signed-off-by: Jooho Lee <jlee@redhat.com>
…kserve#5420) Signed-off-by: James Ostrander <jostrand@redhat.com>
…serve#5413) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Jooho Lee <jlee@redhat.com>
…e#5411) Signed-off-by: David Whyte-Gray <40244437+dagrayvid@users.noreply.github.com>
Signed-off-by: maskarb <mskarbek@redhat.com>
…60423-0828 # Conflicts: # Dockerfile # OWNERS # go.sum # python/aiffairness/uv.lock # python/artexplainer/uv.lock # python/custom_model/uv.lock # python/custom_tokenizer/uv.lock # python/custom_transformer/uv.lock # python/test_resources/graph/error_404_isvc/uv.lock # python/test_resources/graph/success_200_isvc/uv.lock # test/e2e/llmisvc/fixtures.py # test/scripts/gh-actions/run-e2e-tests.sh
Remove users flagged as untrusted by the OWNERS verification bot: Datta0, gavrissh, greenmoon55, sivanantha321, andyi2it, cjohannsen-cloudera, cmaddalozzo, lizzzcai — none are members or collaborators of the opendatahub-io org. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Git auto-merged both upstream and midstream securityContext entries into the same container dict (workload-pd-cpu template), causing a duplicate key lint error (ruff F601). Remove the midstream RUN_AS_NON_ROOT version in favor of the upstream UPSTREAM_K8S_NON_ROOT_SECURITY_CONTEXT constant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Run go mod tidy (removes stale prometheus-operator hash) and make uv-lock (updates requires-python markers) to satisfy the precommit-check CI gate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rve#5429) Signed-off-by: Jooho Lee <jlee@redhat.com>
The upstream merge introduced hardcoded runAsUser values (1000 for vllm-cpu, 65532 for llm-d simulator) in test fixture security contexts. On OpenShift, these UIDs fall outside the namespace's restricted-v2 SCC range and the workload service accounts lack access to the custom openshift-ai-llminferenceservice-scc, causing all pod creations to fail. Make the security context constants conditional on RUN_AS_NON_ROOT: when true (OpenShift CI), omit runAsUser so the SCC assigns UIDs from the namespace range; when false (upstream K8s), keep explicit UIDs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sync upstream 20260423 0828
Signed-off-by: Jooho Lee <jlee@redhat.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
…ve#5407) Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com> enforce gitaction have an issue so I manually merge this
Signed-off-by: James Ostrander <jostrand@redhat.com>
…serve#5449) Signed-off-by: Jooho Lee <jlee@redhat.com>
…serve#5433) Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com>
Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com> # Conflicts: # test/e2e/pytest.ini
…s to avoid pod restart on upgrade (RHOAIENG-59268) (#1435) * fix: skip INFERENCE_SERVICE_NAME injection on pre-existing deployments to avoid pod restart on upgrade (RHOAIENG-59268) When upgrading from RHOAI 3.3.2 to 3.4, the new controller unconditionally injected INFERENCE_SERVICE_NAME into all RawDeployment pod templates, causing a rolling restart of every InferenceService in the cluster simultaneously. The fix checks whether the existing Deployment already has the env var. If it does not (pre-upgrade state), injection is skipped to preserve the pod template hash and avoid the restart. New ISVCs always get the env var on creation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Andres Llausas <allausas@redhat.com> * fix: fail-closed on API errors and guard transformer env var injection (RHOAIENG-59268) - Use apierrors.IsNotFound to distinguish missing deployment from real API errors; return error on non-NotFound failures instead of silently injecting - Apply the same INFERENCE_SERVICE_NAME injection guard to the transformer component to prevent rolling restarts on upgrade Signed-off-by: Andres Llausas <allausas@redhat.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: extract INFERENCE_SERVICE_NAME injection guard to shared helper (RHOAIENG-59268) Move the upgrade-safety check into shouldInjectInferenceServiceName in component.go so predictor and transformer share the same logic without duplication. Signed-off-by: Andres Llausas <allausas@redhat.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: add unit tests for shouldInjectInferenceServiceName (RHOAIENG-59268) Covers: new ISVC (no deployment), pre-upgrade (env var absent → skip), post-upgrade (env var present → inject), and unmatched container name. Signed-off-by: Andres Llausas <allausas@redhat.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: fix copyright year in component_test.go Signed-off-by: Andres Llausas <allausas@redhat.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: gofmt alignment in component_test.go Signed-off-by: Andres Llausas <allausas@redhat.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Signed-off-by: Andres Llausas <allausas@redhat.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Add 'and not autoscaling' to the odh-xks-kind E2E test marker. Autoscaling tests require WVA infrastructure not installed in KinD. - Disable test-quick-install workflow for ODH fork. It tests upstream install paths on Minikube with Docker Hub images, not applicable to ODH which uses OpenShift with Konflux-built images. Signed-off-by: James Ostrander <jostrand@redhat.com> Made-with: Cursor
Member
Author
|
/test e2e-llm-inference-service |
260424 sync upstream/master to odh/master
|
/test branch-ci-opendatahub-io-kserve-master-images |
|
/test all |
|
@pierDipi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title