Skip to content

feat: update Bedrock config to use AWS_BEARER_TOKEN_BEDROCK#134

Merged
mergify[bot] merged 1 commit intoopendatahub-io:mainfrom
skamenan7:feat/RHAIENG-2046-bedrock-bearer-token-rename-5
Dec 10, 2025
Merged

feat: update Bedrock config to use AWS_BEARER_TOKEN_BEDROCK#134
mergify[bot] merged 1 commit intoopendatahub-io:mainfrom
skamenan7:feat/RHAIENG-2046-bedrock-bearer-token-rename-5

Conversation

@skamenan7
Copy link
Copy Markdown
Collaborator

@skamenan7 skamenan7 commented Nov 24, 2025

Summary

Update Bedrock configuration to align with upstream llama-stack PR #4152.

Changes

Replace boto3 credential fields with bearer token configuration.

Related

Summary by CodeRabbit

  • Documentation

    • Clarified Bedrock provider setup and environment requirements in distribution docs.
  • Chores

    • Switched Bedrock authentication to a bearer-token API key sourced from AWS_BEARER_TOKEN_BEDROCK.
    • Removed legacy AWS credential and session fields plus related retry and timeout settings from Bedrock configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 24, 2025

Walkthrough

Bedrock provider configuration switches from AWS credential-based auth to a single bearer-token API key. The enable-condition env var changes from AWS_ACCESS_KEY_ID to AWS_BEARER_TOKEN_BEDROCK; several legacy AWS credential/session fields are removed and region remains configured via AWS_DEFAULT_REGION.

Changes

Cohort / File(s) Summary
Docs update
distribution/README.md
Updated table to change bedrock provider environment variable from AWS_ACCESS_KEY_ID to AWS_BEARER_TOKEN_BEDROCK.
Runtime/provider config
distribution/run.yaml
Switched bedrock provider enable condition to AWS_BEARER_TOKEN_BEDROCK; replaced AWS access/secret/session auth with a single api_key sourced from AWS_BEARER_TOKEN_BEDROCK; removed fields: aws_access_key_id, aws_secret_access_key, aws_session_token, profile_name, total_max_attempts, retry_mode, connect_timeout, read_timeout, session_ttl; retained region_name (from AWS_DEFAULT_REGION, default shown as us-east-2 in diff).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the new api_key usage in run.yaml matches runtime expectations.
  • Confirm removal of AWS credential/session fields doesn't break other provider codepaths or tooling.
  • Ensure the env var name change is propagated to any deployment/CI docs or environment configurations.

Poem

🐰 I hopped through configs, gentle and quick,
Swapped keys for a token — tidy and slick.
One bearer to bind, old secrets unwind,
Quiet bedrock now hums, peaceful and primed. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately and specifically describes the main change: updating Bedrock configuration to use AWS_BEARER_TOKEN_BEDROCK.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f882843 and a2c9db7.

📒 Files selected for processing (2)
  • distribution/README.md (1 hunks)
  • distribution/run.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • distribution/run.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-test-push (linux/amd64)
  • GitHub Check: Summary
🔇 Additional comments (2)
distribution/README.md (2)

1-1: Confirm file regeneration via script.

This file is marked as auto-generated and should not be manually updated. Please verify that the change on line 24 was properly regenerated using scripts/gen_distro_doc.py rather than manually edited.


24-24: Environment variable update aligns with PR objectives.

The change from AWS_ACCESS_KEY_ID to AWS_BEARER_TOKEN_BEDROCK correctly reflects the upstream bedrock configuration change (upstream PR #4152) and aligns with the PR objectives to support bearer token authentication.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skamenan7 skamenan7 changed the title RHAIENG-2046: Update Bedrock config to use AWS_BEARER_TOKEN_BEDROCK feat: update Bedrock config to use AWS_BEARER_TOKEN_BEDROCK Nov 24, 2025
@skamenan7 skamenan7 force-pushed the feat/RHAIENG-2046-bedrock-bearer-token-rename-5 branch from 98b019a to 2c42900 Compare November 24, 2025 21:10
@nathan-weinberg nathan-weinberg force-pushed the feat/RHAIENG-2046-bedrock-bearer-token-rename-5 branch from 1ba81f0 to ec9f55d Compare December 2, 2025 20:30
@skamenan7 skamenan7 force-pushed the feat/RHAIENG-2046-bedrock-bearer-token-rename-5 branch from ec9f55d to f882843 Compare December 8, 2025 13:16
@skamenan7 skamenan7 marked this pull request as ready for review December 10, 2025 15:07
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 10, 2025

This pull request has merge conflicts that must be resolved before it can be merged. @skamenan7 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 10, 2025
@skamenan7
Copy link
Copy Markdown
Collaborator Author

Container Repo's merge request(#90) is merged.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f82fc15 and f882843.

📒 Files selected for processing (2)
  • distribution/README.md (1 hunks)
  • distribution/run.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Summary
🔇 Additional comments (1)
distribution/README.md (1)

24-24: Documentation accurately reflects the configuration change.

The README update correctly identifies AWS_BEARER_TOKEN_BEDROCK as the new environment variable for enabling the bedrock provider.

@skamenan7 skamenan7 force-pushed the feat/RHAIENG-2046-bedrock-bearer-token-rename-5 branch from f882843 to 645cc93 Compare December 10, 2025 15:34
Align with upstream llama-stack PR #4152.

Signed-off-by: skamenan7 <[email protected]>
@skamenan7 skamenan7 force-pushed the feat/RHAIENG-2046-bedrock-bearer-token-rename-5 branch from 645cc93 to a2c9db7 Compare December 10, 2025 15:36
@skamenan7
Copy link
Copy Markdown
Collaborator Author

✅ Rebased onto latest main and resolved merge conflicts.

Regarding the duplicate question from @ktdreyer about #119:

Yes, this PR (#134) supersedes #119. Both PRs update the Bedrock provider configuration, but:

The upstream project renamed the variable from AWS_BEDROCK_API_KEYAWS_BEARER_TOKEN_BEDROCK to align with AWS documentation. This PR follows the latest upstream naming convention, so #119 should be closed in favor of this PR.

@mergify mergify bot merged commit f93d817 into opendatahub-io:main Dec 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants