feat: update Bedrock config to use AWS_BEARER_TOKEN_BEDROCK#134
Conversation
WalkthroughBedrock provider configuration switches from AWS credential-based auth to a single bearer-token API key. The enable-condition env var changes from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
98b019a to
2c42900
Compare
1ba81f0 to
ec9f55d
Compare
ec9f55d to
f882843
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. @skamenan7 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
|
Container Repo's merge request(#90) is merged. |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
distribution/README.md(1 hunks)distribution/run.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (1)
distribution/README.md (1)
24-24: Documentation accurately reflects the configuration change.The README update correctly identifies
AWS_BEARER_TOKEN_BEDROCKas the new environment variable for enabling the bedrock provider.
f882843 to
645cc93
Compare
Align with upstream llama-stack PR #4152. Signed-off-by: skamenan7 <[email protected]>
645cc93 to
a2c9db7
Compare
|
✅ Rebased onto latest main and resolved merge conflicts. Regarding the duplicate question from @ktdreyer about #119: Yes, this PR (#134) supersedes #119. Both PRs update the Bedrock provider configuration, but:
The upstream project renamed the variable from |
Summary
Update Bedrock configuration to align with upstream llama-stack PR #4152.
Changes
Replace boto3 credential fields with bearer token configuration.
Related
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.