feat: Add S3 remote provider for S3 file storage to LLS midst…#137
feat: Add S3 remote provider for S3 file storage to LLS midst…#137
Conversation
…ream image. This MR enables S3-compatible storage backend support for the files API. The boto3 dependency is automatically resolved by the build system. Signed-off-by: Mustafa Elbehery <melbeher@redhat.com> Closes https://issues.redhat.com/browse/RHAIENG-2128
WalkthroughA new S3 remote provider entry is added to the build configuration under Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Why is this a separate PR from #138? |
followed the same way as in downstream, provider first then config |
|
We've never done that in the midstream, why now? |
as I said above, I followed that pattern as in downstream I am confident that this answer your question |
|
Better to have it as one PR since CI will be able to test it properly - will approve for now but please return to doing these as one PR in the midstream in the future |
Yes u right, sorry for the oversight this time 👍🏽 🙏🏽 |
|
cc @skamenan7 ptal |
|
don't 👏 merge 👏 manually 👏 |
sry I forgot :'( |
This MR enables S3-compatible storage backend support for the files API. The boto3 dependency is automatically resolved by the build system.
Signed-off-by: Mustafa Elbehery melbeher@redhat.com
Closes https://issues.redhat.com/browse/RHAIENG-2128
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.