fix: Remove port mapping from vllm startup#29
fix: Remove port mapping from vllm startup#29nathan-weinberg merged 1 commit intoopendatahub-io:mainfrom
Conversation
The container is being started with host networking we don't need to also map a port. Fixes: WARNING: Published ports are discarded when using host network mode Signed-off-by: Derek Higgins <derekh@redhat.com>
WalkthroughThe GitHub Action at .github/actions/setup-vllm/action.yml was updated to remove the docker run -p 8000:8000 port publishing flag. Other flags, including --net=host and --port 8000, remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
lgtm |
The container is being started with host networking we don't need to also map a port.
Fixes:
WARNING: Published ports are discarded when using host network mode
Summary by CodeRabbit