Skip to content

fix: Remove port mapping from vllm startup#29

Merged
nathan-weinberg merged 1 commit intoopendatahub-io:mainfrom
derekhiggins:remove-port-mapping
Sep 15, 2025
Merged

fix: Remove port mapping from vllm startup#29
nathan-weinberg merged 1 commit intoopendatahub-io:mainfrom
derekhiggins:remove-port-mapping

Conversation

@derekhiggins
Copy link
Copy Markdown
Collaborator

@derekhiggins derekhiggins commented Sep 15, 2025

The container is being started with host networking we don't need to also map a port.

Fixes:
WARNING: Published ports are discarded when using host network mode

Summary by CodeRabbit

  • Chores
    • Updated the Setup VLLM CI action to adjust container networking configuration, removing explicit port exposure to reduce potential conflicts.
    • Improves reliability and consistency of the CI environment.
    • No changes to user-facing features or behavior.

The container is being started with host networking
we don't need to also map a port.

Fixes:
WARNING: Published ports are discarded when using host network mode

Signed-off-by: Derek Higgins <derekh@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 15, 2025

Walkthrough

The GitHub Action at .github/actions/setup-vllm/action.yml was updated to remove the docker run -p 8000:8000 port publishing flag. Other flags, including --net=host and --port 8000, remain unchanged.

Changes

Cohort / File(s) Summary
GitHub Action: setup-vllm
.\github\actions\setup-vllm\action.yml
Removed docker run port publishing flag (-p 8000:8000); retained --net=host and --port 8000 options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I hopped through ports, a tidy sweep,
Unmapped the 8000 keep.
Host net whispers, “I’ve got you now,”
The container nods with a silent bow.
Fewer flags, same rivers flow—
Carrot logs green, on we go! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix: Remove port mapping from vllm startup" is concise, follows conventional-commit style, and accurately summarizes the primary change in the diff (removal of the Docker port mapping for vllm startup as shown in .github/actions/setup-vllm/action.yml) and aligns with the PR description about host networking and the warning. It is specific enough for a teammate scanning history to understand the main intent without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b0f8bc and f6f39f1.

📒 Files selected for processing (1)
  • .github/actions/setup-vllm/action.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/actions/setup-vllm/action.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-test-push (linux/amd64)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Elbehery
Copy link
Copy Markdown
Collaborator

lgtm

@nathan-weinberg nathan-weinberg merged commit 4f3a44d into opendatahub-io:main Sep 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants