test: Add granite-embedding-125m model to integration tests

[derekhiggins]

Enabling granite-embedding-125m will allow the embedding tests to run.

Summary by CodeRabbit

• Tests
  • Updated integration test script to include an additional embedding-model parameter alongside the existing text-model parameter, ensuring integration tests exercise embedding behavior as well as text handling.

[coderabbitai]

Walkthrough

Added an extra pytest flag to the integration test runner script to specify an embedding model alongside the existing text model parameter.

Changes

Cohort / File(s)	Summary
Test runner flag update tests/run_integration_tests.sh	Appended --embedding-model=granite-embedding-125m to the pytest invocation, alongside the existing --text-model flag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I tap my paws, a tiny tweak,
A flag appended, sleek and chic.
Tests now know which vibes to bring—
Embeddings hum, assertions sing.
In burrows deep, I sip my tea,
One more carrot for CI. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title accurately and concisely summarizes the primary change—adding the granite-embedding-125m embedding model to the integration tests—and directly matches the modification in tests/run_integration_tests.sh. It is specific, uses the "test:" scope, and is clear for teammates scanning history.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88ce050 and 3d508c6.

📒 Files selected for processing (1)

• tests/run_integration_tests.sh (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/run_integration_tests.sh

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-test-push (linux/amd64)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/run_integration_tests.sh (1)

56-56: Parameterize embedding model (symmetry with INFERENCE_MODEL).

Hardcoding makes local overrides harder. Mirror the INFERENCE_MODEL pattern.

Apply this diff:

@@
 INFERENCE_MODEL="${INFERENCE_MODEL:-meta-llama/Llama-3.2-1B-Instruct}"
+EMBEDDING_MODEL="${EMBEDDING_MODEL:-granite-embedding-125m}"
@@
-        --embedding-model=granite-embedding-125m \
+        --embedding-model="$EMBEDDING_MODEL" \

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b0f8bc and 88ce050.

📒 Files selected for processing (1)

• tests/run_integration_tests.sh (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-test-push (linux/amd64)

🔇 Additional comments (1)

tests/run_integration_tests.sh (1)

53-57: Confirm embedding provider prefix matches run.yaml.

distribution/run.yaml declares the embedding as provider_id: sentence-transformers, model_id: granite-embedding-125m (provider_model_id: ibm-granite/granite-embedding-125m-english). Update tests/run_integration_tests.sh (lines 53–57) to pass the provider-prefixed model (sentence-transformers/granite-embedding-125m) for --embedding-model if the pytest plugin expects provider/model; otherwise verify the plugin accepts bare model IDs.

[Elbehery]

lgtm