chore: add Artemy as CODEOWNER for CI and tests#32
chore: add Artemy as CODEOWNER for CI and tests#32nathan-weinberg merged 3 commits intoopendatahub-io:mainfrom
Conversation
WalkthroughUpdates Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6c1f987 to
e6e2eb3
Compare
ensures he gets cc'd/can review any changes Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
e6e2eb3 to
d6881fb
Compare
|
Did the same for @kami619 after discussing with him 😄 |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/CODEOWNERS (2)
8-9: Consider root-anchoring if you only mean top-level paths.If only the repo‑root directories should be owned, add leading “/”. Keep current patterns if you intentionally want to match nested modules.
-.github/ @Artemon-line -tests/ @Artemon-line +/.github/ @Artemon-line +/tests/ @Artemon-line
8-8: If CI workflows (not all .github content) are the goal, narrow the scope.“.github/” also covers CODEOWNERS, issue/PR templates, dependabot, etc. For CI‑only, target workflows (and composite actions if used).
-.github/ @Artemon-line +/.github/workflows/ @Artemon-line +# If using composite actions: +# /.github/actions/ @Artemon-line
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-test-push (linux/amd64)
🔇 Additional comments (1)
.github/CODEOWNERS (1)
8-9: Confirm intent: .github/ and tests/ now owned only by @Artemon-line./.github/CODEOWNERS has '*' defaults and explicit lines '.github/ @Artemon-line' and 'tests/ @Artemon-line' (./.github/CODEOWNERS lines 8–9). CODEOWNERS is last-match-wins, so those lines override the defaults and make @Artemon-line the sole owner for those paths.
If you intended additive ownership, replace those lines with the suggested diff:
-.github/ @Artemon-line -tests/ @Artemon-line +/.github/ @Artemon-line @cdoern @derekhiggins @Elbehery @leseb @mfleader @nathan-weinberg @rhdedgar @rhuss @skamenan7 @VaishnaviHire +/tests/ @Artemon-line @cdoern @derekhiggins @Elbehery @leseb @mfleader @nathan-weinberg @rhdedgar @rhuss @skamenan7 @VaishnaviHire
we can readd him once he has accept the repo invite Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
leseb
left a comment
There was a problem hiding this comment.
we need to re-add Matt once he accepts the invite to join the repo
ensures he gets cc'd/can review any changes
Summary by CodeRabbit