Skip to content

chore: add Artemy as CODEOWNER for CI and tests#32

Merged
nathan-weinberg merged 3 commits intoopendatahub-io:mainfrom
nathan-weinberg:update-cown
Sep 15, 2025
Merged

chore: add Artemy as CODEOWNER for CI and tests#32
nathan-weinberg merged 3 commits intoopendatahub-io:mainfrom
nathan-weinberg:update-cown

Conversation

@nathan-weinberg
Copy link
Copy Markdown
Collaborator

@nathan-weinberg nathan-weinberg commented Sep 15, 2025

ensures he gets cc'd/can review any changes

Summary by CodeRabbit

  • Chores
    • Updated repository ownership rules: preserved default global owners for most files while introducing dedicated per-directory owners for CI and test areas and removing one previously listed global owner.
    • No changes to user-facing functionality or public APIs.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 15, 2025

Walkthrough

Updates .github/CODEOWNERS: removes mfleader from default global owners and adds per-directory ownership rules assigning @Artemon-line and @kami619 to the .github/ and tests/ directories; existing default owners for other paths remain unchanged.

Changes

Cohort / File(s) Summary of Changes
Repository governance
.github/CODEOWNERS
Removed mfleader from default owners; added per-directory CODEOWNERS entries assigning @Artemon-line and @kami619 to the .github/ and tests/ directories while preserving other default owners.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I twitch my nose at rules refined,
New keepers listed, duties signed.
In .github nooks and testy glen,
We guard the gates again and again.
Hops of approval, tiny and spry,
Carrots of CI beneath the sky.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: add Artemy as CODEOWNER for CI and tests" succinctly and accurately summarizes the primary change: updating CODEOWNERS to add ownership for CI-related files and tests. The raw summary shows per-directory ownership added for .github/ and tests/ assigning Artemon-line (and kami619), which matches the title's intent to add Artemy as a reviewer for those areas. The title omits the minor removal of mfleader from the global owners but that omission does not make the title misleading or unclear.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6e2eb3 and 621f688.

📒 Files selected for processing (1)
  • .github/CODEOWNERS (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/CODEOWNERS
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-test-push (linux/amd64)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nathan-weinberg nathan-weinberg force-pushed the update-cown branch 2 times, most recently from 6c1f987 to e6e2eb3 Compare September 15, 2025 12:58
ensures he gets cc'd/can review any changes

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg
Copy link
Copy Markdown
Collaborator Author

Did the same for @kami619 after discussing with him 😄

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/CODEOWNERS (2)

8-9: Consider root-anchoring if you only mean top-level paths.

If only the repo‑root directories should be owned, add leading “/”. Keep current patterns if you intentionally want to match nested modules.

-.github/ @Artemon-line
-tests/ @Artemon-line
+/.github/ @Artemon-line
+/tests/ @Artemon-line

8-8: If CI workflows (not all .github content) are the goal, narrow the scope.

“.github/” also covers CODEOWNERS, issue/PR templates, dependabot, etc. For CI‑only, target workflows (and composite actions if used).

-.github/ @Artemon-line
+/.github/workflows/ @Artemon-line
+# If using composite actions:
+# /.github/actions/ @Artemon-line
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db3c99b and e6e2eb3.

📒 Files selected for processing (1)
  • .github/CODEOWNERS (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-test-push (linux/amd64)
🔇 Additional comments (1)
.github/CODEOWNERS (1)

8-9: Confirm intent: .github/ and tests/ now owned only by @Artemon-line

./.github/CODEOWNERS has '*' defaults and explicit lines '.github/ @Artemon-line' and 'tests/ @Artemon-line' (./.github/CODEOWNERS lines 8–9). CODEOWNERS is last-match-wins, so those lines override the defaults and make @Artemon-line the sole owner for those paths.

If you intended additive ownership, replace those lines with the suggested diff:

-.github/ @Artemon-line
-tests/ @Artemon-line
+/.github/ @Artemon-line @cdoern @derekhiggins @Elbehery @leseb @mfleader @nathan-weinberg @rhdedgar @rhuss @skamenan7 @VaishnaviHire
+/tests/   @Artemon-line @cdoern @derekhiggins @Elbehery @leseb @mfleader @nathan-weinberg @rhdedgar @rhuss @skamenan7 @VaishnaviHire

we can readd him once he has accept the repo invite

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Copy link
Copy Markdown
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to re-add Matt once he accepts the invite to join the repo

@nathan-weinberg nathan-weinberg merged commit 756fad8 into opendatahub-io:main Sep 15, 2025
5 checks passed
@nathan-weinberg nathan-weinberg deleted the update-cown branch September 15, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants