Skip to content

ci: Skip a consistently timing out test#43

Merged
derekhiggins merged 1 commit intoopendatahub-io:mainfrom
derekhiggins:skip-timeout2
Sep 18, 2025
Merged

ci: Skip a consistently timing out test#43
derekhiggins merged 1 commit intoopendatahub-io:mainfrom
derekhiggins:skip-timeout2

Conversation

@derekhiggins
Copy link
Copy Markdown
Collaborator

@derekhiggins derekhiggins commented Sep 18, 2025

  • test_text_chat_completion_structured_output

This test has been consistently timing out and is now skipped in the integration test suite.

Summary by CodeRabbit

  • Tests
    • Updated integration test runner to exclude an additional flaky test, improving stability and reducing false negatives in CI.
    • No changes to application features or behavior.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 18, 2025

Walkthrough

The integration test runner script updates its SKIP_TESTS pattern to also exclude test_text_chat_completion_structured_output. Test selection continues to use pytest’s -k with a negated SKIP_TESTS expression, and STACK_CONFIG_PATH handling is unchanged.

Changes

Cohort / File(s) Summary of Changes
Integration test runner
tests/run_integration_tests.sh
Expanded SKIP_TESTS to include test_text_chat_completion_structured_output; no other logic changes to pytest invocation or STACK_CONFIG_PATH handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop, a skip, a test to miss,
I twitch my nose—add one to list.
The suite still runs, the carrots gleam,
One fewer flake to break the stream.
Thump-thump! Green fields of checks persist. 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "ci: Skip a consistently timing out test" concisely and accurately summarizes the PR's primary change — skipping a CI test that consistently times out, which matches the change that adds test_text_chat_completion_structured_output to SKIP_TESTS. It is clear, specific to CI, and informative for teammates scanning history.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- test_text_chat_completion_structured_output

This test has been consistently timing out and is now skipped in the integration test suite.

Signed-off-by: Derek Higgins <derekh@redhat.com>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/run_integration_tests.sh (1)

44-44: Optional: make SKIP_TESTS extensible via env and future‑proof if the list changes.

Allow adding extra patterns without code changes and keep the -k expr stable.

Apply this minimal tweak:

-SKIP_TESTS="test_text_chat_completion_tool_calling_tools_not_in_request or test_inference_store_tool_calls or test_text_chat_completion_structured_output"
+SKIP_TESTS="test_text_chat_completion_tool_calling_tools_not_in_request or test_inference_store_tool_calls or test_text_chat_completion_structured_output"
+# Allow CI to append more without editing this script
+[ -n "${EXTRA_SKIP_TESTS:-}" ] && SKIP_TESTS="$SKIP_TESTS or ${EXTRA_SKIP_TESTS}"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b535695 and c56c7fb.

📒 Files selected for processing (1)
  • tests/run_integration_tests.sh (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-test-push (linux/amd64)
🔇 Additional comments (1)
tests/run_integration_tests.sh (1)

44-44: LGTM on adding the flaky test to the skip list.

Matches the PR intent to unblock CI by excluding test_text_chat_completion_structured_output. Please add a short comment with an upstream issue/PR link and expected follow‑up to re‑enable.

@derekhiggins derekhiggins merged commit 1a88ab1 into opendatahub-io:main Sep 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants