ci: Skip a consistently timing out test#43
Conversation
WalkthroughThe integration test runner script updates its SKIP_TESTS pattern to also exclude test_text_chat_completion_structured_output. Test selection continues to use pytest’s -k with a negated SKIP_TESTS expression, and STACK_CONFIG_PATH handling is unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- test_text_chat_completion_structured_output This test has been consistently timing out and is now skipped in the integration test suite. Signed-off-by: Derek Higgins <derekh@redhat.com>
e62fc35 to
c56c7fb
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/run_integration_tests.sh (1)
44-44: Optional: make SKIP_TESTS extensible via env and future‑proof if the list changes.Allow adding extra patterns without code changes and keep the
-kexpr stable.Apply this minimal tweak:
-SKIP_TESTS="test_text_chat_completion_tool_calling_tools_not_in_request or test_inference_store_tool_calls or test_text_chat_completion_structured_output" +SKIP_TESTS="test_text_chat_completion_tool_calling_tools_not_in_request or test_inference_store_tool_calls or test_text_chat_completion_structured_output" +# Allow CI to append more without editing this script +[ -n "${EXTRA_SKIP_TESTS:-}" ] && SKIP_TESTS="$SKIP_TESTS or ${EXTRA_SKIP_TESTS}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/run_integration_tests.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-test-push (linux/amd64)
🔇 Additional comments (1)
tests/run_integration_tests.sh (1)
44-44: LGTM on adding the flaky test to the skip list.Matches the PR intent to unblock CI by excluding
test_text_chat_completion_structured_output. Please add a short comment with an upstream issue/PR link and expected follow‑up to re‑enable.
This test has been consistently timing out and is now skipped in the integration test suite.
Summary by CodeRabbit