fix: bring back milvus-lite#44
Conversation
milvus no longer includes milvus-lite by default see: milvus-io/pymilvus#2976 this commit modifies our build script to include it otherwise the inline::milvus provider fails on boot Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
WalkthroughUpdates dependency handling to require the pymilvus milvus-lite extra. The Containerfile switches to installing pymilvus with [milvus-lite] constraint, and build.py rewrites any pymilvus dependency to pymilvus[milvus-lite] during dependency resolution. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as build.py
participant UV as uv pip parser
participant Pip as pip install
Dev->>UV: Parse dependencies (requirements/constraints)
UV-->>Dev: Package list (includes pymilvus)
note over Dev: Rewrite "pymilvus" -> "pymilvus[milvus-lite]"
Dev->>Pip: Install commands with rewritten deps
Pip-->>Dev: Installation result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
distribution/Containerfile(1 hunks)distribution/build.py(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: nathan-weinberg
PR: opendatahub-io/llama-stack-distribution#33
File: distribution/Containerfile:17-21
Timestamp: 2025-09-15T14:25:54.837Z
Learning: In the opendatahub-io/llama-stack-distribution repository, the distribution/Containerfile is auto-generated by distribution/build.py based on configuration in build.yaml. When providers are added to build.yaml, the build script automatically regenerates the Containerfile with the required dependencies. Changes to the Containerfile should not be flagged as manual edits if they correspond to legitimate changes in the build configuration.
📚 Learning: 2025-09-15T14:25:54.837Z
Learnt from: nathan-weinberg
PR: opendatahub-io/llama-stack-distribution#33
File: distribution/Containerfile:17-21
Timestamp: 2025-09-15T14:25:54.837Z
Learning: In the opendatahub-io/llama-stack-distribution repository, the distribution/Containerfile is auto-generated by distribution/build.py based on configuration in build.yaml. When providers are added to build.yaml, the build script automatically regenerates the Containerfile with the required dependencies. Changes to the Containerfile should not be flagged as manual edits if they correspond to legitimate changes in the build configuration.
Applied to files:
distribution/Containerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-test-push (linux/amd64)
🔇 Additional comments (1)
distribution/Containerfile (1)
28-28: Approve: Milvus Lite extra enabled — looks good
Sanity checks passed: exactly one 'pymilvus[milvus-lite]>=2.4.10' in distribution/Containerfile (line 28); no duplicate extras or accidental mutations.
|
Upstream followup llamastack/llama-stack#3488 |
What does this PR do?
milvus no longer includes milvus-lite by default
see: milvus-io/pymilvus#2976
this commit modifies our build script to include it otherwise the inline::milvus provider fails on boot
Test Plan
CI should pass
Summary by CodeRabbit