ci: only run container job on distro, tests, or infra change

[nathan-weinberg]

What does this PR do?

this is a long running job that doesn't need to run all the time

Summary by CodeRabbit

• Chores

  • Updated pull request merge strategy to preserve individual commits.
  • Removed automatic conflict notifications and labeling for rebases.

• Tests

  • Adjusted workflow triggers to run only when relevant areas change, reducing unnecessary runs and speeding up feedback.

[coderabbitai]

Warning

Rate limit exceeded

@nathan-weinberg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 82cec90 and 98d9e90.

📒 Files selected for processing (2)

• .github/mergify.yml (1 hunks)
• .github/workflows/redhat-distro-container.yml (1 hunks)

Walkthrough

Updated Mergify configuration to switch PR merge method from squash to merge and removed two conflict-labeling actions. Adjusted a GitHub Actions workflow to add path filters to the pull_request trigger, aligning it with the push trigger.

Changes

Cohort / File(s)	Summary of changes
Mergify merge policy update .github/mergify.yml	Changed pull_request_rules.actions.merge.method from squash to merge. Removed actions that ping author/add needs-rebase label and remove it upon resolution.
Workflow trigger path filters .github/workflows/redhat-distro-container.yml	Added paths filters to pull_request trigger for .github/actions/setup-vllm/action.yml, .github/workflows/redhat-distro-container.yml, distribution/**, and tests/**, mirroring existing push paths.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub
  participant WF as GH Actions: redhat-distro-container
  participant MG as Mergify

  Dev->>GH: Open/Update PR
  GH->>WF: pull_request event (only if paths match)
  Note over WF: Runs when changes in<br/>.github/actions/setup-vllm/action.yml,<br/>.github/workflows/redhat-distro-container.yml,<br/>distribution/**, tests/**

  GH->>MG: PR status and rule evaluation
  MG->>GH: Merge PR (method = merge)
  Note over MG: Conflict label automation removed<br/>(no ping/no needs-rebase label)

  Dev->>GH: Push to branches
  GH->>WF: push event (same paths)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge the merge with gentle thumps,
No squashing now—just tidy bumps.
The labels hop away, no chase,
Our workflows trigger, path in place.
A rabbit stamps: “All clear, proceed!” 🐇✅
CI burrows swift—exactly what we need.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title concisely and accurately summarizes the primary change: restricting the long-running container CI job to run only when distro, tests, or infra-related files change. It matches the workflow path-filter updates and the PR objectives, uses a clear "ci:" prefix, and is specific enough for a teammate scanning history to understand the main change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[VaishnaviHire]

/lgtm

[cdoern]

are single quotes necessary?

[nathan-weinberg]

are single quotes necessary?

I must commend the thought and effort you've poured into this. Regrettably, I don't feel this is the correct direction for the project.

[cdoern]

fair enough I guess

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/redhat-distro-container.yml (1)

11-15: Pull request-only path filters; push still unfiltered — job will continue to run on every push.

If the goal is to run the long job only on distro/tests/infra changes, mirror the same path filters under the push trigger.

Proposed change:

 on:
   pull_request:
     branches:
       - main
       - rhoai-v*
     types:
       - opened
       - synchronize
     paths:
-      - '.github/actions/setup-vllm/action.yml'
+      - '.github/actions/setup-vllm/**'
       - '.github/workflows/redhat-distro-container.yml'
       - 'distribution/**'
       - 'tests/**'
   push:
     branches:
       - main
       - rhoai-v*
+    paths:
+      - '.github/actions/setup-vllm/**'
+      - '.github/workflows/redhat-distro-container.yml'
+      - 'distribution/**'
+      - 'tests/**'

Notes:

• Expanded setup-vllm path to include the whole action directory to catch changes beyond action.yml.
• Confirm that publishing on pushes where only tests change is intended. The “Publish image” step runs on any push that meets the workflow trigger. If that’s not desired, we can gate publishing further (e.g., separate publish job with stricter paths, or a condition based on changed files).
• Single quotes around paths are optional; YAML and GitHub Actions accept these unquoted. If preferred, you can drop the quotes for consistency with common examples.

.github/mergify.yml (1)

17-17: Switch to merge commits — verify repo settings and desired history policy.

Ensure “Allow merge commits” is enabled in repository settings and that this aligns with your history policy. Consider enabling strict/smart updates if you want Mergify to auto-update branches before merging to avoid outdated merges.

Example (if desired):

pull_request_rules:
  - name: auto-merge
    conditions:
      # ...
    actions:
      merge:
        method: merge
        strict: smart+fasttrack

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a281b66 and 82cec90.

📒 Files selected for processing (2)

• .github/mergify.yml (1 hunks)
• .github/workflows/redhat-distro-container.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build-test-push (linux/amd64)
• GitHub Check: Summary

[nathan-weinberg]

Merging manually so the Mergify change takes affect