feat: bump trustyai_fms to v0.2.3#56
Conversation
WalkthroughUpdate Trustyai FMS provider from 0.2.2 to 0.2.3 across distribution files; Containerfile now installs the new package using the Test PyPI index via --extra-index-url. build.py post-processes dependency commands to inject the extra-index-url and adds more verbose error reporting on failure. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CI as CI / Build pipeline
participant BuildPy as distribution/build.py
participant Shell as shell / pip
note over BuildPy: 1) gather dependency commands\n2) post-process provider line
CI ->> BuildPy: invoke get_dependencies()
BuildPy ->> BuildPy: assemble commands list
BuildPy ->> BuildPy: replace provider spec with pip command + --extra-index-url
BuildPy ->> Shell: run pip install commands
alt install succeeds
Shell -->> CI: exit 0
else install fails
Shell -->> BuildPy: stderr, non-zero
BuildPy ->> CI: print verbose error (stderr) and exit(1)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
197fcfe to
ae84596
Compare
https://test.pypi.org/project/llama-stack-provider-trustyai-fms/ Relates to: RHAIENG-1326 Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
ae84596 to
ad827b9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
distribution/Containerfile(1 hunks)distribution/build.py(1 hunks)distribution/build.yaml(1 hunks)distribution/run.yaml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- distribution/run.yaml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-15T14:25:54.837Z
Learnt from: nathan-weinberg
PR: opendatahub-io/llama-stack-distribution#33
File: distribution/Containerfile:17-21
Timestamp: 2025-09-15T14:25:54.837Z
Learning: In the opendatahub-io/llama-stack-distribution repository, the distribution/Containerfile is auto-generated by distribution/build.py based on configuration in build.yaml. When providers are added to build.yaml, the build script automatically regenerates the Containerfile with the required dependencies. Changes to the Containerfile should not be flagged as manual edits if they correspond to legitimate changes in the build configuration.
Applied to files:
distribution/Containerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-test-push (linux/amd64)
- GitHub Check: Summary
🔇 Additional comments (3)
distribution/build.yaml (1)
18-18: LGTM - Version bump is consistent.The version update from 0.2.2 to 0.2.3 aligns with the PR objective and is properly reflected in the safety provider module declaration.
distribution/build.py (1)
134-134: Good addition of stderr to error reporting.Including stderr in the error output improves debugging by providing complete information when the subprocess fails.
distribution/Containerfile (1)
45-45: Document temporary Test PyPI usage and migration plan
- The Containerfile is auto-generated by
distribution/build.py, which injects the Test PyPI index fortrustyai_fmsper the TODO atdistribution/build.py:123. Ensure this is marked as temporary and track a timeline for switching to the main PyPI in the PR description or a dedicated issue.
fix: RHAIENG-2958: Update wheels version to 3.2.808
What does this PR do?
This PR bumps trustyai_fms to v0.2.3.
https://test.pypi.org/project/llama-stack-provider-trustyai-fms/
Closes: https://issues.redhat.com/browse/RHAIENG-1326
Summary by CodeRabbit