Skip to content

feat: bump trustyai_fms to v0.2.3#56

Merged
Elbehery merged 1 commit intoopendatahub-io:mainfrom
Elbehery:20251001_bump_trustyai-fms
Oct 1, 2025
Merged

feat: bump trustyai_fms to v0.2.3#56
Elbehery merged 1 commit intoopendatahub-io:mainfrom
Elbehery:20251001_bump_trustyai-fms

Conversation

@Elbehery
Copy link
Copy Markdown
Collaborator

@Elbehery Elbehery commented Oct 1, 2025

What does this PR do?

This PR bumps trustyai_fms to v0.2.3.

https://test.pypi.org/project/llama-stack-provider-trustyai-fms/

Closes: https://issues.redhat.com/browse/RHAIENG-1326

Summary by CodeRabbit

  • Chores
    • Updated the TrustyAI FMS safety provider to v0.2.3 in build and runtime configurations.
    • Adjusted dependency source handling to fetch the new provider version from an alternate package index.
    • Improved installation error reporting to provide clearer diagnostics if a dependency install fails.
    • No changes to workflows, settings, compatibility, or runtime behavior.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 1, 2025

Walkthrough

Update Trustyai FMS provider from 0.2.2 to 0.2.3 across distribution files; Containerfile now installs the new package using the Test PyPI index via --extra-index-url. build.py post-processes dependency commands to inject the extra-index-url and adds more verbose error reporting on failure.

Changes

Cohort / File(s) Summary
Provider version bump
distribution/Containerfile, distribution/build.yaml, distribution/run.yaml
Bumped llama_stack_provider_trustyai_fms from 0.2.2 to 0.2.3. distribution/Containerfile install line updated to include --extra-index-url https://test.pypi.org/simple for that package. No other structural edits.
Dependency handling & error reporting
distribution/build.py
After assembling dependency install commands, post-processes them to replace plain llama_stack_provider_trustyai_fms==0.2.3 with a pip install invocation that includes --extra-index-url. Enhances exception path to include command stderr in output and exit with status 1 on failure.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant CI as CI / Build pipeline
    participant BuildPy as distribution/build.py
    participant Shell as shell / pip
    note over BuildPy: 1) gather dependency commands\n2) post-process provider line
    CI ->> BuildPy: invoke get_dependencies()
    BuildPy ->> BuildPy: assemble commands list
    BuildPy ->> BuildPy: replace provider spec with pip command + --extra-index-url
    BuildPy ->> Shell: run pip install commands
    alt install succeeds
        Shell -->> CI: exit 0
    else install fails
        Shell -->> BuildPy: stderr, non-zero
        BuildPy ->> CI: print verbose error (stderr) and exit(1)
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I twitch my whiskers, versions hop—
From .2 to .3, a nimble swap.
Test PyPI shows a secret door,
A quiet trail to fetch and store.
Thump! The build goes on some more. 🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the core change of the pull request by indicating the bump of the trustyai_fms package to version 0.2.3, follows a conventional commit style prefix, and is both clear and concise without unnecessary detail.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Elbehery Elbehery force-pushed the 20251001_bump_trustyai-fms branch 3 times, most recently from 197fcfe to ae84596 Compare October 1, 2025 06:28
Comment thread distribution/build.py
https://test.pypi.org/project/llama-stack-provider-trustyai-fms/

Relates to: RHAIENG-1326

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
@Elbehery Elbehery force-pushed the 20251001_bump_trustyai-fms branch from ae84596 to ad827b9 Compare October 1, 2025 07:47
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92226b4 and ad827b9.

📒 Files selected for processing (4)
  • distribution/Containerfile (1 hunks)
  • distribution/build.py (1 hunks)
  • distribution/build.yaml (1 hunks)
  • distribution/run.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • distribution/run.yaml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-15T14:25:54.837Z
Learnt from: nathan-weinberg
PR: opendatahub-io/llama-stack-distribution#33
File: distribution/Containerfile:17-21
Timestamp: 2025-09-15T14:25:54.837Z
Learning: In the opendatahub-io/llama-stack-distribution repository, the distribution/Containerfile is auto-generated by distribution/build.py based on configuration in build.yaml. When providers are added to build.yaml, the build script automatically regenerates the Containerfile with the required dependencies. Changes to the Containerfile should not be flagged as manual edits if they correspond to legitimate changes in the build configuration.

Applied to files:

  • distribution/Containerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-test-push (linux/amd64)
  • GitHub Check: Summary
🔇 Additional comments (3)
distribution/build.yaml (1)

18-18: LGTM - Version bump is consistent.

The version update from 0.2.2 to 0.2.3 aligns with the PR objective and is properly reflected in the safety provider module declaration.

distribution/build.py (1)

134-134: Good addition of stderr to error reporting.

Including stderr in the error output improves debugging by providing complete information when the subprocess fails.

distribution/Containerfile (1)

45-45: Document temporary Test PyPI usage and migration plan

  • The Containerfile is auto-generated by distribution/build.py, which injects the Test PyPI index for trustyai_fms per the TODO at distribution/build.py:123. Ensure this is marked as temporary and track a timeline for switching to the main PyPI in the PR description or a dedicated issue.

Comment thread distribution/build.py
Comment thread distribution/build.py
@Elbehery Elbehery merged commit ff047c3 into opendatahub-io:main Oct 1, 2025
6 checks passed
@Elbehery Elbehery deleted the 20251001_bump_trustyai-fms branch October 1, 2025 11:51
ChristianZaccaria pushed a commit to ChristianZaccaria/llama-stack-distribution that referenced this pull request Feb 18, 2026
fix: RHAIENG-2958: Update wheels version to 3.2.808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants