Skip to content

ci(docs): add new column detailing how to enable a provider#58

Merged
mergify[bot] merged 1 commit intoopendatahub-io:mainfrom
nathan-weinberg:further-enhance
Oct 2, 2025
Merged

ci(docs): add new column detailing how to enable a provider#58
mergify[bot] merged 1 commit intoopendatahub-io:mainfrom
nathan-weinberg:further-enhance

Conversation

@nathan-weinberg
Copy link
Copy Markdown
Collaborator

@nathan-weinberg nathan-weinberg commented Oct 2, 2025

What does this PR do?

Make it easier for users to enable providers they desire

Summary by CodeRabbit

  • Documentation
    • Expanded the distribution table with a new “How to enable” column.
    • Added per-entry guidance on enabling providers, including clear environment variable instructions where applicable.
    • Clarified the relationship between default status and enablement steps for each provider.
    • Improved readability and discoverability of setup information across providers.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 2, 2025

Warning

Rate limit exceeded

@nathan-weinberg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f18afd7 and 9ebf50c.

📒 Files selected for processing (2)
  • distribution/README.md (1 hunks)
  • scripts/gen_distro_docs.py (2 hunks)

Walkthrough

Adds a fourth “How to enable” column to the distribution table. Updates the generation script to derive per-entry enablement guidance from conditional provider IDs, adjust default-enabled flags accordingly, and render the new column. Non-conditional providers remain “Yes” with “N/A”. Documentation regenerated to reflect the new column.

Changes

Cohort / File(s) Summary
Docs: Distribution table update
distribution/README.md
Expanded the table from 3 to 4 columns by adding “How to enable”. Populated each row with either “N/A” or a guidance string aligned with the provider’s conditional configuration.
Docs generator: Table logic and data model
scripts/gen_distro_docs.py
Extended entry tuples to include how_to_enable. Added detection of conditional provider IDs, deriving env var guidance and flipping enabled_by_default to “No”. Updated header/separator and row rendering to output the new column. Minor regex/variable name adjustments.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as gen_distro_docs.py
  participant Config as Provider Entries
  participant Regex as Conditional Matcher
  participant Render as Table Renderer
  participant Doc as distribution/README.md

  Dev->>Config: Iterate provider entries
  Config-->>Dev: api_name, provider_type, provider_id
  Dev->>Regex: Check provider_id for ${VAR:+...}
  alt Conditional provider_id
    Regex-->>Dev: Match with env var name
    Dev->>Dev: enabled_by_default = "No"
    Dev->>Dev: how_to_enable = "Set the VAR environment variable"
  else Non-conditional
    Dev->>Dev: enabled_by_default = "Yes"
    Dev->>Dev: how_to_enable = "N/A"
  end
  Dev->>Render: Build row [API, Provider, Enabled?, How to enable]
  Render-->>Dev: Formatted Markdown row
  Dev->>Doc: Write updated table
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I thump the docs with gentle cheer,
A fourth small column now appears.
If vars are set, the paths are clear—
If not, a note will nudge your ear.
I nibble tuples, neat and able,
Then hop away—complete the table. 🐇📜

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change of adding a column detailing how to enable a provider in documentation and aligns with the actual modifications.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e33ccd5 and f18afd7.

📒 Files selected for processing (2)
  • distribution/README.md (1 hunks)
  • scripts/gen_distro_docs.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-test-push (linux/amd64)
  • GitHub Check: Summary
🔇 Additional comments (4)
scripts/gen_distro_docs.py (3)

42-43: LGTM!

The new column header and separator are correctly formatted.


83-91: LGTM!

The tuple unpacking and table row rendering correctly handle the new 4-tuple structure.


59-77: Regex matches all ${...:+...} provider_id patterns
All ${...:+...} entries in distribution/run.yaml match the current pattern; no action needed.

distribution/README.md (1)

11-35: LGTM!

The table structure is correct with the new "How to enable" column properly formatted. The content accurately reflects conditional and non-conditional providers.

Comment thread distribution/README.md Outdated
Comment thread scripts/gen_distro_docs.py
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@mergify mergify bot merged commit 1abc704 into opendatahub-io:main Oct 2, 2025
5 checks passed
@nathan-weinberg nathan-weinberg deleted the further-enhance branch October 2, 2025 20:33
nathan-weinberg pushed a commit to nathan-weinberg/llama-stack-distribution that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants