ci(docs): add new column detailing how to enable a provider#58
Conversation
|
Warning Rate limit exceeded@nathan-weinberg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 44 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughAdds a fourth “How to enable” column to the distribution table. Updates the generation script to derive per-entry enablement guidance from conditional provider IDs, adjust default-enabled flags accordingly, and render the new column. Non-conditional providers remain “Yes” with “N/A”. Documentation regenerated to reflect the new column. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as gen_distro_docs.py
participant Config as Provider Entries
participant Regex as Conditional Matcher
participant Render as Table Renderer
participant Doc as distribution/README.md
Dev->>Config: Iterate provider entries
Config-->>Dev: api_name, provider_type, provider_id
Dev->>Regex: Check provider_id for ${VAR:+...}
alt Conditional provider_id
Regex-->>Dev: Match with env var name
Dev->>Dev: enabled_by_default = "No"
Dev->>Dev: how_to_enable = "Set the VAR environment variable"
else Non-conditional
Dev->>Dev: enabled_by_default = "Yes"
Dev->>Dev: how_to_enable = "N/A"
end
Dev->>Render: Build row [API, Provider, Enabled?, How to enable]
Render-->>Dev: Formatted Markdown row
Dev->>Doc: Write updated table
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
distribution/README.md(1 hunks)scripts/gen_distro_docs.py(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-test-push (linux/amd64)
- GitHub Check: Summary
🔇 Additional comments (4)
scripts/gen_distro_docs.py (3)
42-43: LGTM!The new column header and separator are correctly formatted.
83-91: LGTM!The tuple unpacking and table row rendering correctly handle the new 4-tuple structure.
59-77: Regex matches all${...:+...}provider_id patterns
All${...:+...}entries in distribution/run.yaml match the current pattern; no action needed.distribution/README.md (1)
11-35: LGTM!The table structure is correct with the new "How to enable" column properly formatted. The content accurately reflects conditional and non-conditional providers.
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
f18afd7 to
9ebf50c
Compare
…lis-patch-2 Update renovate.json
What does this PR do?
Make it easier for users to enable providers they desire
Summary by CodeRabbit