Skip to content

chore: add Sam into team + order member list#187

Merged
zdtsw merged 1 commit into
opendatahub-io:mainfrom
zdtsw-forking:chore_add_teammember
Apr 11, 2026
Merged

chore: add Sam into team + order member list#187
zdtsw merged 1 commit into
opendatahub-io:mainfrom
zdtsw-forking:chore_add_teammember

Conversation

@zdtsw

@zdtsw zdtsw commented Apr 10, 2026

Copy link
Copy Markdown
Member

Description

cc @anishasthana @hexfusion

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated team alias configuration to reflect current team membership.

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@openshift-ci openshift-ci Bot requested review from spolti and wseaton April 10, 2026 07:08
@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The OWNERS_ALIASES configuration was updated to modify the llm-d-team alias list. Three members were added: anishasthana, hexfusion, and nainaz. Two existing entries were removed, with the overall change resulting in a net addition of 3 lines and removal of 2 lines. This is a simple membership update to the alias configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding a team member (Sam/anishasthana) and reordering the member list in OWNERS_ALIASES.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Apr 10, 2026

Copy link
Copy Markdown

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the opendatahub-io org. You can then trigger verification by writing /verify-owners in a comment.

  • nainaz
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@github-actions

Copy link
Copy Markdown

Cannot approve the pull request: Error: openshift-ci[bot] is not included in the approvers role in the OWNERS file

@zdtsw zdtsw requested review from Gregory-Pereira and pierDipi and removed request for spolti and wseaton April 10, 2026 07:10

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@OWNERS_ALIASES`:
- Around line 2-13: The llm-d-team member list in OWNERS_ALIASES is not sorted;
reorder the entries under the llm-d-team key into case-insensitive alphabetical
order (compare usernames lowercased) so the list matches the PR title claim to
"order member list", and also update the PR or file to clarify which username
corresponds to "Sam" (or add the correct username for Sam) — check the current
entries aneeshkp, anishasthana, acardace, dagrayvid, evacchi, Gregory-Pereira,
hexfusion, nainaz, RishabhSaini, zdtsw, wseaton and reorder them and either
annotate or replace the appropriate entry to explicitly represent Sam.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d31a2ad9-d5dd-4f1f-9d44-b9d610b74bc1

📥 Commits

Reviewing files that changed from the base of the PR and between 5dbdf08 and 54010fc.

📒 Files selected for processing (1)
  • OWNERS_ALIASES

Comment thread OWNERS_ALIASES

@Gregory-Pereira Gregory-Pereira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Apr 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gregory-Pereira, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Gregory-Pereira,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown

Cannot approve the pull request: Error: openshift-ci[bot] is not included in the approvers role in the OWNERS file

@hexfusion

Copy link
Copy Markdown

/lgtm

Thanks

@github-actions

Copy link
Copy Markdown

Cannot apply the lgtm label because Error: hexfusion is not included in the reviewers role in the OWNERS file

@zdtsw

zdtsw commented Apr 11, 2026

Copy link
Copy Markdown
Member Author

/override ci/prow/images

@openshift-ci

openshift-ci Bot commented Apr 11, 2026

Copy link
Copy Markdown

@zdtsw: Overrode contexts on behalf of zdtsw: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zdtsw

zdtsw commented Apr 11, 2026

Copy link
Copy Markdown
Member Author

/override ci/prow/unit

@openshift-ci

openshift-ci Bot commented Apr 11, 2026

Copy link
Copy Markdown

@zdtsw: Overrode contexts on behalf of zdtsw: ci/prow/unit

Details

In response to this:

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zdtsw zdtsw merged commit c7c0201 into opendatahub-io:main Apr 11, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants