-
Notifications
You must be signed in to change notification settings - Fork 11
sync: upstream v0.9.0-rc2 #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e25e87b
2956a2b
f8432d6
71c234f
33eb8c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,6 +55,7 @@ GIT_COMMIT_SHA ?= $(shell git rev-parse HEAD 2>/dev/null) | |
| # Match only root-level release tags (v[0-9]*) so submodule tags don't leak into image versions. | ||
| ROOT_RELEASE_TAG_MATCH ?= v[0-9]* | ||
| BUILD_REF ?= $(shell git describe --tags --match '$(ROOT_RELEASE_TAG_MATCH)' --abbrev=0 2>/dev/null) | ||
| LATENCY_PREDICTOR_TAG ?= $(or $(EXTRA_TAG),$(BUILD_REF),latest) | ||
|
|
||
| # Host directories for Go module and build caches, bind-mounted into the builder container. | ||
| GO_MOD_CACHE_VOL ?= $(HOME)/.cache/llm-d-gomodcache | ||
|
|
@@ -214,7 +215,7 @@ check-latest-tags-strict: ## Check ':latest' image tags in YAML (strict; fails o | |
|
|
||
| .PHONY: presubmit | ||
| presubmit: LINT_NEW_ONLY=true | ||
| presubmit: git-branch-check signed-commits-check go-mod-check format lint vulncheck check-latest-tags | ||
| presubmit: git-branch-check signed-commits-check go-mod-check format lint vulncheck check-latest-tags-strict | ||
|
|
||
| .PHONY: git-branch-check | ||
| git-branch-check: | ||
|
|
@@ -348,7 +349,7 @@ verify-helm-charts: helm-install kubectl-validate ## Render and validate Helm ch | |
| .PHONY: helm-push | ||
| helm-push: yq helm-install ## Package and push a specified Helm chart. Usage: make helm-push CHART=<chart_name> | ||
| @if [ -z "$(CHART)" ]; then echo "Error: CHART variable is required (e.g. CHART=llm-d-router-standalone)"; exit 1; fi | ||
| CHART=$(CHART) EXTRA_TAG="$(EXTRA_TAG)" CHART_SUFFIX="$(CHART_SUFFIX)" EPP_RELEASE_IMAGE_REPOSITORY="$(EPP_RELEASE_IMAGE_REPOSITORY)" YQ="$(YQ)" HELM="$(HELM)" ./hack/push-chart.sh | ||
| CHART=$(CHART) EXTRA_TAG="$(EXTRA_TAG)" CHART_SUFFIX="$(CHART_SUFFIX)" EPP_RELEASE_IMAGE_REPOSITORY="$(EPP_RELEASE_IMAGE_REPOSITORY)" LATENCY_PREDICTOR_TAG="$(LATENCY_PREDICTOR_TAG)" YQ="$(YQ)" HELM="$(HELM)" ./hack/push-chart.sh | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unquoted
Patch- CHART=$(CHART) EXTRA_TAG="$(EXTRA_TAG)" CHART_SUFFIX="$(CHART_SUFFIX)" EPP_RELEASE_IMAGE_REPOSITORY="$(EPP_RELEASE_IMAGE_REPOSITORY)" LATENCY_PREDICTOR_TAG="$(LATENCY_PREDICTOR_TAG)" YQ="$(YQ)" HELM="$(HELM)" ./hack/push-chart.sh
+ CHART="$(CHART)" EXTRA_TAG="$(EXTRA_TAG)" CHART_SUFFIX="$(CHART_SUFFIX)" EPP_RELEASE_IMAGE_REPOSITORY="$(EPP_RELEASE_IMAGE_REPOSITORY)" LATENCY_PREDICTOR_TAG="$(LATENCY_PREDICTOR_TAG)" YQ="$(YQ)" HELM="$(HELM)" ./hack/push-chart.shAs per coding guidelines, " 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
|
|
||
| .PHONY: helm-push-gateway | ||
| helm-push-gateway: ## Package and push the llm-d-router-gateway Helm chart. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release template instructs external LLM use on unreleased notes, creating data-exposure risk (CWE-200).
This workflow can disclose embargoed/security-sensitive release content to third-party services before publication.
Patch
As per coding guidelines, "
**/.github/**: ... controls CI/CD, code review ownership, and repository behavior. Changes here have outsized security impact."🤖 Prompt for AI Agents
Source: Coding guidelines