forked from llm-d/llm-d-router
-
Notifications
You must be signed in to change notification settings - Fork 11
[sync] upstream llm-d/llm-d-router f7e88524 [2026-06-22] #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zdtsw
wants to merge
10
commits into
opendatahub-io:main
Choose a base branch
from
zdtsw-forking:sync/upstream-f7e88524
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bdbf7cb
fix(sidecar): inject W3C trace context on outbound proxy requests (#1…
gyliu513 7bfe4af
Add operations.md guide for right sizing EPP container resources (#1616)
jtechapps 48b7dff
deps(go): bump llm-d-kv-cache to v0.9.0 (#1691)
vMaroon 4c16a44
fix(sidecar): allowlist selector parsing for GA InferencePool API (#1…
pierDipi b7a3875
fix(standalone): require modelServers.matchLabels when InferencePool …
Jwrede 2253a35
test: consolidate and rename e2e runner scripts (#1698)
roytman 26d7106
feat(standalone): align agentgateway configuration with upstream GAIE…
abhay1999 8b6f5fe
fix(scripts): support single quotes in owned image check (#1676)
weizhoublue f7e8852
fix(chart): update latency predictor image path to match subchart nes…
weizhoublue c085bd7
Sync upstream llm-d/llm-d-router f7e88524
zdtsw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 0 additions & 32 deletions
32
config/charts/llm-d-router-standalone/templates/agentgateway-service.yaml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require and validate
modelServers.matchLabels.appfor agentgateway backend naming (CWE-20).Line 21-Line 27 only enforces that
matchLabelsexists. In this PR, agentgateway backend identity is derived frommatchLabels.app; ifappis missing/invalid, routing can silently target the wrong backend name at runtime. Add a hard fail for missing/invalidmatchLabels.appwhenrouter.proxy.proxyType=agentgatewayandrouter.inferencePool.create=false.Proposed validation hardening
{{- if not $useInferencePool -}} {{- if or (empty .Values.router.modelServers) (not .Values.router.modelServers.matchLabels) -}} {{- fail ".Values.router.modelServers.matchLabels is required when .Values.router.inferencePool.create=false: standalone mode renders the EPP --endpoint-selector from matchLabels and cannot start with an empty selector" -}} {{- end -}} + {{- if eq ($proxy.proxyType | default "envoy") "agentgateway" -}} + {{- $appLabel := index (.Values.router.modelServers.matchLabels | default dict) "app" | default "" -}} + {{- if empty $appLabel -}} + {{- fail ".Values.router.modelServers.matchLabels.app is required when proxyType=agentgateway and inferencePool.create=false" -}} + {{- end -}} + {{- if or (gt (len $appLabel) 63) (not (regexMatch "^[a-z0-9]([-a-z0-9]*[a-z0-9])?$" $appLabel)) -}} + {{- fail ".Values.router.modelServers.matchLabels.app must be a DNS-1123 label for agentgateway backend naming" -}} + {{- end -}} + {{- end -}} {{- end -}}🤖 Prompt for AI Agents