Skip to content

Add MCP server icon support and switch to McpIcon#296

Merged
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:mcp-registry-prototypefrom
DaoDaoNoCode:add-mcp-icons
Jun 13, 2026
Merged

Add MCP server icon support and switch to McpIcon#296
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:mcp-registry-prototypefrom
DaoDaoNoCode:add-mcp-icons

Conversation

@DaoDaoNoCode

@DaoDaoNoCode DaoDaoNoCode commented Jun 12, 2026

Copy link
Copy Markdown
Member

Related Issues/PRs

Relates to RHOAIENG-62278

What changes are proposed in this pull request?

  • Add MCPServerIcon shared component that renders custom server icons from server.icons or server_json.icons, with fallback to the DS McpIcon
  • Icons are loaded via <img> with referrerPolicy="no-referrer" (prevents 403 from servers with strict referrer policies) and onError fallback
  • Add resolveIconSrc utility and useLatestMCPServerVersionQuery hook
  • Show server icons on card grid, list table, and version detail page
  • Add icons field to ServerJSONPayload type to match the upstream MCP server.json spec
  • Switch sidebar and registry page header from WrenchIcon to McpIcon
  • Update tests with QueryClientProvider wrapper for components using React Query hooks

Icon fallback chain:

  • Card/List table: server.iconslatestVersion.server_json.iconsMcpIcon
  • Version detail: version.server_json.iconsserver.iconsMcpIcon

Dark mode support: SVG icons with embedded prefers-color-scheme CSS work automatically. Use URLs like https://cdn.simpleicons.org/github/black/white for auto light/dark switching.

Screen.Recording.2026-06-12.at.5.45.24.PM.mov

How is this PR tested?

  • Existing unit/integration tests
  • Manual tests

142 tests across 13 suites, all passing.

Does this PR require documentation update?

  • No.

Does this PR require updating the MLflow Skills repository?

  • No.

Release Notes

Is this a user-facing change?

  • Yes. MCP server cards, list table, and version detail now show custom server icons from the server.json spec.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server

How should the PR be classified in the release notes? Choose one:

  • rn/feature - A new user-facing feature worth mentioning in the release notes

Is this PR a critical bugfix or security fix that should go into the next patch release?

  • This PR is critical and needs to be in the next patch release
  • This PR can wait for the next minor release

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • master
  • incubation
  • rhoai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fd264dbd-3396-498f-8d9c-91b18798b6ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/M Pull request size: M label Jun 12, 2026
@DaoDaoNoCode DaoDaoNoCode added the rn/none Skip the validate-labeled CI job on the feature branches label Jun 12, 2026

@nananosirova nananosirova left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!
/lgtm

@openshift-ci

openshift-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

- Add MCPServerIcon shared component with img fallback to McpIcon,
  referrerPolicy="no-referrer" for cross-origin icons, and onError
  fallback handling
- Add resolveIconSrc utility and useLatestMCPServerVersionQuery hook
- Show server icons on card grid, list table, and version detail page
  with fallback chain: server.icons → latestVersion.server_json.icons
  → McpIcon
- Add icons field to ServerJSONPayload type
- Switch sidebar and registry page header from WrenchIcon to McpIcon
- Update tests with QueryClientProvider for components using React
  Query hooks

Signed-off-by: Juntao Wang <juntwang@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: nananosirova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit b423569 into opendatahub-io:mcp-registry-prototype Jun 13, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm rn/none Skip the validate-labeled CI job on the feature branches size/M Pull request size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants