Add MCP server icon support and switch to McpIcon#296
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fa04a4d to
a283630
Compare
|
New changes are detected. LGTM label has been removed. |
- Add MCPServerIcon shared component with img fallback to McpIcon, referrerPolicy="no-referrer" for cross-origin icons, and onError fallback handling - Add resolveIconSrc utility and useLatestMCPServerVersionQuery hook - Show server icons on card grid, list table, and version detail page with fallback chain: server.icons → latestVersion.server_json.icons → McpIcon - Add icons field to ServerJSONPayload type - Switch sidebar and registry page header from WrenchIcon to McpIcon - Update tests with QueryClientProvider for components using React Query hooks Signed-off-by: Juntao Wang <juntwang@redhat.com>
a283630 to
03b5f7a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: nananosirova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
b423569
into
opendatahub-io:mcp-registry-prototype
Related Issues/PRs
Relates to RHOAIENG-62278
What changes are proposed in this pull request?
MCPServerIconshared component that renders custom server icons fromserver.iconsorserver_json.icons, with fallback to the DSMcpIcon<img>withreferrerPolicy="no-referrer"(prevents 403 from servers with strict referrer policies) andonErrorfallbackresolveIconSrcutility anduseLatestMCPServerVersionQueryhookiconsfield toServerJSONPayloadtype to match the upstream MCP server.json specWrenchIcontoMcpIconQueryClientProviderwrapper for components using React Query hooksIcon fallback chain:
server.icons→latestVersion.server_json.icons→McpIconversion.server_json.icons→server.icons→McpIconDark mode support: SVG icons with embedded
prefers-color-schemeCSS work automatically. Use URLs likehttps://cdn.simpleicons.org/github/black/whitefor auto light/dark switching.Screen.Recording.2026-06-12.at.5.45.24.PM.mov
How is this PR tested?
142 tests across 13 suites, all passing.
Does this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverHow should the PR be classified in the release notes? Choose one:
rn/feature- A new user-facing feature worth mentioning in the release notesIs this PR a critical bugfix or security fix that should go into the next patch release?