Skip to content

Remove unused buildarg in Dockerfile#319

Open
mprahl wants to merge 1 commit into
opendatahub-io:masterfrom
mprahl:remove-build-arg
Open

Remove unused buildarg in Dockerfile#319
mprahl wants to merge 1 commit into
opendatahub-io:masterfrom
mprahl:remove-build-arg

Conversation

@mprahl

@mprahl mprahl commented Jun 25, 2026

Copy link
Copy Markdown

Summary

Resolves:
https://redhat.atlassian.net/browse/RHOAIENG-68281

Upstream / Downstream Impact

  • Downstream-only change for opendatahub-io/mlflow
  • Also affects upstream mlflow/mlflow
  • No upstream impact / not applicable

If relevant, add any upstream issue or follow-up link here:

Testing

  • CI
  • Unit tests
  • Manual testing
  • Not run (explain why)

Testing details:

Summary by CodeRabbit

  • Chores
    • Streamlined the container build configuration by removing an unused version setting. No user-facing behavior changes are expected.

@openshift-ci openshift-ci Bot requested a review from Gkrumbach07 June 25, 2026 20:22
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nananosirova for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested a review from HumairAK June 25, 2026 20:22
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c98a9553-197b-4e3e-ae76-dc419cb79e47

📥 Commits

Reviewing files that changed from the base of the PR and between 7731347 and 008d149.

📒 Files selected for processing (1)
  • Dockerfile.konflux
💤 Files with no reviewable changes (1)
  • Dockerfile.konflux

📝 Walkthrough

Walkthrough

Dockerfile.konflux removes the ARG MLFLOW_VERSION=3.3.2 declaration between the python-builder and runtime stages. The runtime ENV block now follows the ubi-minimal stage declaration directly. Configuration-only change (CWE-16).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change: it says the unused Docker build argument was removed.
Description check ✅ Passed All required sections are present: summary, impact, and testing, with an issue link and CI marked.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Contribution Quality And Spam Detection ✅ Passed One-file Docker build-arg cleanup, using the repo's standard PR template and linked Jira; no security-theater/code-quality combo, so it doesn't meet the 2-signal threshold.
No Hardcoded Secrets ✅ Passed Only deletion of ARG MLFLOW_VERSION in Dockerfile.konflux; no hardcoded secrets, credentials, tokens, or secret-like literals found (no CWE-798/CWE-321 issue).
No Weak Cryptography ✅ Passed PASS: Dockerfile.konflux only drops ARG MLFLOW_VERSION; no banned primitives, custom crypto, or secret comparisons found (CWE-327/CWE-208).
No Injection Vectors ✅ Passed No CWE-78/79/89/94/502 patterns were added; the change only removes ARG MLFLOW_VERSION from Dockerfile.konflux.
No Privileged Containers ✅ Passed PASS: Only ARG MLFLOW_VERSION was removed; no privileged flags/caps were added, and the runtime stage stays USER 1001.
No Sensitive Data In Logs ✅ Passed PASS: Dockerfile.konflux has no logging statements or data-dumping paths; no CWE-532/CWE-209 exposure is introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/XS Pull request size: XS label Jun 25, 2026
Resolves:
https://redhat.atlassian.net/browse/RHOAIENG-68281

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl mprahl force-pushed the remove-build-arg branch from 7731347 to 008d149 Compare June 25, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Pull request size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant