sync: main to stable#1710
Merged
Merged
Conversation
…#2475) * fix(catalog): enable independent scrolling for filter panel Makes the filter panel in Model Catalog scroll independently from the content area, preventing users from losing their filtering context when scrolling through models. The filter panel now uses sticky positioning with its own scroll container, matching the original design intent where filters remain accessible while browsing model results. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> * Use PatternFly variant="sticky" instead of custom positioning Address review feedback to use PatternFly's native sticky variant instead of custom CSS positioning, following PF best practices. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> * Prevent scrollbar from consuming sidebar width Add scrollbar-gutter: stable to reserve space for the scrollbar, preventing layout shift and content cutoff when the scrollbar appears. This maintains constant sidebar width regardless of scroll state. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> * Add padding to prevent content cutoff by scrollbar Adds padding-right to filter content to ensure borders and content are not clipped by the scrollbar. This maintains proper spacing between filter components and the scrollbar edge. Removed scrollbar-gutter approach in favor of content padding, which provides better visual consistency. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> * Remove fixed minWidth from performance toggle card The 280px minWidth was causing the card to overflow the sidebar width when the scrollbar was present. Removing the constraint allows the card to naturally fit within the sidebar and respect container width limits. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> * Increase sidebar width to prevent text wrapping Set SidebarPanel width to 300px to ensure the "Model performance view" toggle text doesn't wrap, keeping the layout closer to the design while maintaining a reasonable sidebar width. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> * Fix TypeScript error: use inline style for sidebar width PatternFly's width prop only accepts percentage values (width_25, width_33, etc.), not pixel values. Using inline style to set a fixed 300px width instead. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> * fix text wrapping issues for performance toggle Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> --------- Signed-off-by: Manaswini Das <dasmanaswini10@gmail.com> Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
|
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
github-actions
Bot
added
Area/Jobs/Sync-stable
Member
|
/retest |
…m-gen (kubeflow#2605) Bumps [github.com/jackc/pgx/v5](https://github.com/jackc/pgx) from 5.5.5 to 5.9.0. - [Changelog](https://github.com/jackc/pgx/blob/master/CHANGELOG.md) - [Commits](jackc/pgx@v5.5.5...v5.9.0) --- updated-dependencies: - dependency-name: github.com/jackc/pgx/v5 dependency-version: 5.9.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@53b8394...48b55a0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…w#2609) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.1 to 4.35.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](github/codeql-action@v4.35.1...v4.35.2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.35.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ow#2612) Bumps [github.com/jackc/pgx/v5](https://github.com/jackc/pgx) from 5.9.1 to 5.9.2. - [Changelog](https://github.com/jackc/pgx/blob/master/CHANGELOG.md) - [Commits](jackc/pgx@v5.9.1...v5.9.2) --- updated-dependencies: - dependency-name: github.com/jackc/pgx/v5 dependency-version: 5.9.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2613) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.35.3 to 0.35.4. - [Commits](kubernetes/apimachinery@v0.35.3...v0.35.4) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.35.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: create a script to make the make target cleaner Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com> Co-Authored-By: Claude <noreply@anthropic.com> * fix: address review comments Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com> * fix: mismatch in naming the make targets Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com> --------- Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable #1710 +/- ##
==========================================
+ Coverage 42.04% 42.05% +0.01%
==========================================
Files 186 186
Lines 23169 23169
Branches 261 261
==========================================
+ Hits 9741 9744 +3
+ Misses 12639 12637 -2
+ Partials 789 788 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kubeflow#2623) Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
[pull] main from kubeflow:main
Member
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: github-actions[bot], jonburdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/ok-to-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync-branches: New code has just landed in main, so let's bring stable up to speed!