Skip to content

[pull] main from kubeflow:main#759

Merged
openshift-merge-bot[bot] merged 6 commits intoopendatahub-io:mainfrom
kubeflow:main
Dec 5, 2025
Merged

[pull] main from kubeflow:main#759
openshift-merge-bot[bot] merged 6 commits intoopendatahub-io:mainfrom
kubeflow:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Dec 5, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

pboyd and others added 2 commits December 4, 2025 20:55
* feat(catalog): Add performance artifacts endpoint with Pareto filtering

Implements new GET /api/model_catalog/v1alpha1/sources/{source_id}/models/{model_name}/artifacts/performance
endpoint that returns performance metrics artifacts, optionally filtered for Pareto-optimal configurations.

Key changes:
- Add getAllModelPerformanceArtifacts OpenAPI operation and handler
- Support targetRPS and recommendations query parameters for filtering
- Calculate replicas and total_requests_per_second based on targetRPS
- Add database models and service layer for performance artifacts

Signed-off-by: Paul Boyd <paul@pboyd.io>

* fix(catalog): performance metrics edge case

If two performance metrics artifacts have the same latency and cost,
prefer the one with the lower hardware count.

Signed-off-by: Paul Boyd <paul@pboyd.io>

---------

Signed-off-by: Paul Boyd <paul@pboyd.io>
* Created Vards wrap between sections in Model overview page

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>

* addressed nit

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>

---------

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
lugi0 and others added 2 commits December 5, 2025 15:42
…operties (#1961)

* feat: load size, tensor type and variant group ID from metadata as customProperties

Signed-off-by: lugi0 <lgiorgi@redhat.com>

* fix: two tests shoudl expect error

Signed-off-by: lugi0 <lgiorgi@redhat.com>

---------

Signed-off-by: lugi0 <lgiorgi@redhat.com>
)

* chore(catalog): Don't deploy demo data by default

Move the demo data to an overlay, leaving the base empty. Tilt still
deploys the demo data by default.

Also splitting the performance data into ndjson files to help with
testing the performance metrics loading code.

The istio manifests were taking the "overlay" name, so I'm moving them
out of the way (into `options/istio`).

Signed-off-by: Paul Boyd <paul@pboyd.io>

* chore(catalog): support local manifests in tilt

If someone defines "local" overlay manifests for the catalog, use it.

Signed-off-by: Paul Boyd <paul@pboyd.io>

---------

Signed-off-by: Paul Boyd <paul@pboyd.io>
Always return items from the sources endpoint, even if it's an empty
list.

Signed-off-by: Paul Boyd <paul@pboyd.io>
Copy link
Copy Markdown

@adysenrothman adysenrothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

* feat: add preview endpoint in model catalog

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: improve openapi spec on preview endpoint

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: make builds work with mock function

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: implement preview logic for yaml sources

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: remove unused fields from the openapi schema

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: sync gitattributes file

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: models can be passed to the preview endpoint

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* chore: improve doc and errors

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: panic when using pageSize < 1

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: add support to preview hugging face sources

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: add hf maxModels safeguard

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: ignore url properties in sources to guard on SSRF attacks

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: let users use a full source in preview

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: log when an user tries to use a custom url for hf

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: catalog unit tests

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

---------

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@openshift-ci openshift-ci Bot removed the lgtm label Dec 5, 2025
@adysenrothman
Copy link
Copy Markdown

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Dec 5, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit ca7a312 into opendatahub-io:main Dec 5, 2025
25 of 28 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants