Skip to content

sync: main to stable#764

Merged
adysenrothman merged 11 commits intostablefrom
main
Dec 9, 2025
Merged

sync: main to stable#764
adysenrothman merged 11 commits intostablefrom
main

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot commented Dec 5, 2025

sync-branches: New code has just landed in main, so let's bring stable up to speed!

pboyd and others added 7 commits December 4, 2025 20:55
* feat(catalog): Add performance artifacts endpoint with Pareto filtering

Implements new GET /api/model_catalog/v1alpha1/sources/{source_id}/models/{model_name}/artifacts/performance
endpoint that returns performance metrics artifacts, optionally filtered for Pareto-optimal configurations.

Key changes:
- Add getAllModelPerformanceArtifacts OpenAPI operation and handler
- Support targetRPS and recommendations query parameters for filtering
- Calculate replicas and total_requests_per_second based on targetRPS
- Add database models and service layer for performance artifacts

Signed-off-by: Paul Boyd <paul@pboyd.io>

* fix(catalog): performance metrics edge case

If two performance metrics artifacts have the same latency and cost,
prefer the one with the lower hardware count.

Signed-off-by: Paul Boyd <paul@pboyd.io>

---------

Signed-off-by: Paul Boyd <paul@pboyd.io>
…1959)

* Created Vards wrap between sections in Model overview page

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>

* addressed nit

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>

---------

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
…operties (kubeflow#1961)

* feat: load size, tensor type and variant group ID from metadata as customProperties

Signed-off-by: lugi0 <lgiorgi@redhat.com>

* fix: two tests shoudl expect error

Signed-off-by: lugi0 <lgiorgi@redhat.com>

---------

Signed-off-by: lugi0 <lgiorgi@redhat.com>
…beflow#1955)

* chore(catalog): Don't deploy demo data by default

Move the demo data to an overlay, leaving the base empty. Tilt still
deploys the demo data by default.

Also splitting the performance data into ndjson files to help with
testing the performance metrics loading code.

The istio manifests were taking the "overlay" name, so I'm moving them
out of the way (into `options/istio`).

Signed-off-by: Paul Boyd <paul@pboyd.io>

* chore(catalog): support local manifests in tilt

If someone defines "local" overlay manifests for the catalog, use it.

Signed-off-by: Paul Boyd <paul@pboyd.io>

---------

Signed-off-by: Paul Boyd <paul@pboyd.io>
Always return items from the sources endpoint, even if it's an empty
list.

Signed-off-by: Paul Boyd <paul@pboyd.io>
* feat: add preview endpoint in model catalog

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: improve openapi spec on preview endpoint

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: make builds work with mock function

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: implement preview logic for yaml sources

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: remove unused fields from the openapi schema

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: sync gitattributes file

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: models can be passed to the preview endpoint

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* chore: improve doc and errors

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: panic when using pageSize < 1

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: add support to preview hugging face sources

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: add hf maxModels safeguard

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: ignore url properties in sources to guard on SSRF attacks

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: let users use a full source in preview

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* feat: log when an user tries to use a custom url for hf

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix: catalog unit tests

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

---------

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
[pull] main from kubeflow:main
@openshift-ci openshift-ci Bot requested review from rareddy and tarilabs December 5, 2025 19:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 5, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 5, 2025

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

manaswinidas and others added 4 commits December 8, 2025 15:13
…eflow#1975)

Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
…ubeflow#1976)

Implements - Sources endpoint should return all sources regardless of the enabled field's value

🤖 Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Chris Hambridge <chambrid@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Adysen Rothman <85646824+adysenrothman@users.noreply.github.com>
[pull] main from kubeflow:main
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 55.74163% with 370 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.95%. Comparing base (5d22fa7) to head (a76d8c5).
⚠️ Report is 20 commits behind head on stable.

Files with missing lines Patch % Lines
...ternal/server/openapi/api_model_catalog_service.go 43.11% 80 Missing and 15 partials ⚠️
...erver/openapi/api_model_catalog_service_service.go 22.44% 74 Missing and 2 partials ⚠️
catalog/internal/catalog/hf_catalog.go 67.28% 39 Missing and 14 partials ⚠️
...internal/db/models/performance_artifact_service.go 77.61% 29 Missing and 18 partials ⚠️
catalog/internal/server/openapi/type_asserts.go 0.00% 45 Missing ⚠️
catalog/internal/catalog/performance_metrics.go 0.00% 34 Missing ⚠️
catalog/internal/catalog/db_catalog.go 81.39% 4 Missing and 4 partials ⚠️
catalog/internal/catalog/preview.go 88.23% 5 Missing and 3 partials ⚠️
catalog/internal/server/openapi/error.go 0.00% 1 Missing and 1 partial ⚠️
internal/server/openapi/error.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           stable     #764      +/-   ##
==========================================
+ Coverage   39.56%   40.95%   +1.39%     
==========================================
  Files         150      152       +2     
  Lines       18185    19013     +828     
  Branches      162      162              
==========================================
+ Hits         7195     7787     +592     
- Misses      10424    10590     +166     
- Partials      566      636      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@adysenrothman adysenrothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
keep 1891
keep 1959
keep 1961
keep 1955
keep 1957
keep 1918
keep 759
keep 1975
keep 1976
keep 1963
keep 801

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adysenrothman, github-actions[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Dec 9, 2025
@adysenrothman adysenrothman merged commit 964460a into stable Dec 9, 2025
57 of 62 checks passed
npanpaliya pushed a commit to odh-on-pz/model-registry that referenced this pull request Dec 22, 2025
…io#764)

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants