Skip to content

Added OWNERS file#100

Merged
israel-hdez merged 1 commit intoopendatahub-io:mainfrom
chaitanya1731:maas-api-dev
Sep 25, 2025
Merged

Added OWNERS file#100
israel-hdez merged 1 commit intoopendatahub-io:mainfrom
chaitanya1731:maas-api-dev

Conversation

@chaitanya1731
Copy link
Copy Markdown
Collaborator

@chaitanya1731 chaitanya1731 commented Sep 24, 2025

Description

Added OWNERS File

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Added repository ownership and review configuration listing designated approvers and reviewers to streamline reviews.
    • Added an automated build-and-publish workflow to build and push the service Docker image when pull requests are merged into main.
    • Governance/CI changes only: no direct user-facing functionality or behavior changes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 24, 2025

Walkthrough

Adds an OWNERS file listing approvers and reviewers (same ten users, slight ordering difference) and introduces a new GitHub Actions workflow maas-api-build.yml that builds and pushes the maas-api Docker image when a pull request is merged into main. No source-code or public API changes.

Changes

Cohort / File(s) Summary
Repository ownership config
OWNERS
Adds a static YAML ownership file with approvers and reviewers lists (10 users each, identical membership with minor ordering differences). File has no trailing newline.
CI workflow: build & push image
.github/workflows/maas-api-build.yml
Adds a GitHub Actions workflow triggered on pull request close when merged into main; runs on ubuntu-24.04, checks out code, sets up Go (from go.mod), logs into quay.io using repo secrets, and runs a Make target to build and push the maas-api Docker image to quay.io/chkulkar/maas-api.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant PR as GitHub PR
  participant GH as GitHub Actions
  participant Repo as Repository
  participant Go as Setup Go
  participant Quay as quay.io
  participant Make as Make (build/push)

  Note over PR,GH: Trigger: PR closed & merged into main
  PR->>GH: on: pull_request (types: [closed]) && merged && base==main
  GH->>Repo: actions/checkout
  GH->>Go: setup-go (version from go.mod)
  GH->>Quay: docker/login (using secrets)
  GH->>Make: make image-push (build + push to quay.io/chkulkar/maas-api)
  Make->>Quay: push image
  Note right of GH: Job completes (success/fail)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I nibble names in tidy rows,
Ten friends listed where the wind blows.
A workflow hums to build and steer,
Images pushed when merges clear.
Hop—approve, the pipeline’s near 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change introduced by this pull request—adding a new OWNERS file—using concise and clear phrasing that directly reflects the developer’s intent without unnecessary detail or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! Added rest of the contributors as commitable suggestions.

@israel-hdez should we align this with https://github.com/opendatahub-io/kserve/blob/master/OWNERS?

Comment thread OWNERS
Comment thread OWNERS Outdated
Signed-off-by: Chaitanya Kulkarni <chkulkar@redhat.com>
@israel-hdez
Copy link
Copy Markdown
Collaborator

@israel-hdez should we align this with https://github.com/opendatahub-io/kserve/blob/master/OWNERS?

@bartoszmajsak Yes. Although current list is fine for the time being.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83b1a84 and be44b65.

📒 Files selected for processing (2)
  • .github/workflows/maas-api-build.yml (1 hunks)
  • OWNERS (1 hunks)
🔇 Additional comments (1)
OWNERS (1)

1-22: OWNERS list looks good.

Approvers and reviewers are aligned and clearly declared for the repo.

Comment thread .github/workflows/maas-api-build.yml Outdated
@israel-hdez israel-hdez merged commit 100fbdf into opendatahub-io:main Sep 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants