Conversation
WalkthroughAdds an Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant PR as GitHub PR
participant GH as GitHub Actions
participant Repo as Repository
participant Go as Setup Go
participant Quay as quay.io
participant Make as Make (build/push)
Note over PR,GH: Trigger: PR closed & merged into main
PR->>GH: on: pull_request (types: [closed]) && merged && base==main
GH->>Repo: actions/checkout
GH->>Go: setup-go (version from go.mod)
GH->>Quay: docker/login (using secrets)
GH->>Make: make image-push (build + push to quay.io/chkulkar/maas-api)
Make->>Quay: push image
Note right of GH: Job completes (success/fail)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Thanks for taking care of this! Added rest of the contributors as commitable suggestions.
@israel-hdez should we align this with https://github.com/opendatahub-io/kserve/blob/master/OWNERS?
b3a2ff3 to
83b1a84
Compare
Signed-off-by: Chaitanya Kulkarni <chkulkar@redhat.com>
347fa01 to
be44b65
Compare
@bartoszmajsak Yes. Although current list is fine for the time being. |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/maas-api-build.yml(1 hunks)OWNERS(1 hunks)
🔇 Additional comments (1)
OWNERS (1)
1-22: OWNERS list looks good.Approvers and reviewers are aligned and clearly declared for the repo.
be44b65 to
0d2c345
Compare
Description
Added OWNERS File
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit