Skip to content

chore(kustomize): removes Kubernetes overlay#122

Merged
bartoszmajsak merged 1 commit intoopendatahub-io:mainfrom
bartoszmajsak:deployment/chore/kubernetes-overlay
Oct 2, 2025
Merged

chore(kustomize): removes Kubernetes overlay#122
bartoszmajsak merged 1 commit intoopendatahub-io:mainfrom
bartoszmajsak:deployment/chore/kubernetes-overlay

Conversation

@bartoszmajsak
Copy link
Copy Markdown
Collaborator

@bartoszmajsak bartoszmajsak commented Oct 2, 2025 •
edited by coderabbitai bot
Loading

Follow-up to #95 (comment)

Summary by CodeRabbit

  • Documentation
    • Deployment guide streamlined to focus on OpenShift; Kubernetes and internal overlay guidance removed and examples replaced with OpenShift-centric instructions.
  • Chores
    • Kubernetes deployment overlays and external HTTP ingress examples removed; packaged manifests now target OpenShift only.
    • Users on vanilla Kubernetes should maintain their own overlays/configurations; existing OpenShift workflows remain unchanged.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 2, 2025 •
edited
Loading

Walkthrough

Removed the Kubernetes overlay and its ingress resources; README was simplified to focus only on OpenShift deployment. No code, APIs, or exported entities were added or modified.

Changes

Cohort / File(s) Summary
Docs: OpenShift-centric overlays README
deployment/overlays/README.md		 Removed Kubernetes and internal-only guidance; retained only the OpenShift deployment snippet and context.
Kubernetes overlay removed
deployment/overlays/kubernetes/ingress.yaml, deployment/overlays/kubernetes/kustomization.yaml		 Deleted three Kubernetes Ingress resources and the kustomization overlay that aggregated base resources, ingress, and sample models.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws on shifting ground,
No clouds of Kube now swirl around—
OpenShift stays, the rest slipped free,
Fewer paths for rabbit me.
I hop—deployment light and keen. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately and concisely summarizes the primary change of removing the Kubernetes overlay configuration using kustomize and follows conventional commit style without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0240a35 and 8943ef5.

📒 Files selected for processing (3)
  • deployment/overlays/README.md (0 hunks)
  • deployment/overlays/kubernetes/ingress.yaml (0 hunks)
  • deployment/overlays/kubernetes/kustomization.yaml (0 hunks)
💤 Files with no reviewable changes (3)
  • deployment/overlays/kubernetes/kustomization.yaml
  • deployment/overlays/README.md
  • deployment/overlays/kubernetes/ingress.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jland-redhat
jland-redhat approved these changes Oct 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jland-redhat jland-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nerdalert
nerdalert approved these changes Oct 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoszmajsak
chore(kustomize): removes Kubernetes overlay
8943ef5 
Follow-up to opendatahub-io#95 (comment)

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>

; Conflicts:
;	deployment/overlays/kubernetes/kustomization.yaml

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
@bartoszmajsak bartoszmajsak force-pushed the deployment/chore/kubernetes-overlay branch from 0240a35 to 8943ef5 Compare October 2, 2025 14:27
dmytro-zaharnytskyi
dmytro-zaharnytskyi approved these changes Oct 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dmytro-zaharnytskyi dmytro-zaharnytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye, kuber (but not forever @_@)

@bartoszmajsak bartoszmajsak merged commit 9a57784 into opendatahub-io:main Oct 2, 2025
2 checks passed
@bartoszmajsak bartoszmajsak deleted the deployment/chore/kubernetes-overlay branch October 2, 2025 15:02
SB159 pushed a commit to SB159/maas-billing that referenced this pull request Oct 15, 2025
@bartoszmajsak @SB159
chore(kustomize): removes Kubernetes overlay (opendatahub-io#122)
f131aaf 
Follow-up to opendatahub-io#95 (comment)

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nerdalert nerdalert nerdalert approved these changes

@jland-redhat jland-redhat jland-redhat approved these changes

@dmytro-zaharnytskyi dmytro-zaharnytskyi dmytro-zaharnytskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bartoszmajsak @nerdalert @jland-redhat @dmytro-zaharnytskyi