Skip to content

fix: TokenRateLimitPolicy targets right gateway#126

Merged
bartoszmajsak merged 1 commit intoopendatahub-io:mainfrom
bartoszmajsak:deployment/fix/gateway
Oct 2, 2025
Merged

fix: TokenRateLimitPolicy targets right gateway#126
bartoszmajsak merged 1 commit intoopendatahub-io:mainfrom
bartoszmajsak:deployment/fix/gateway

Conversation

@bartoszmajsak
Copy link
Copy Markdown
Collaborator

@bartoszmajsak bartoszmajsak commented Oct 2, 2025

Fix for #123

Summary by CodeRabbit

  • Chores
    • Updated rate-limiting configuration to point to the current inference gateway.
    • No changes to rate limits, predicates, counters, or control flow.
    • Error handling and monitoring remain unchanged.
    • No user-facing impact expected; behavior and performance should be identical.
    • Applies automatically after deployment with no action required.
    • Compatibility with existing clients preserved.

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

Updated the TokenRateLimitPolicy targetRef name in deployment/base/policies/token-limit-policy.yaml from "inference-gateway" to "openshift-ai-inference". No other fields or logic were changed.

Changes

Cohort / File(s) Summary
Policy target update
deployment/base/policies/token-limit-policy.yaml
Changed spec.targetRef.name from "inference-gateway" to "openshift-ai-inference"; all limits, predicates, and counters unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my whiskers at a tiny tweak,
A gateway’s name—precise, unique.
Tokens march to a different door,
Same rules, same steps, as once before.
Hop hop! configs align,
Carrots counted, limits fine. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title directly describes the core change—updating the TokenRateLimitPolicy to point at the correct gateway—using concise and specific language that aligns with the single-file modification in the PR without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6e0217 and ee2dc8e.

📒 Files selected for processing (1)
  • deployment/base/policies/token-limit-policy.yaml (1 hunks)
🔇 Additional comments (1)
deployment/base/policies/token-limit-policy.yaml (1)

11-15: Target reference update looks correct.

Pointing the policy at openshift-ai-inference aligns with the intended gateway without affecting existing limits or predicates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@bartoszmajsak
Copy link
Copy Markdown
Collaborator Author

LGTM, ty!

@nerdalert guilty as charged! :)

@bartoszmajsak bartoszmajsak merged commit 8becc8a into opendatahub-io:main Oct 2, 2025
2 checks passed
@bartoszmajsak bartoszmajsak deleted the deployment/fix/gateway branch October 2, 2025 14:27
SB159 pushed a commit to SB159/maas-billing that referenced this pull request Oct 15, 2025
Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants