Conversation
moved to: https://github.com/orgs/redhat-et/packages/container/package/maas-key-manager Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
WalkthroughUpdated the key-manager deployment to use a different container image repository and tag, switching from ghcr.io/nerdalert/maas-key-manager:teams to ghcr.io/redhat-et/maas-key-manager:latest. No other deployment fields were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml (1)
55-55: Avoid running with GIN_MODE=debug in non-dev clusters.If this Deployment targets shared/production namespaces, switch to
releaseto reduce verbose logs and disable debug behaviors.- - name: GIN_MODE - value: "debug" + - name: GIN_MODE + value: "release"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml(1 hunks)
🔇 Additional comments (2)
deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml (2)
28-28: Sanity-check new key-manager image compatibility
- Verify that
ghcr.io/redhat-et/maas-key-manager:lateststill:
- exposes port 8080 and responds to
/healthfor liveness/readiness- honors env vars:
KEY_NAMESPACE,SECRET_SELECTOR_*,CREATE_DEFAULT_TEAM,TOKEN_RATE_LIMIT_POLICY_NAME,AUTH_POLICY_NAME,ADMIN_API_KEY- After rollout, run in-cluster checks:
oc -n platform-services get deploy/key-manager -ojson | jq '.spec.template.spec.containers[0].image' oc -n platform-services run kmgr-tester --rm -it --image=curlimages/curl --restart=Never -- \ curl -sS key-manager.platform-services.svc.cluster.local/health
28-28: Ensure GitHub Container Registry pull secret is configuredVerify that the
key-managerServiceAccount (or the PodSpec in deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml at line 28) includes a validimagePullSecretsentry forghcr.io/redhat-et. Without this, pods will remain in ImagePullBackOff.
| image: ghcr.io/redhat-et/maas-key-manager:latest | ||
| imagePullPolicy: Always |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Pin the image to a digest instead of using :latest for reproducibility and supply-chain safety.
Unpinned latest can drift and pull unintended builds. Pin to a SHA256 digest (or at least a versioned tag) and optionally relax imagePullPolicy once pinned.
- image: ghcr.io/redhat-et/maas-key-manager:latest
- imagePullPolicy: Always
+ image: ghcr.io/redhat-et/maas-key-manager@sha256:<IMMU_TABLE_DIGEST>
+ imagePullPolicy: IfNotPresentIf you must track moving tags, consider a release tag (e.g., vX.Y.Z) plus an automated bump PR when new versions are cut.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| image: ghcr.io/redhat-et/maas-key-manager:latest | |
| imagePullPolicy: Always | |
| image: ghcr.io/redhat-et/maas-key-manager@sha256:<IMMU_TABLE_DIGEST> | |
| imagePullPolicy: IfNotPresent |
🤖 Prompt for AI Agents
In deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml
around lines 28-29, the container image is using the unpinned :latest tag which
can drift; replace it with a fixed image reference (either a versioned tag like
vX.Y.Z or preferably the image digest form
ghcr.io/redhat-et/maas-key-manager@sha256:<DIGEST>) and update imagePullPolicy
to a relaxed policy (e.g., IfNotPresent) once pinned; if you need moving
targets, use a stable release tag and plan automated bump PRs to update the
manifest.
|
lgtm |
moved to:
https://github.com/orgs/redhat-et/packages/container/package/maas-key-manager
Summary by CodeRabbit