Skip to content

move key manager repo#28

Merged
nerdalert merged 1 commit intoopendatahub-io:mainfrom
nerdalert:kmgr-image
Aug 28, 2025
Merged

move key manager repo#28
nerdalert merged 1 commit intoopendatahub-io:mainfrom
nerdalert:kmgr-image

Conversation

@nerdalert
Copy link
Copy Markdown
Member

@nerdalert nerdalert commented Aug 28, 2025

moved to:
https://github.com/orgs/redhat-et/packages/container/package/maas-key-manager

Summary by CodeRabbit

  • Chores
    • Updated the key-manager service to use a new container image (latest).
    • Deployment settings, including port 8080, health probes, resources, security context, and environment variables, remain unchanged.
    • No functional changes expected; existing APIs and integrations should continue to operate as before.
    • Startup and runtime behavior are consistent with previous versions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 28, 2025

Walkthrough

Updated the key-manager deployment to use a different container image repository and tag, switching from ghcr.io/nerdalert/maas-key-manager:teams to ghcr.io/redhat-et/maas-key-manager:latest. No other deployment fields were modified.

Changes

Cohort / File(s) Summary
Deployment image update
deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml
Switched container image from ghcr.io/nerdalert/maas-key-manager:teams to ghcr.io/redhat-et/maas-key-manager:latest; all other spec fields unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A hop, a swap, a tag set right,
From nerdy clouds to Red Hat light.
The pods will pull, the checks still sing,
Port eight-oh-eight—unchanged spring.
I thump my paws: deploy tonight! 🐇🚀

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml (1)

55-55: Avoid running with GIN_MODE=debug in non-dev clusters.

If this Deployment targets shared/production namespaces, switch to release to reduce verbose logs and disable debug behaviors.

-        - name: GIN_MODE
-          value: "debug"
+        - name: GIN_MODE
+          value: "release"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between df96e6e and ab2dfef.

📒 Files selected for processing (1)
  • deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml (1 hunks)
🔇 Additional comments (2)
deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml (2)

28-28: Sanity-check new key-manager image compatibility

  • Verify that ghcr.io/redhat-et/maas-key-manager:latest still:
    • exposes port 8080 and responds to /health for liveness/readiness
    • honors env vars: KEY_NAMESPACE, SECRET_SELECTOR_*, CREATE_DEFAULT_TEAM, TOKEN_RATE_LIMIT_POLICY_NAME, AUTH_POLICY_NAME, ADMIN_API_KEY
  • After rollout, run in-cluster checks:
    oc -n platform-services get deploy/key-manager -ojson | jq '.spec.template.spec.containers[0].image'
    oc -n platform-services run kmgr-tester --rm -it --image=curlimages/curl --restart=Never -- \
      curl -sS key-manager.platform-services.svc.cluster.local/health

28-28: Ensure GitHub Container Registry pull secret is configured

Verify that the key-manager ServiceAccount (or the PodSpec in deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml at line 28) includes a valid imagePullSecrets entry for ghcr.io/redhat-et. Without this, pods will remain in ImagePullBackOff.

Comment on lines +28 to 29
image: ghcr.io/redhat-et/maas-key-manager:latest
imagePullPolicy: Always
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Pin the image to a digest instead of using :latest for reproducibility and supply-chain safety.

Unpinned latest can drift and pull unintended builds. Pin to a SHA256 digest (or at least a versioned tag) and optionally relax imagePullPolicy once pinned.

-        image: ghcr.io/redhat-et/maas-key-manager:latest
-        imagePullPolicy: Always
+        image: ghcr.io/redhat-et/maas-key-manager@sha256:<IMMU_TABLE_DIGEST>
+        imagePullPolicy: IfNotPresent

If you must track moving tags, consider a release tag (e.g., vX.Y.Z) plus an automated bump PR when new versions are cut.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
image: ghcr.io/redhat-et/maas-key-manager:latest
imagePullPolicy: Always
image: ghcr.io/redhat-et/maas-key-manager@sha256:<IMMU_TABLE_DIGEST>
imagePullPolicy: IfNotPresent
🤖 Prompt for AI Agents
In deployment/kuadrant-openshift/key-manager/02-key-manager-deployment.yaml
around lines 28-29, the container image is using the unpinned :latest tag which
can drift; replace it with a fixed image reference (either a versioned tag like
vX.Y.Z or preferably the image digest form
ghcr.io/redhat-et/maas-key-manager@sha256:<DIGEST>) and update imagePullPolicy
to a relaxed policy (e.g., IfNotPresent) once pinned; if you need moving
targets, use a stable release tag and plan automated bump PRs to update the
manifest.

@usize
Copy link
Copy Markdown
Collaborator

usize commented Aug 28, 2025

lgtm

@nerdalert nerdalert merged commit 8d4dbac into opendatahub-io:main Aug 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants