Skip to content

ci: extend Konflux docs-only skip to match Prow skip rules#642

Merged
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:mainfrom
mynhardtburger:ci/extend-konflux-docs-only-skip
Mar 30, 2026
Merged

ci: extend Konflux docs-only skip to match Prow skip rules#642
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:mainfrom
mynhardtburger:ci/extend-konflux-docs-only-skip

Conversation

@mynhardtburger
Copy link
Copy Markdown
Contributor

@mynhardtburger mynhardtburger commented Mar 30, 2026

Extend the CEL expression in Tekton PipelineRun definitions to also skip Konflux builds when only .gitignore, OWNERS, PROJECT, LICENSE, .github/, or .tekton/ files are changed — matching the existing skip_if_only_changed regex used by the Prow ci-operator jobs.

An example of the existing prow ci-operator job skip condition:

skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE|CONTRIBUTING\.md)$|^\.github/|^\.tekton/

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated pull request pipeline triggering conditions to exclude additional configuration files and CI/CD directories from initiating automated checks.

Extend the CEL expression in Tekton PipelineRun definitions to also
skip Konflux builds when only .gitignore, OWNERS, PROJECT, LICENSE,
.github/, or .tekton/ files are changed — matching the existing
skip_if_only_changed regex used by the Prow ci-operator jobs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 30, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

Two Tekton Pipeline-as-Code configuration files updated to extend the CEL expression exclusion patterns for pull request triggers targeting the main branch. Previously excluded patterns (^docs/ and \.md$) are supplemented with additional exclusions for repository-level configuration files (.gitignore, OWNERS, PROJECT, LICENSE), .github/ directories, and .tekton/ directories. The predicate structure remains unchanged; only the regex list within files.all.all(...) is expanded across multiple lines.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: extending Konflux CI skip rules to match Prow behavior by excluding additional file patterns from triggering builds.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mynhardtburger mynhardtburger marked this pull request as ready for review March 30, 2026 16:17
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.tekton/odh-maas-controller-pull-request.yaml (1)

12-14: Keep CEL skip regex in exact parity with the referenced Prow rule.

CONTRIBUTING\.md is not explicitly listed in this grouped alternative, so parity with the documented Prow regex is already drifting. Add it here to keep both rule sets synchronized if \.md$ is ever narrowed.

Suggested diff
-      || x.matches('^(.*/)?(\\.gitignore|OWNERS|PROJECT|LICENSE)$')
+      || x.matches('^(.*/)?(\\.gitignore|OWNERS|PROJECT|LICENSE|CONTRIBUTING\\.md)$')
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.tekton/odh-maas-controller-pull-request.yaml around lines 12 - 14, The CEL
skip-regex in the files.all.all(...) condition is missing CONTRIBUTING\.md and
thus drifts from the referenced Prow rule; update the grouped alternative
'^(.*/)?(\\.gitignore|OWNERS|PROJECT|LICENSE)$' inside that regex (the
expression used in the files.all.all(...) check) to include CONTRIBUTING\.md
(e.g., add '|CONTRIBUTING\\.md' into the list) so the YAML rule stays in exact
parity with the documented Prow regex.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.tekton/odh-maas-controller-pull-request.yaml:
- Around line 12-14: The CEL skip-regex in the files.all.all(...) condition is
missing CONTRIBUTING\.md and thus drifts from the referenced Prow rule; update
the grouped alternative '^(.*/)?(\\.gitignore|OWNERS|PROJECT|LICENSE)$' inside
that regex (the expression used in the files.all.all(...) check) to include
CONTRIBUTING\.md (e.g., add '|CONTRIBUTING\\.md' into the list) so the YAML rule
stays in exact parity with the documented Prow regex.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 926d037d-31a4-4f60-bdbb-9ba39d78f543

📥 Commits

Reviewing files that changed from the base of the PR and between 0b67ec8 and 87ff826.

📒 Files selected for processing (2)
  • .tekton/odh-maas-api-pull-request.yaml
  • .tekton/odh-maas-controller-pull-request.yaml

@mynhardtburger mynhardtburger added the ready-for-review All changes are complete and CI checks have passed. label Mar 30, 2026
Copy link
Copy Markdown
Collaborator

@chaitanya1731 chaitanya1731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaitanya1731, mynhardtburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [chaitanya1731,mynhardtburger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 6b2d7e4 into opendatahub-io:main Mar 30, 2026
5 checks passed
@mynhardtburger mynhardtburger deleted the ci/extend-konflux-docs-only-skip branch March 31, 2026 01:14
somya-bhatnagar pushed a commit to somya-bhatnagar/models-as-a-service that referenced this pull request Mar 31, 2026
…ub-io#642)

Extend the CEL expression in Tekton PipelineRun definitions to also skip
Konflux builds when only `.gitignore`, `OWNERS`, `PROJECT`, `LICENSE`,
.`github/`, or `.tekton/` files are changed — matching the existing
skip_if_only_changed regex used by the Prow ci-operator jobs.


An example of the existing prow ci-operator job skip condition:
```yaml
skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE|CONTRIBUTING\.md)$|^\.github/|^\.tekton/
```
-
https://github.com/openshift/release/blob/01591970ea5008bda7b05a49ce8a0905207182ee/ci-operator/jobs/opendatahub-io/models-as-a-service/opendatahub-io-models-as-a-service-main-presubmits.yaml#L21

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

* **Chores**
* Updated pull request pipeline triggering conditions to exclude
additional configuration files and CI/CD directories from initiating
automated checks.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
somya-bhatnagar pushed a commit to somya-bhatnagar/models-as-a-service that referenced this pull request Mar 31, 2026
…ub-io#642)

Extend the CEL expression in Tekton PipelineRun definitions to also skip
Konflux builds when only `.gitignore`, `OWNERS`, `PROJECT`, `LICENSE`,
.`github/`, or `.tekton/` files are changed — matching the existing
skip_if_only_changed regex used by the Prow ci-operator jobs.

An example of the existing prow ci-operator job skip condition:
```yaml
skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE|CONTRIBUTING\.md)$|^\.github/|^\.tekton/
```
-
https://github.com/openshift/release/blob/01591970ea5008bda7b05a49ce8a0905207182ee/ci-operator/jobs/opendatahub-io/models-as-a-service/opendatahub-io-models-as-a-service-main-presubmits.yaml#L21

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

* **Chores**
* Updated pull request pipeline triggering conditions to exclude
additional configuration files and CI/CD directories from initiating
automated checks.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chaitanya1731 pushed a commit that referenced this pull request Apr 6, 2026
Extend the CEL expression in Tekton PipelineRun definitions to also skip
Konflux builds when only `.gitignore`, `OWNERS`, `PROJECT`, `LICENSE`,
.`github/`, or `.tekton/` files are changed — matching the existing
skip_if_only_changed regex used by the Prow ci-operator jobs.


An example of the existing prow ci-operator job skip condition:
```yaml
skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE|CONTRIBUTING\.md)$|^\.github/|^\.tekton/
```
-
https://github.com/openshift/release/blob/01591970ea5008bda7b05a49ce8a0905207182ee/ci-operator/jobs/opendatahub-io/models-as-a-service/opendatahub-io-models-as-a-service-main-presubmits.yaml#L21

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

* **Chores**
* Updated pull request pipeline triggering conditions to exclude
additional configuration files and CI/CD directories from initiating
automated checks.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
openshift-merge-bot Bot pushed a commit that referenced this pull request Apr 6, 2026
Automated promotion of **41 commit(s)** from `stable` to `rhoai`.

```
7df0b05 feat(deployment): support configurable cluster audience for AuthPolicy (#688)
1527654 docs: add testing guide for new contributors (#681)
45e8533 feat: add payload-processing as MaaS sub-component (#662)
53d7b27 chore(docs): document pre-requisites for observability stack (#677)
91b3a51 chore(deps): bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 in /maas-controller (#676)
a05deb5 chore(deps): bump github.com/go-jose/go-jose/v4 from 4.1.1 to 4.1.4 in /maas-api (#675)
a2cd0de docs: fix CRD reference mismatches and README default operator (#667)
dc82561 refactor: allow custom db connection in `deploy.sh` (#649)
2a424d5 fix: handle Forbidden error on namespace GET operation during startup (#668)
2878473 test: add additional GO test coverage in `maas-api/internal/api_keys` (#623)
841f96e fix: generate RBAC ClusterRole from kubebuilder markers (#665)
8cd9505 refactor(observability): migrate metric labels from tier to subscription (#508)
2962519 ci: remove multi-arch build platforms from odh tekton pipelineruns (#664)
50ec2a8 docs: add CVE fix guidance and automation workflow (#603)
7ba7216 fix: add when clauses to AuthPolicy fallbacks and remove redundant patch (#663)
7b73da4 test: improve maas-controller test coverage from 43.6% to 66.5% (#651)
2af4155 feat: add a usage dashboard (#624)
85d906f refactor: use Kustomize components for shared overlay configuration (#551)
d7f4495 fix: clean up Kuadrant/RHCL OLM resources before namespace deletion (#653)
d3b8012 docs: add missing ODH webhook wait command in platform-setup docs (#641)
416c93d feat: improve deploy and test script robustness (#650)
3d08353 fix: avoid maas-controller env value + valueFrom kustomize merge (#657)
1b86d12 ci: add maas-controller CI workflow and remove obsolete image build from maas-api (#656)
409b0a7 chore: automation for docs pre-release (#563)
d0dc95b docs: document TLS_SELF_SIGNED and TLS_MIN_VERSION env vars (#640)
1221310 feat: remove identity headers and simplify subscription info (#645)
152e531 chore: upgrade/validate Kuadrant 1.4.2 (#643)
d4a15d8 feat: require tokenRateLimits and remove tokenRateLimitRef for 3.4 (#644)
6b2d7e4 ci: extend Konflux docs-only skip to match Prow skip rules (#642)
291d215 docs: fix access probe response codes in model-listing-flow (#559)
```

---------

Signed-off-by: Dmytro Zaharnytskyi <zdmytro@redhat.com>
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
Signed-off-by: Wen Liang <liangwen12year@gmail.com>
Signed-off-by: Chaitanya Kulkarni <ckulkarn@redhat.com>
Signed-off-by: Chaitanya Kulkarni <chkulkar@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Tal Gitelman <tgitelma@redhat.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Dmytro Zaharnytskyi <zdmytro@redhat.com>
Co-authored-by: Egor Lunin <banky.webmaster@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Mynhardt Burger <mynhardt@gmail.com>
Co-authored-by: Brent Salisbury <bsalisbu@redhat.com>
Co-authored-by: liangwen12year <36004580+liangwen12year@users.noreply.github.com>
Co-authored-by: Jim Rhyness <jrhyness@redhat.com>
Co-authored-by: somya-bhatnagar <sbhatnag@redhat.com>
Co-authored-by: Jamie Land <38305141+jland-redhat@users.noreply.github.com>
Co-authored-by: Chaitanya Kulkarni <chkulkar@redhat.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Arik Hadas <ahadas@redhat.com>
Co-authored-by: tgitelman <tgitelma@redhat.com>
Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>
Co-authored-by: angaduom <12499805+angaduom@users.noreply.github.com>
Co-authored-by: angaduom <angaduom@users.noreply.github.com>
Co-authored-by: Yuriy Teodorovych <71162952+yu-teo@users.noreply.github.com>
Co-authored-by: Yuriy Teodorovych <Yuriy@ibm.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ready-for-review All changes are complete and CI checks have passed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants