test: verify updated Konflux e2e pipeline

[mynhardtburger]

Summary

• No-op change to trigger Konflux build and validate the updated integration test pipeline from fix: use Konflux snapshot images for MaaS e2e tests odh-konflux-central#238
• That PR extracts both maas-api and maas-controller images from the Konflux snapshot, replacing the hardcoded controller image tag

What to verify

• odh-maas-api-on-pull-request build succeeds
• odh-maas-controller-on-pull-request build succeeds
• Integration test (models-as-a-service-ci-its-manual) picks up both images from the snapshot and runs e2e tests

Change

Removed an emoji from the final log line in prow_run_smoke_test.sh — no functional impact.

Note: This PR should be closed after verifying the pipeline. Do not merge.

Summary by CodeRabbit

• Tests
  • Minor adjustment to test script output formatting.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mynhardtburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mynhardtburger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies test/e2e/scripts/prow_run_smoke_test.sh to remove a celebration emoji (🎉) from the final status message displayed after deployment validation. The line echo "🎉 Deployment completed successfully!" is changed to echo "Deployment completed successfully!". No functional logic, control flow, error handling, or test behavior is altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'test: verify updated Konflux e2e pipeline' is vague and doesn't clearly communicate the actual change: removal of an emoji from a test script's output message.	Clarify the title to reflect the actual change, e.g., 'test: remove emoji from smoke test completion message' or describe the pipeline verification intent more specifically.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

test/e2e/scripts/prow_run_smoke_test.sh (1)

803-803: Cosmetic change as intended; file missing EOF newline.

The emoji removal is straightforward. However, the file does not end with a newline, violating POSIX text file conventions. While pre-existing, consider adding a newline at EOF.

📝 Add newline at EOF

 echo "Deployment completed successfully!"
+

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/scripts/prow_run_smoke_test.sh` at line 803, The file ends with the
echo statement echo "Deployment completed successfully!" but lacks a trailing
newline; open test/e2e/scripts/prow_run_smoke_test.sh, add a single newline
character after the final line (the echo "Deployment completed successfully!"
line) so the file ends with a POSIX-compliant EOF newline and save.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@test/e2e/scripts/prow_run_smoke_test.sh`:
- Line 803: The file ends with the echo statement echo "Deployment completed
successfully!" but lacks a trailing newline; open
test/e2e/scripts/prow_run_smoke_test.sh, add a single newline character after
the final line (the echo "Deployment completed successfully!" line) so the file
ends with a POSIX-compliant EOF newline and save.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ac9f3f2f-8ff7-4fe1-b126-207e278781ed

📥 Commits

Reviewing files that changed from the base of the PR and between 1221310 and f0d96e9.

📒 Files selected for processing (1)

• test/e2e/scripts/prow_run_smoke_test.sh

[mynhardtburger]

The find-image-component task correctly constructed the image tags:

[mynhardtburger]

e2e test are running with the pr tagged images:

[mynhardtburger]

All konflux checks succeeded.

The changes done by opendatahub-io/odh-konflux-central#238 is verified.

[mynhardtburger]

/retest ci/prow/images

[mynhardtburger]

/test images

[chaitanya1731]

Thanks @mynhardtburger for verifying this

[openshift-ci]

@mynhardtburger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-test-maas	f0d96e9	link	false	/test e2e-test-maas

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jland-redhat]

Can we just triple check we are pulling the correct maas-controller image?

I think your change covers this but just want to make sure we are not just pulling latest image which caused issues before.