fix: correct AuthPolicy name in validation script (#658)

[bryonbaker]

The validation script was checking for 'gateway-auth-policy' but the actual deployed AuthPolicy is named 'gateway-default-auth'. This caused false 'NotFound' warnings despite the AuthPolicy being correctly deployed and functional.

Changes:

• Update scripts/validate-deployment.sh line 383 to check for gateway-default-auth instead of gateway-auth-policy

Fixes #658

Description

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Bug Fixes
  • Corrected deployment validation to check the correct authentication policy resource.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryonbaker
Once this PR has been reviewed and has the lgtm label, please assign chaitanya1731 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @bryonbaker. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 414cf2ea-3ecf-4d04-a511-c03731d6fa5b

📥 Commits

Reviewing files that changed from the base of the PR and between 409b0a7 and b6c6090.

📒 Files selected for processing (1)

• scripts/validate-deployment.sh

---

📝 Walkthrough

Walkthrough

The scripts/validate-deployment.sh script now queries the correct AuthPolicy resource name in the openshift-ingress namespace. The resource reference was updated from gateway-auth-policy to gateway-default-auth. The script continues to extract the .status.conditions value for the Accepted condition to determine validation status. No logic or messaging changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately and concisely describes the primary change: correcting the AuthPolicy name in the validation script from 'gateway-auth-policy' to 'gateway-default-auth'.
Linked Issues check	✅ Passed	The PR directly addresses issue #658 by replacing the incorrect AuthPolicy resource name 'gateway-auth-policy' with the correct name 'gateway-default-auth', eliminating the false NotFound warnings.
Out of Scope Changes check	✅ Passed	The change is strictly in-scope, modifying only the AuthPolicy resource name reference to fix the identified issue; no extraneous modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}