Skip to content

Implement model name virtualization feature#685

Draft
srampal wants to merge 1 commit into
opendatahub-io:mainfrom
srampal:model-name-virtualization
Draft

Implement model name virtualization feature#685
srampal wants to merge 1 commit into
opendatahub-io:mainfrom
srampal:model-name-virtualization

Conversation

@srampal
Copy link
Copy Markdown

@srampal srampal commented Apr 6, 2026

Work in progress: Not yet ready for review and merge!

Add virtual name support to ExternalModel and MaaSModelRef CRDs:

  • Add backendModelName and modelAliases fields to specs
  • Add virtualNames and resolvedBackendModelName to status
  • Implement controller logic for virtual name status updates
  • Add validation functions for virtual names and backend models
  • Include comprehensive test coverage
  • Fix duplicate function declaration by moving equalStringSlices to annotations.go

Work in progress - also adding a second PR in the ai-gateway-payload-processing repo to match with this PR in this repo.

This PR will be one of two PRs to be merged for the issue #684

🤖 Generated with Claude Code

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Add virtual name support to ExternalModel and MaaSModelRef CRDs:
- Add backendModelName and modelAliases fields to specs
- Add virtualNames and resolvedBackendModelName to status
- Implement controller logic for virtual name status updates
- Add validation functions for virtual names and backend models
- Include comprehensive test coverage
- Fix duplicate function declaration by moving equalStringSlices to annotations.go

Work in progress - also adding a second PR in the ai-gateway-payload-processing repo to match with this PR in this repo.

This PR will be one of two PRs to be merged for the issue opendatahub-io#684

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: srampal
Once this PR has been reviewed and has the lgtm label, please assign yu-teo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9184064d-2ad2-4cf2-bfd5-3e4a850cdb80

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 11, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jland-redhat
Copy link
Copy Markdown
Contributor

This is a great idea!

But we have developed plans to create a plugin for Model Name virtualization external to MaaS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants