Skip to content

Chore(deps): bump scikit-learn from 1.2.2 to 1.5.1 in /jupyter/trustyai/ubi9-python-3.11 #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 20, 2025

Bumps scikit-learn from 1.2.2 to 1.5.1.

Release notes

Sourced from scikit-learn's releases.

Scikit-learn 1.5.1

We're happy to announce the 1.5.1 release.

This release contains fixes for a few regressions introduced in 1.5.

You can see the changelog here: https://scikit-learn.org/stable/whats_new/v1.5.html#version-1-5-1

You can upgrade with pip as usual:

pip install -U scikit-learn

The conda-forge builds can be installed using:

conda install -c conda-forge scikit-learn

Thanks to everyone who contributed to this release !

Scikit-learn 1.5.0

We're happy to announce the 1.5.0 release.

You can read the release highlights under https://scikit-learn.org/stable/auto_examples/release_highlights/plot_release_highlights_1_5_0.html and the long version of the change log under https://scikit-learn.org/stable/whats_new/v1.5.html

This version supports Python versions 3.9 to 3.12.

You can upgrade with pip as usual:

pip install -U scikit-learn

The conda-forge builds can be installed using:

conda install -c conda-forge scikit-learn

Scikit-learn 1.4.2

We're happy to announce the 1.4.2 release.

This release only includes support for numpy 2.

This version supports Python versions 3.9 to 3.12.

You can upgrade with pip as usual:

</tr></table> 

... (truncated)

Commits
  • 70fdc84 Bump version [cd build]
  • b0ec847 DOC Add missing PR number in changelog entry (#29384)
  • 8179b8f DOC Set 1.5.1 release month (#29377)
  • 851c0d6 FIX: accuracy and zero_loss support for multilabel with Array API (#29336)
  • 99d8a32 FIX zero_one_loss breaks with multilabel and Array API (#29269)
  • 059070b ENH Add Array API compatibility to cosine_similarity (#29014)
  • ada571f Fix a regression in GridSearchCV for parameter grids that have arrays of diff...
  • fb26476 🔒 🤖 CI Update lock files for cirrus-arm CI build(s) 🔒 🤖...
  • 5a74cc0 Fix performance regression in ColumnTransformer (#29330)
  • c3d69b2 MAINT Pin the ruff version on CI linters (#29359)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels May 20, 2025
@openshift-ci openshift-ci bot requested review from andyatmiami and harshad16 May 20, 2025 13:41
Copy link
Contributor

openshift-ci bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign caponetto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 20, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dibryant
Copy link
Contributor

/ok-to-test

@dibryant
Copy link
Contributor

snyk related issue: https://app.snyk.io/org/red-hat-openshift-data-science-rhods/project/e19a8b06-314b-4fea-b778-79b9862c9607#issue-SNYK-PYTHON-SCIKITLEARN-7217830

All notebooks seems to be effected on this... maybe need to look into this more or fix it in all

@jiridanek
Copy link
Member

@dibryant I actually love this initiative, if we keep working on this, we may actually get to a much better place!

So, first, github actions for the image that's being changed are failing

======================================================================
FAIL: test_version (__main__.TestSKLearn.test_version)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/ipykernel_92/2268024713.py", line 148, in test_version
    self.assertEqual(actual_major_minor, expected_major_minor, "incorrect version")
AssertionError: '1.5' != '1.2'
- 1.5
?   ^
+ 1.2
?   ^
 : incorrect version

https://github.com/opendatahub-io/notebooks/actions/runs/15139150277/job/42558559004?pr=1126#step:41:822

@jiridanek
Copy link
Member

@dibryant Second, I have no clue whether we have any meaningful automated scikit-learn test that tries to actually import the Python package and compute something with it, be it a hello world example, or something equally simple. From a quick search, looks like we don't have anything like that.

We haven't done any work on the feature coverage sheet https://docs.google.com/spreadsheets/d/1h_ZeQDlbxWKL6wql0K5PR_5ebfMVFolxbO0CBicVVKs/edit?gid=0#gid=0, but it seems clear that we should quickly add "scikit-learn being available and functioning in the python virtual environment in the image" as a supported feature, and write some meaningful test for that.

@jiridanek
Copy link
Member

And, having done that, we may merge these PRs, and any scikit-learn updates that may come later, with peace of mind.

@jiridanek
Copy link
Member

@dibryant Actually, third. The comment in Pipfile says

scikit-learn = "~=1.2.1" # Should be pinned down to this version in order to be compatible with trustyai

Therefore, we also need to have a smoke check for trusty ai, so that we can be sure that the update we are doing is not breaking Trusty AI.

@jiridanek
Copy link
Member

jiridanek commented May 20, 2025

With these two extra tests being written and passing, we should just merge. Not before, though!

@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 21, 2025
@dependabot dependabot bot force-pushed the dependabot/pip/jupyter/trustyai/ubi9-python-3.11/scikit-learn-1.5.1 branch from 566222f to 15fda34 Compare May 21, 2025 02:56
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 21, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 28, 2025
@dependabot dependabot bot force-pushed the dependabot/pip/jupyter/trustyai/ubi9-python-3.11/scikit-learn-1.5.1 branch from 15fda34 to a2f5cf5 Compare May 28, 2025 03:01
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 28, 2025
Bumps [scikit-learn](https://github.com/scikit-learn/scikit-learn) from 1.2.2 to 1.5.1.
- [Release notes](https://github.com/scikit-learn/scikit-learn/releases)
- [Commits](scikit-learn/scikit-learn@1.2.2...1.5.1)

---
updated-dependencies:
- dependency-name: scikit-learn
  dependency-version: 1.5.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/jupyter/trustyai/ubi9-python-3.11/scikit-learn-1.5.1 branch from a2f5cf5 to ef489df Compare June 4, 2025 03:00
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels Jun 4, 2025
Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-ubi9-e2e-tests ef489df link true /test notebooks-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ok-to-test python Pull requests that update python code size/xxl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants