-
Notifications
You must be signed in to change notification settings - Fork 89
Chore(deps): bump scikit-learn from 1.2.2 to 1.5.1 in /jupyter/trustyai/ubi9-python-3.11 #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Chore(deps): bump scikit-learn from 1.2.2 to 1.5.1 in /jupyter/trustyai/ubi9-python-3.11 #1126
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
snyk related issue: https://app.snyk.io/org/red-hat-openshift-data-science-rhods/project/e19a8b06-314b-4fea-b778-79b9862c9607#issue-SNYK-PYTHON-SCIKITLEARN-7217830 All notebooks seems to be effected on this... maybe need to look into this more or fix it in all |
@dibryant I actually love this initiative, if we keep working on this, we may actually get to a much better place! So, first, github actions for the image that's being changed are failing
|
@dibryant Second, I have no clue whether we have any meaningful automated scikit-learn test that tries to actually import the Python package and compute something with it, be it a hello world example, or something equally simple. From a quick search, looks like we don't have anything like that. We haven't done any work on the feature coverage sheet https://docs.google.com/spreadsheets/d/1h_ZeQDlbxWKL6wql0K5PR_5ebfMVFolxbO0CBicVVKs/edit?gid=0#gid=0, but it seems clear that we should quickly add "scikit-learn being available and functioning in the python virtual environment in the image" as a supported feature, and write some meaningful test for that. |
And, having done that, we may merge these PRs, and any scikit-learn updates that may come later, with peace of mind. |
@dibryant Actually, third. The comment in Pipfile says
Therefore, we also need to have a smoke check for trusty ai, so that we can be sure that the update we are doing is not breaking Trusty AI. |
With these two extra tests being written and passing, we should just merge. Not before, though! |
566222f
to
15fda34
Compare
15fda34
to
a2f5cf5
Compare
Bumps [scikit-learn](https://github.com/scikit-learn/scikit-learn) from 1.2.2 to 1.5.1. - [Release notes](https://github.com/scikit-learn/scikit-learn/releases) - [Commits](scikit-learn/scikit-learn@1.2.2...1.5.1) --- updated-dependencies: - dependency-name: scikit-learn dependency-version: 1.5.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
a2f5cf5
to
ef489df
Compare
@dependabot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bumps scikit-learn from 1.2.2 to 1.5.1.
Release notes
Sourced from scikit-learn's releases.
... (truncated)
Commits
70fdc84
Bump version [cd build]b0ec847
DOC Add missing PR number in changelog entry (#29384)8179b8f
DOC Set 1.5.1 release month (#29377)851c0d6
FIX:accuracy
andzero_loss
support for multilabel with Array API (#29336)99d8a32
FIXzero_one_loss
breaks with multilabel and Array API (#29269)059070b
ENH Add Array API compatibility tocosine_similarity
(#29014)ada571f
Fix a regression in GridSearchCV for parameter grids that have arrays of diff...fb26476
🔒 🤖 CI Update lock files for cirrus-arm CI build(s) 🔒 🤖...5a74cc0
Fix performance regression in ColumnTransformer (#29330)c3d69b2
MAINT Pin the ruff version on CI linters (#29359)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.