Skip to content

NO-JIRA: chore(check-params-env GHA): fix the variable parsing #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

jstourac
Copy link
Member

This is a followup for the #1134.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac jstourac self-assigned this May 27, 2025
@openshift-ci openshift-ci bot requested review from andyatmiami and daniellutz May 27, 2025 11:47
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jstourac. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/xs label May 27, 2025
@jstourac
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented May 27, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 27, 2025
@jstourac jstourac merged commit e9e233f into opendatahub-io:main May 27, 2025
10 of 11 checks passed
@jstourac jstourac deleted the fixCi branch May 27, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants