-
Notifications
You must be signed in to change notification settings - Fork 89
RHOAIENG-24438: Create Jupyter Data Science Python 3.12 Image #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-24438: Create Jupyter Data Science Python 3.12 Image #1137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an info there is already some 2025 version out there - https://packages.microsoft.com/rhel/9.0/mssql-server-2025/; but yeah, it's not purpose of this PR, so no action needed.
except Exception: | ||
raise click.ClickException("Pipeline validation FAILED.") | ||
- | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe, don't like this change, but it's same as we already have in our main branch, so... leaving this up to you whether you will update or not
Thank you for this, Diamond. I put couple of comments, otherwise LGTM. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c334bd6
into
opendatahub-io:python-3.12
Fixes for https://issues.redhat.com/browse/RHOAIENG-24438
Description
Created Jupyter Data Science Python 3.12 Image.
How Has This Been Tested?
Merge criteria: