Skip to content

RHOAIENG-24438: Create Jupyter Data Science Python 3.12 Image #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dibryant
Copy link
Contributor

@dibryant dibryant commented May 28, 2025

Fixes for https://issues.redhat.com/browse/RHOAIENG-24438

Description

Created Jupyter Data Science Python 3.12 Image.

How Has This Been Tested?

$ make jupyter-datascience-ubi9-python-3.12 \
     -e RELEASE_PYTHON_VERSION=3.12 \
     -e IMAGE_REGISTRY="quay.io/${YOUR_USER}/workbench-images" \
     -e RELEASE="2025b" \
     -e CONTAINER_BUILD_CACHE_ARGS="" \
     -e PUSH_IMAGES="no"
$ export QUAY_IMAGE=$(podman images --format "{{.Repository}}:{{.Tag}}" | head -1)
$ podman run -it -p 8888:8888 $QUAY_IMAGE
import sys
print(sys.version)

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an info there is already some 2025 version out there - https://packages.microsoft.com/rhel/9.0/mssql-server-2025/; but yeah, it's not purpose of this PR, so no action needed.

except Exception:
raise click.ClickException("Pipeline validation FAILED.")
-
+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, don't like this change, but it's same as we already have in our main branch, so... leaving this up to you whether you will update or not

@jstourac
Copy link
Member

Thank you for this, Diamond. I put couple of comments, otherwise LGTM.

@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 29, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 29, 2025
@dibryant dibryant changed the title creating jupyter datascience python 3.12 image RHOAIENG-24438: Create Jupyter Data Science Python 3.12 Image May 29, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 29, 2025
@jstourac
Copy link
Member

/lgtm

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c334bd6 into opendatahub-io:python-3.12 Jun 2, 2025
9 checks passed
@dibryant dibryant deleted the rhoaieng24438 branch June 2, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants