Exiting PDF install script with error code if commands fail #1148
Conversation
jupyter/utils/install_pdf_deps.sh
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| # Install dependencies required for Notebooks PDF exports | |||
|
|
|||
| set -e | |||
There was a problem hiding this comment.
Yep, that's how this is normally done
https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/
There are some piped commands below, so also consider
set -o pipefail
The bash shell normally only looks at the exit code of the last command of a pipeline. This behavior is not ideal as it causes the -e option to only be able to act on the exit code of a pipeline’s last command. This is where
-o pipefailcomes in.
For better build log, I also suggest set -x
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This forces the script to exit with error if some of the commands fail. closes #1147
How Has This Been Tested?
Tested locally making sure that the image is not built when the script fails