reapply RHOAIENG-32541: fix(subscription): remove subscription-manager.*register from Dockerfiles to have Konflux do it for us (#2686)
#2785
Conversation
|
Skipping CI for Draft Pull Request. |
|
Warning Rate limit exceeded@jiridanek has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 44 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (24)
WalkthroughReplaced the fallback message in subscription-manager refresh blocks from "Not registered, skipping refresh." to "No identity, skipping refresh." across multiple Dockerfiles and a shared fragment; added a test that scans Dockerfile* files for an unintended subscription-manager register invocation pattern. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
the
review-requested
jiridanek
force-pushed
the
jd_rstudio_offboard_rhds_
branch
from
4eb6402 to
d7bf499
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ide-developer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu (1)
59-65: Remove remaining subscription-manager register invocations from rstudio Dockerfiles.The PR claim of removing
subscription-manager.*registercommands is incomplete. Two active register invocations remain:
rstudio/rhel9-python-3.12/Dockerfile.cuda:198rstudio/rhel9-python-3.12/Dockerfile.cpu:95The updated "No identity, skipping refresh" message is correctly deployed across other Dockerfiles, but these registration patterns must be removed to complete the stated objective.
🧹 Nitpick comments (1)
tests/test_main.py (1)
48-48: Fix capitalization typo.Minor typo: "But It is" should be "But it is".
Apply this diff:
- f" Modify the test if this is intended behaviour. But It is very reasonable to assume it is a mistake." + f" Modify the test if this is intended behaviour. But it is very reasonable to assume it is a mistake."
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (22)
codeserver/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu(1 hunks)rstudio/c9s-python-3.12/Dockerfile.cpu(1 hunks)rstudio/c9s-python-3.12/Dockerfile.cuda(1 hunks)runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu(1 hunks)runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu(1 hunks)runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/pytorch/ubi9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm(1 hunks)runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm(1 hunks)runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda(1 hunks)scripts/dockerfile_fragments.py(1 hunks)tests/test_main.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (49)
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-minimal-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cuda-py312-c9s-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-llmcompressor-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-codeserver-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-trustyai-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cpu-py312-c9s-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-tensorflow-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-tensorflow-cuda-py312-ubi9-on-pull-request
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
- GitHub Check: build (rocm-runtime-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (runtime-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
- GitHub Check: build (rocm-runtime-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (cuda-jupyter-pytorch-llmcompressor-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (cuda-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rstudio-c9s-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-datascience-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-llmcompressor-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-trustyai-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-rstudio-c9s-python-3.12, 3.12, linux/amd64, false) / build
🔇 Additional comments (23)
rstudio/c9s-python-3.12/Dockerfile.cuda (1)
28-33: LGTM - More accurate message.The updated message "No identity, skipping refresh." better reflects the
subscription-manager identitycheck than the previous "Not registered, skipping refresh." Control flow remains unchanged.runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda (1)
20-25: LGTM - Consistent message update.Same improvement as other Dockerfiles, making the fallback message more accurate.
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm (1)
18-23: LGTM - Consistent message update.The message update aligns with the subscription-manager identity check.
jupyter/minimal/ubi9-python-3.12/Dockerfile.cuda (1)
28-33: LGTM - Consistent message update.Message accurately reflects the identity check behavior.
jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu (1)
49-54: LGTM - Consistent message update.Message update improves clarity.
jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm (1)
26-31: LGTM - Consistent message update.Message accurately reflects the identity check.
scripts/dockerfile_fragments.py (1)
53-61: LGTM - Template source updated correctly.This template update ensures consistency across all Dockerfiles that use this fragment. The message "No identity, skipping refresh." accurately describes the subscription-manager identity check failure.
jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu (1)
59-65: LGTM - Consistent message update.Message update aligns with the subscription-manager identity check.
jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu (1)
32-32: LGTM! Message update improves clarity.The updated message "No identity, skipping refresh." more accurately reflects the failure condition of the
subscription-manager identitycheck.runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm (1)
21-21: LGTM! Consistent message update.The message change aligns with other Dockerfiles in this PR and accurately describes the identity check failure.
jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda (1)
39-39: LGTM! Message update is consistent.The updated fallback message is more precise and aligns with the pattern applied across all Dockerfiles.
codeserver/ubi9-python-3.12/Dockerfile.cpu (1)
86-86: LGTM! Consistent with project-wide update.The message change is appropriate and maintains consistency with other Dockerfiles in this PR.
runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu (1)
33-33: LGTM! Message accurately reflects the condition.The updated message correctly describes what happens when the subscription-manager identity check fails.
rstudio/c9s-python-3.12/Dockerfile.cpu (1)
35-35: LGTM! Consistent message update.The change maintains consistency with the project-wide subscription-manager message standardization.
jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda (1)
39-39: LGTM! Message update is appropriate.The updated message is more accurate and aligns with the subscription-manager identity check behavior.
runtimes/pytorch/ubi9-python-3.12/Dockerfile.cuda (1)
23-23: LGTM! Message update is consistent and accurate.The change aligns with the project-wide update and more precisely describes the identity check failure condition.
runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda (1)
22-27: LGTM!The updated message "No identity, skipping refresh." accurately reflects the condition being checked (
subscription-manager identity). The control flow remains correct: check for subscription-manager availability, then attempt identity check and refresh, with a graceful fallback message if identity isn't available.runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu (1)
26-31: LGTM!Consistent with the other Dockerfiles in this PR. The message update accurately reflects the identity check condition.
jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.rocm (1)
34-39: LGTM!Consistent subscription-manager handling update. The message accurately reflects the identity check.
jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda (1)
36-41: LGTM!Consistent subscription-manager handling update across Dockerfiles.
jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm (1)
34-39: LGTM!Consistent subscription-manager handling update. All 5 Dockerfiles now use the more accurate "No identity, skipping refresh." message that correctly describes the
subscription-manager identitycheck being performed.tests/test_main.py (2)
32-50: Good defensive test to prevent Konflux registration bypass.The test logic is sound and will effectively catch unintended subscription-manager patterns in Dockerfiles that would disable Konflux's automatic registration.
38-39: Update the Konflux buildah task reference to the current version.The review comment references buildah task version 0.6 at lines L795-L813, but current Konflux documentation indicates buildah task versions have progressed to 0.2, 0.4, and beyond. Verify that the reference URL is still accurate and that the regex pattern
^[^#]*subscription-manager.[^#]*registerstill matches the latest Konflux buildah task's subscription-manager detection logic. If the buildah task version or URL has changed, update the reference to point to the current implementation.
| RUN /bin/bash <<'EOF' | ||
| set -Eeuxo pipefail | ||
| if command -v subscription-manager &> /dev/null; then | ||
| subscription-manager identity &>/dev/null && subscription-manager refresh || echo "Not registered, skipping refresh." | ||
| subscription-manager identity &>/dev/null && subscription-manager refresh || echo "No identity, skipping refresh." | ||
| fi | ||
| EOF |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for any subscription-manager register invocations in Dockerfile files
echo "Searching for subscription-manager register patterns in all files..."
rg 'subscription-manager\s+register' -i
echo -e "\n---\nSearching for subscription-manager with register in Dockerfile context..."
fd -e Dockerfile -e dockerfile | while read file; do
echo "Checking: $file"
grep -n 'subscription-manager' "$file" 2>/dev/null | head -20
doneRepository: opendatahub-io/notebooks
Length of output: 495
Incomplete removal: subscription-manager register commands still exist in rstudio Dockerfiles.
The search confirms subscription-manager register invocations remain in the codebase at:
- rstudio/rhel9-python-3.12/Dockerfile.cuda
- rstudio/rhel9-python-3.12/Dockerfile.cpu
If the PR objective is to remove all such commands, these files need to be updated as well. If these files are out of scope, clarify that in the PR description.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for subscription-manager register patterns in the codebase
echo "=== Searching for subscription-manager register patterns ==="
rg -n 'subscription-manager\s+(--.*\s+)*register' -i
echo -e "\n=== Checking specific rstudio files mentioned in original comment ==="
if [ -f "rstudio/rhel9-python-3.12/Dockerfile.cuda" ]; then
echo "File: rstudio/rhel9-python-3.12/Dockerfile.cuda"
grep -n 'subscription-manager' "rstudio/rhel9-python-3.12/Dockerfile.cuda" || echo "No subscription-manager found"
else
echo "File rstudio/rhel9-python-3.12/Dockerfile.cuda not found"
fi
echo ""
if [ -f "rstudio/rhel9-python-3.12/Dockerfile.cpu" ]; then
echo "File: rstudio/rhel9-python-3.12/Dockerfile.cpu"
grep -n 'subscription-manager' "rstudio/rhel9-python-3.12/Dockerfile.cpu" || echo "No subscription-manager found"
else
echo "File rstudio/rhel9-python-3.12/Dockerfile.cpu not found"
fi
echo -e "\n=== Listing all rstudio Dockerfile files ==="
fd -t f 'Dockerfile' rstudio/
Length of output: 2099
🏁 Script executed:
#!/bin/bash
# Check the test that mentions subscription-manager register
echo "=== Checking the test for subscription-manager register pattern ==="
cat tests/test_main.py | grep -A 20 "test_dockerfiles_unintended_subscription_manager_pattern"
echo -e "\n=== Show context around the register commands in rstudio files ==="
echo "File: rstudio/rhel9-python-3.12/Dockerfile.cuda (lines 195-200)"
sed -n '195,200p' rstudio/rhel9-python-3.12/Dockerfile.cuda
echo -e "\nFile: rstudio/rhel9-python-3.12/Dockerfile.cpu (lines 92-98)"
sed -n '92,98p' rstudio/rhel9-python-3.12/Dockerfile.cpu
Length of output: 2060
@jiridanek, the issue is not yet fixed. The verification shows that subscription-manager register commands still exist in the same files I flagged:
-
rstudio/rhel9-python-3.12/Dockerfile.cuda at line 198:
subscription-manager register \
-
rstudio/rhel9-python-3.12/Dockerfile.cpu at line 95:
subscription-manager register \
Additionally, the test you added (test_dockerfiles_unintended_subscription_manager_pattern) should actually fail on these remaining instances since they match the pattern ^[^#]*subscription-manager.[^#]*register.
To fix this issue, you need to either:
- Remove these
subscription-manager registerinvocations from both files (consistent with the PR objective), or - Comment them out if they need to be preserved for reference
Have you run make test locally? The test should catch these patterns.
jiridanek
force-pushed
the
jd_rstudio_offboard_rhds_
branch
from
d7bf499 to
d3bdc10
Compare
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
rstudio/rhel9-python-3.12/Dockerfile.cuda (1)
188-207: Remove subscription-manager register and unregister blocks per PR objectives.The PR title states "remove
subscription-manager.*registerfrom Dockerfiles to have Konflux do it for us" (RHOAIENG-32541), but these blocks remain in both Dockerfile.cpu and Dockerfile.cuda. When subscription-manager register commands are included in Containerfiles, Konflux's automatic registration is disabled. Remove the register block (lines 188-207) and the corresponding unregister block (lines 339-342) to allow Konflux to handle subscription management.
♻️ Duplicate comments (3)
rstudio/rhel9-python-3.12/Dockerfile.cuda (1)
338-344: subscription-manager unregister also remains.Similar to the register block, this unregister section should likely be removed as part of RHOAIENG-32541.
rstudio/rhel9-python-3.12/Dockerfile.cpu (2)
84-103: subscription-manager register still present despite PR objectives.This file has the same issue as rstudio/rhel9-python-3.12/Dockerfile.cuda: the subscription-manager register block remains with a TODO comment referencing RHOAIENG-32541, which contradicts the PR title stating these calls should be removed.
236-243: subscription-manager unregister also remains.Similar to the register block, this should be addressed per PR objectives and RHOAIENG-32541.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (24)
codeserver/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu(1 hunks)rstudio/c9s-python-3.12/Dockerfile.cpu(1 hunks)rstudio/c9s-python-3.12/Dockerfile.cuda(1 hunks)rstudio/rhel9-python-3.12/Dockerfile.cpu(1 hunks)rstudio/rhel9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu(1 hunks)runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu(1 hunks)runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/pytorch/ubi9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm(1 hunks)runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm(1 hunks)runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda(1 hunks)scripts/dockerfile_fragments.py(1 hunks)tests/test_main.py(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda
🚧 Files skipped from review as they are similar to previous changes (12)
- jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu
- jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu
- runtimes/pytorch/ubi9-python-3.12/Dockerfile.cuda
- rstudio/c9s-python-3.12/Dockerfile.cpu
- runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu
- jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm
- jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda
- jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu
- scripts/dockerfile_fragments.py
- jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda
- jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.rocm
- jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm
🧰 Additional context used
🪛 GitHub Actions: Code static analysis
rstudio/rhel9-python-3.12/Dockerfile.cpu
[warning] 28-28: SC3020: In POSIX sh, &> is undefined.
[warning] 36-36: SC3041: In POSIX sh, set flag -E is undefined.
[warning] 127-127: SC3041: In POSIX sh, set flag -E is undefined.
[warning] 137-137: SC3041: In POSIX sh, set flag -E is undefined.
[warning] 206-206: SC3041: In POSIX sh, set flag -E is undefined.
[warning] 238-238: SC3041: In POSIX sh, set flag -E is undefined.
[warning] 249-249: SC3041: In POSIX sh, set flag -E is undefined.
rstudio/rhel9-python-3.12/Dockerfile.cuda
[warning] 28-28: SC3020: In POSIX sh, &> is undefined.
[warning] 36-36: SC3041: In POSIX sh, set flag -E is undefined.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (51)
- GitHub Check: build (cuda-rstudio-c9s-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-runtime-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-pytorch-llmcompressor-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (cuda-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-trustyai-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-llmcompressor-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (runtime-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
- GitHub Check: build (rocm-runtime-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-datascience-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (rstudio-c9s-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-tensorflow-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cpu-py312-c9s-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cuda-py312-rhel9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-trustyai-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-tensorflow-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cuda-py312-c9s-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-llmcompressor-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cpu-py312-rhel9-on-pull-request
- GitHub Check: build (rstudio-rhel9-python-3.12, 3.12, linux/amd64, true) / build
- GitHub Check: build (cuda-rstudio-rhel9-python-3.12, 3.12, linux/amd64, true) / build
🔇 Additional comments (10)
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm (1)
18-23: LGTM! Improved message clarity.The updated message "No identity, skipping refresh." more accurately reflects the condition being checked (
subscription-manager identity). The control flow remains unchanged.rstudio/c9s-python-3.12/Dockerfile.cuda (1)
28-33: LGTM! Consistent message improvement.The message update aligns with the identity check logic and matches the pattern across other Dockerfiles in this PR.
rstudio/rhel9-python-3.12/Dockerfile.cuda (1)
27-31: LGTM! Message improvement applied consistently.The updated message accurately reflects the identity check condition.
Note: The pipeline warning (SC3020) about
&>being undefined in POSIX sh is a false positive since the script explicitly uses/bin/bash(line 28).runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda (1)
22-27: LGTM! Consistent with other updates.Message accurately reflects the identity check logic.
jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda (1)
36-41: LGTM! Message improvement applied.The updated fallback message is more precise and consistent with the identity check.
jupyter/minimal/ubi9-python-3.12/Dockerfile.cuda (1)
28-33: LGTM! Consistent message update.The change improves clarity without affecting functionality.
rstudio/rhel9-python-3.12/Dockerfile.cpu (1)
27-31: LGTM! Message clarity improved.The updated message is more precise and aligns with the identity check.
Note: Pipeline warnings about POSIX sh syntax (SC3020, SC3041) are false positives since the script uses
/bin/bashwith heredoc syntax (line 28).runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm (1)
18-23: LGTM! Final file with consistent update.The message improvement is applied consistently across all files in this PR.
runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu (1)
26-31: LGTM! Message now accurately reflects the identity check.The updated message "No identity, skipping refresh." is more precise than the previous "Not registered, skipping refresh." since the condition explicitly checks
subscription-manager identity.codeserver/ubi9-python-3.12/Dockerfile.cpu (1)
83-88: LGTM! Consistent message update.This change mirrors the update in
runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu, ensuring consistent messaging across Dockerfiles.
jiridanek
force-pushed
the
jd_rstudio_offboard_rhds_
branch
from
d3bdc10 to
e43fb05
Compare
…er.*register` from Dockerfiles to have Konflux do it for us (opendatahub-io#2686)
jiridanek
force-pushed
the
jd_rstudio_offboard_rhds_
branch
from
e43fb05 to
59640a6
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
rstudio/rhel9-python-3.12/Dockerfile.cuda (2)
338-343: Incomplete removal: subscription-manager unregister still present.Similar to the register code above, this file still contains
subscription-manager unregisterlogic (lines 340-342) with a TODO comment referencing RHOAIENG-32541. This should likely be removed as part of offboarding subscription management to Konflux.
162-206: Incomplete removal: subscription-manager register present in multiple Dockerfiles.The PR indicates removing
subscription-manager.*registerinvocations to let Konflux handle registration. However, bothrstudio/rhel9-python-3.12/Dockerfile.cuda(line 198) andrstudio/rhel9-python-3.12/Dockerfile.cpu(line 95) still contain explicitsubscription-manager registercode. The TODO comments reference RHOAIENG-32541, confirming this code should be removed.
♻️ Duplicate comments (1)
tests/test_main.py (1)
32-52: Capitalization fix required (duplicate issue).Line 50 contains a capitalization error: "But It is" should be "But it is". This was previously flagged in a past review.
Apply this diff to fix the capitalization:
- f" Modify the test if this is intended behaviour. But It is very reasonable to assume it is a mistake." + f" Modify the test if this is intended behaviour. But it is very reasonable to assume it is a mistake."
🧹 Nitpick comments (1)
tests/test_main.py (1)
44-45: Verify the RStudio exclusion is documented.The test intentionally skips
rstudio/rhel9-python-3.12because it still contains subscription-manager register code. Consider adding a comment explaining why this exclusion exists and linking it to the incomplete work identified in that file.if file.is_relative_to(PROJECT_ROOT / "rstudio/rhel9-python-3.12"): - continue # Skip RStudio Dockerfiles + continue # Skip RStudio RHEL9: still contains subscription-manager register for migration (RHOAIENG-32541)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (24)
codeserver/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm(1 hunks)jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda(1 hunks)jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu(1 hunks)rstudio/c9s-python-3.12/Dockerfile.cpu(1 hunks)rstudio/c9s-python-3.12/Dockerfile.cuda(1 hunks)rstudio/rhel9-python-3.12/Dockerfile.cpu(1 hunks)rstudio/rhel9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu(1 hunks)runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu(1 hunks)runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/pytorch/ubi9-python-3.12/Dockerfile.cuda(1 hunks)runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm(1 hunks)runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm(1 hunks)runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda(1 hunks)scripts/dockerfile_fragments.py(1 hunks)tests/test_main.py(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (17)
- jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu
- runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm
- scripts/dockerfile_fragments.py
- rstudio/c9s-python-3.12/Dockerfile.cuda
- jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm
- jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm
- rstudio/rhel9-python-3.12/Dockerfile.cpu
- jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu
- runtimes/pytorch/ubi9-python-3.12/Dockerfile.cuda
- jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu
- runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda
- runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm
- jupyter/minimal/ubi9-python-3.12/Dockerfile.cuda
- jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda
- runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu
- codeserver/ubi9-python-3.12/Dockerfile.cpu
- runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda
🧰 Additional context used
🪛 GitHub Actions: Code static analysis
rstudio/rhel9-python-3.12/Dockerfile.cuda
[warning] 1-1: Hadolint warning: SC3020 In POSIX sh, &> is undefined.
[warning] 1-1: Hadolint warning: SC3041 In POSIX sh, set flag -E is undefined.
[warning] 1-1: Hadolint warning: SC3041 In POSIX sh, set flag -E is undefined.
[warning] 1-1: Hadolint warning: SC3041 In POSIX sh, set flag -E is undefined.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (53)
- GitHub Check: build (jupyter-trustyai-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (rocm-runtime-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-runtime-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-pytorch-llmcompressor-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rstudio-c9s-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-llmcompressor-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-rstudio-c9s-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (runtime-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-datascience-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (cuda-rstudio-rhel9-python-3.12, 3.12, linux/amd64, true) / build
- GitHub Check: build (rstudio-rhel9-python-3.12, 3.12, linux/amd64, true) / build
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-minimal-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-llmcompressor-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cuda-py312-rhel9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cuda-py312-c9s-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cpu-py312-c9s-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-trustyai-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-tensorflow-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-codeserver-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-pytorch-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-datascience-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cpu-py312-rhel9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-pipeline-runtime-tensorflow-rocm-py312-ubi9-on-pull-request
🔇 Additional comments (6)
jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.rocm (1)
34-39: LGTM! More accurate message.The message change from "Not registered, skipping refresh." to "No identity, skipping refresh." better reflects the actual check being performed (identity verification rather than registration status).
runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu (1)
30-35: LGTM! Consistent message update.The message change aligns with the identity check being performed and is consistent with similar updates across the codebase.
rstudio/rhel9-python-3.12/Dockerfile.cuda (1)
28-31: LGTM! Consistent message update.The message change is consistent with similar updates across all Dockerfiles in this PR.
jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda (1)
36-41: LGTM! Consistent message update.The message accurately reflects the identity check being performed.
rstudio/c9s-python-3.12/Dockerfile.cpu (1)
32-37: LGTM! Consistent message update.The message change is consistent with the pattern applied across all Dockerfiles.
jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda (1)
36-41: LGTM! Consistent message update.The message change aligns with the identity verification logic.
2 participants
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.