-
Notifications
You must be signed in to change notification settings - Fork 125
RHOAIENG-42342: update to Elyra 4.3.2 #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
jupyter/datascience/ubi9-python-3.12/pylock.toml(1 hunks)jupyter/datascience/ubi9-python-3.12/pyproject.toml(1 hunks)jupyter/pytorch+llmcompressor/ubi9-python-3.12/pylock.toml(1 hunks)jupyter/pytorch+llmcompressor/ubi9-python-3.12/pyproject.toml(1 hunks)jupyter/pytorch/ubi9-python-3.12/pylock.toml(1 hunks)jupyter/pytorch/ubi9-python-3.12/pyproject.toml(1 hunks)jupyter/rocm/pytorch/ubi9-python-3.12/pylock.toml(1 hunks)jupyter/rocm/pytorch/ubi9-python-3.12/pyproject.toml(1 hunks)jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml(1 hunks)jupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.toml(1 hunks)jupyter/tensorflow/ubi9-python-3.12/pylock.toml(1 hunks)jupyter/tensorflow/ubi9-python-3.12/pyproject.toml(1 hunks)jupyter/trustyai/ubi9-python-3.12/pylock.toml(1 hunks)jupyter/trustyai/ubi9-python-3.12/pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
- GitHub Check: build (cuda-jupyter-pytorch-llmcompressor-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rocm-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-pytorch-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-trustyai-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (rocm-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-trustyai-cpu-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-llmcompressor-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-pytorch-cuda-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-tensorflow-rocm-py312-ubi9-on-pull-request
- GitHub Check: Red Hat Konflux / odh-workbench-jupyter-datascience-cpu-py312-ubi9-on-pull-request
🔇 Additional comments (14)
jupyter/pytorch/ubi9-python-3.12/pyproject.toml (1)
35-35: Version bump is consistent and correct.The
odh-elyraupdate to version 4.3.2 is consistent with the changes across other environments.jupyter/pytorch+llmcompressor/ubi9-python-3.12/pyproject.toml (1)
47-47: Version bump is consistent and correct.The
odh-elyraupdate to version 4.3.2 is consistent with the changes across other environments.jupyter/tensorflow/ubi9-python-3.12/pyproject.toml (1)
35-35: Version bump is consistent and correct.The
odh-elyraupdate to version 4.3.2 is consistent with the changes across other environments.jupyter/trustyai/ubi9-python-3.12/pyproject.toml (1)
53-53: Version bump is consistent and correct.The
odh-elyraupdate to version 4.3.2 is consistent with the changes across other environments.jupyter/datascience/ubi9-python-3.12/pyproject.toml (2)
30-30: All odh-elyra references have been successfully updated to 4.3.2.The verification confirms no remaining references to
odh-elyra==4.3.1exist in the codebase. All occurrences across the jupyter environment configurations have been updated to version 4.3.2.
30-30: Version bump requires confirmation and security check.The update from
odh-elyra==4.3.1to4.3.2appears straightforward and aligns with addressing build constraint issues. Confirm that version 4.3.2 is available on PyPI and verify it has no known security vulnerabilities before merging.jupyter/datascience/ubi9-python-3.12/pylock.toml (1)
2910-2915: Unable to verify odh-elyra 4.3.2 exists on PyPI.Web searches found no public record of odh-elyra version 4.3.2. The latest available version found was 4.2.1 (May 2025). The package upload timestamp (2025-12-17) and all associated file hashes cannot be verified through publicly accessible PyPI data or GitHub releases. Before approving this lock file update, confirm that odh-elyra 4.3.2 has been released and that the listed hashes match the published artifacts.
jupyter/trustyai/ubi9-python-3.12/pylock.toml (1)
2679-2682: Verify the package hashes and URLs match the published PyPI release.The version bump from 4.3.1 to 4.3.2 looks correct, with updated sdist and wheel artifacts. The URLs follow standard PyPI file format and hashes are properly formatted. Manual verification of the exact sha256 values against the published release on PyPI is recommended.
jupyter/rocm/pytorch/ubi9-python-3.12/pylock.toml (1)
2933-2936: Lock file entry appears structurally correct; auto-generated metadata typically does not require hash verification at review time.The odh-elyra 4.3.2 version bump and associated metadata (URLs, sizes, timestamps, hashes) follow proper TOML lock file format. Lock files containing package metadata are auto-generated by dependency managers and the hashes are validated during installation. If this PR is addressing the Elyra Build Constraint issue (RHOAIENG-39611), ensure the version update is consistent across all related environment configuration files in the PR.
jupyter/pytorch+llmcompressor/ubi9-python-3.12/pylock.toml (1)
3255-3258: Verify the package hashes match the official PyPI release.The odh-elyra 4.3.2 update is consistently applied across all Jupyter environments (datascience, pytorch, pytorch+llmcompressor, rocm/pytorch, rocm/tensorflow, tensorflow, trustyai) with identical hashes:
- sdist sha256:
be25cf3199f7d4de0489bc085dc16eb5c746e5f3fb9a2a17a6dd71dfffaefde5- wheel sha256:
854ae74994a0e4bbcc86ead10b7218c3b10348c4f3537d776801f3650ab02afaConfirm these checksums against the official PyPI release for odh-elyra 4.3.2.
jupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.toml (1)
38-38: Consistent version update across environments.The
odh-elyraversion update to 4.3.2 is consistent with the PyTorch environment configuration, ensuring uniform dependency versions across all JupyterLab Python 3.12 environments.jupyter/rocm/pytorch/ubi9-python-3.12/pyproject.toml (1)
36-36: odh-elyra 4.3.2 is available on PyPI.The version upgrade from
odh-elyra==4.3.1toodh-elyra==4.3.2is valid; 4.3.2 is the current latest version and is properly published.jupyter/tensorflow/ubi9-python-3.12/pylock.toml (1)
3126-3131: Verify PyPI package availability for odh-elyra 4.3.2Cannot confirm this package version exists on PyPI. While the PyPI page URL is reachable, web access is blocked by JavaScript requirements. The upload timestamp (2025-12-17T19:54:01Z) is extremely recent, and there is no corroborating release information in the opendatahub-io/elyra GitHub repository. The latest confirmed version on PyPI is 4.2.1 (May 7, 2025). Before approval, verify that version 4.3.2 is actually published on PyPI and that the hashes in the lock file match the published distribution.
jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml (1)
2601-2606: LGTM! Dependency update to odh-elyra 4.3.2 looks correct.The lock file entry is properly formatted with updated version, sdist URL, wheel URL, and corresponding SHA256 hashes. All hash values are valid 64-character hex strings, URLs follow the correct PyPI CDN format, and the upload timestamp is recent (2025-12-17).
| [[packages]] | ||
| name = "odh-elyra" | ||
| version = "4.3.1" | ||
| version = "4.3.2" | ||
| marker = "implementation_name == 'cpython' and sys_platform == 'linux'" | ||
| sdist = { url = "https://files.pythonhosted.org/packages/f7/f4/6be53ca16125e7d3ca6cb86aa8f001ebe200977e429bedb4b6467e692328/odh_elyra-4.3.1.tar.gz", upload-time = 2025-10-09T14:53:22Z, size = 2196705, hashes = { sha256 = "522c85c647d97d3a5317389dc106452fdebf48f95ecbdea3db0aef1b43192475" } } | ||
| wheels = [{ url = "https://files.pythonhosted.org/packages/b3/7a/009a5eb3e872330c22155928ffd3dcb8f139385b7de2a7540cad714be9bd/odh_elyra-4.3.1-py3-none-any.whl", upload-time = 2025-10-09T14:53:20Z, size = 4352762, hashes = { sha256 = "ae1008e0329e14d45a4c31b5436b00e732dcaa201cae15adb7f502249bf9d7a8" } }] | ||
| sdist = { url = "https://files.pythonhosted.org/packages/93/c7/0dc3a7827b166b052f66dc6619b81122979669970507493f0b53bb3c9469/odh_elyra-4.3.2.tar.gz", upload-time = 2025-12-17T19:54:01Z, size = 2196786, hashes = { sha256 = "be25cf3199f7d4de0489bc085dc16eb5c746e5f3fb9a2a17a6dd71dfffaefde5" } } | ||
| wheels = [{ url = "https://files.pythonhosted.org/packages/d5/a1/d312dfa66495995682c0a95b172f3796270a18bdff85cb03306645a9f291/odh_elyra-4.3.2-py3-none-any.whl", upload-time = 2025-12-17T19:53:59Z, size = 4352744, hashes = { sha256 = "854ae74994a0e4bbcc86ead10b7218c3b10348c4f3537d776801f3650ab02afa" } }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package existence cannot be verified. odh-elyra 4.3.2 does not appear to exist on PyPI.
Web searches for odh-elyra 4.3.2 return no indexable results despite multiple search strategies. The latest confirmed odh-elyra release is version 4.2.1 (released May 7, 2025). The pylock.toml entry references package files with specific hashes, but these cannot be validated against PyPI because the package version appears to be unavailable or not yet published. Confirm that this version has been released to PyPI and obtain the official hashes for verification before merging.
🤖 Prompt for AI Agents
jupyter/pytorch/ubi9-python-3.12/pylock.toml lines 3069-3074: the referenced
odh-elyra==4.3.2 package cannot be verified on PyPI; confirm whether 4.3.2 has
actually been published — if not, revert this entry to a published version
(e.g., 4.2.1) or wait until 4.3.2 is released; if 4.3.2 is published, fetch the
official sdist and wheel URLs and their authoritative sha256 hashes and sizes
from PyPI, replace the current URLs/hashes/upload-times accordingly, then
regenerate the lock file using your lock tool (poetry/pip-compile/etc.) and
commit the updated pylock.toml.
|
@jesuino: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-42342
Update to Elyra 4.3.2. This is expected to fix Elyra Build Constraint issue.
Summary by CodeRabbit
odh-elyrapackage from version 4.3.1 to 4.3.2 across all Jupyter environments and configurations, including DataScience, PyTorch, TensorFlow, ROCm, and TrustyAI stacks.✏️ Tip: You can customize this high-level summary in your review settings.